doc: improve documentation on provable private keys

Resolves #301

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc: enhanced text on PKCS#7 and public keys

Resolves #302

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: check whether key IDs with SHA512 are corrected calculated

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: allow using SHA512 for key IDs

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

_gnutls_get_key_id: introduce flag GNUTLS_KEYID_USE_SHA512

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: check fingerprint generation with SHA512

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: allow using --fingerprint with sha384 or sha512

Resolves #295

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Modernize gtk-doc support

Update gtk-doc.make, m4/gtk-doc.m4 and doc/reference/Makefile.am from
gtk-doc git head (that is 1.26 +
c08cc78562c59082fc83b55b58747177510b7a70).
Disable gtkdoc-check.

Signed-off-by: Andreas Metzler <ametzler@bebt.de>

Fix autoreconf invocation to actually run autopoint

Signed-off-by: Rowan Thorpe <rowan@rowanthorpe.com>

CONTRIBUTING.md: added some text on introducing new APIs [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: re-purposed client_dsa_key test to match new behavior of the library

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: update TLS 1.2 tests to account for RSA-PSS client signatures

On commit de4f55b4dcf4bbe8f788e1f8f5bd59cd596f7d36:
"signature: on client side, refuse to negotiate non-enabled signature schemes"

the behavior of allowing a client to utilize disabled for the session
signatures, and thus the negotiated signatures now match the ones
in the session's priority string.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

signature: on client side, refuse to negotiate non-enabled signature schemes

That amends/reverts commit 6aa8c390b08a25b18c0799fbd42bd0eec703fae4:
"On client side allow signing with the signature algorithm of our cert"

Previously, when we initially disabled DSA, we allowed client certificates
which can do DSA-SHA1 to be utilized to ease migration from these certificates.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

_gnutls_epoch_gc: ensure there are no stray epochs after gc

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

constate: simplified allocation of epochs

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_epoch_get(): simplified use

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_crt/q_set_spki: always initialize the spki structure

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls-cli: always initialize the inline commands struct

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls-cli-debug: eliminated memory leaks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

ocsptool: eliminate memory leaks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: use assert to protect var access

The code correctly uses the variables, but the assert ensures
that static analyzers follow the intended paths too.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

srptool: removed unused variables

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

psktool: remove unused variables

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls-cli: fix memory leak

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tools: eliminated dead assignments

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

ocsptool: check chain size on verification

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

.gitlab-ci.yml: use static analyzer and Werror build in src

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: enhanced resumption checks with same and different SNI

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

server name: refuse to resume a session which server name doesn't match

That is, follow the RFC6066 requirement that server:
"MUST NOT accept the request to resume the session if the
server_name extension contains a different name."

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls-cli: eliminate few memory leaks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: New test for SNI parsing during cache-based session resumption

Signed-off-by: Thomas Klute <thomas2.klute@uni-dortmund.de>
Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Ensure the SNI extension is parsed during cache-based resumption

This patch changes the parse_type of the SNI extension to
GNUTLS_EXT_MANDATORY to ensure it is parsed during every handshake.

With SNI previously classified as GNUTLS_EXT_APPLICATION, GnuTLS
servers ignored the SNI extension when resuming a TLS session from
cache, because "application" level extensions are skipped during
resumption. As a result, gnutls_server_name_get() always returned
GNUTLS_E_REQUESTED_DATA_NOT_AVAILABLE when called on the resumed
session, breaking virtual server systems.

According to RFC 6066, Section 3 the SNI extension must be parsed on
session resumption if implemented at all:

  "A server that implements this extension MUST NOT accept the request
  to resume the session if the server_name extension contains a
  different name."

This change allows applications using GnuTLS to match SNI data on
resumed sessions.

Signed-off-by: Thomas Klute <thomas2.klute@uni-dortmund.de>

tests: explicitly check for gnutls.pc in pkgconfig.sh

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

test: use proper library name in pkgconfig.sh error message

If there is a -R flag in p11-kit-1.pc file, pkgconfig.sh test will still
reference libidn2.pc, rather than proper source of the message. Also
move the test for library flags before updating PKG_CONFIG_PATH.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

tests: use libidn2 in pkgconfig.sh

Since abe6a12b9766219163f99d7807a0b07fbe5f590c GnuTLS does not support
libidn1. Switch pkgconfig.sh test to use libidn2.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

parse-datetime: Fix buffer overflow

tlsfuzzer: document the reason of failure of few fragmentation tests

It seems that gnutls does not accept records carrying handshake messages
that contain less bytes than necessary to recover the handshake header.
The TLS protocol allows that option, and other implementations seem to
accept that fragmentation.

Relates #272

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

parse_handshake_header: removed duplicate check

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

ecdh: return more appropriate error code on empty packet

This makes tlsfuzzer's test-x25519 detect the right error
code on empty message. Previously this issue was masked by our
refusal to accept 1-byte sized fragments.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

parse_handshake_header: allow 1-byte sized fragments

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added reproducer for DTLS infinite loop

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkcs11/get_key_algo_type(): Always initialize bits variable

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

tests/base64-raw: Remove unused variable

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

gnutls.h: Remove redundant function declarations

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

x509: removed debugging code [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: modified the MD5 signature algorithm negotiation tests

Since GnuTLS can no longer negotiate MD5, we utilize a byte stream
of a connection which advertises MD5, and we make sure we detect the
right error code for the rejection of MD5 signature.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tlsfuzzer: no longer include tests involving SHA224 signatures

We no longer support them.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

algorithms/sign: removed TLS identifiers for legacy algorithms

That is, for the MD5-using algorithms, as well as for the DSA2
signature algorithms that were never really used with TLS 1.2.

Kept DSA-SHA1 in order to be used by TLS 1.2 and legacy applications.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

algorithms/sign: legacy signature algorithms were moved toward the end of the list

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

algorithms/sign: no longer enable SHA224 hash in signatures

TLS 1.3 requires that SHA224 MUST NOT be used, and given the
fact that SHA224 was never widespread used in TLS 1.2, there
is no reason to keep these algorithms at all.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tlsfuzzer: added large client hello tests

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

win32: removed no longer used subdir

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: added warning cppcheck checks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: removed initialization step

That is, combine syntax-check with the static analyzers run. That
provides more parallelism per build and reduces the overall time
spent on a successful run.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: added README on FreeBSD CI setup

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: added FreeBSD build

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: ip-utils: added include for FreeBSD compilation

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: enable more cppcheck tests

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: updated tlsfuzzer to reduce rsa-pss failures

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

crq: doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added unit test for gnutls_x509_crq_sign

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added verification checks into crl_apis

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_crl_verify: check next update field for presence

If not present do not attempt to utilize its value.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added verification check into crt_apis

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added unit test for gnutls_x509_crt_sign

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_crq_sign: undeprecate

After the updates of the function semantics, it is no longer
needed to deprecate it.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_crl_sign: undeprecate

After the updates of the function semantics, it is no longer
needed to deprecate it.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_crq_sign: no longer sign with SHA1

Modify the behavior of the functions to sign with an appropriate
to the public key hash algorithm. That although it modifies the
semantics of the functions, it allows them to be useful even after
SHA1 is considered insecure.

In addition to that, the functions which accept a hash algorithm, will
accept a null hash, which instructs the function to select a
reasonable choice.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_*_sign: no longer sign with SHA1

Modify the behavior of the functions to sign with an appropriate
to the public key hash algorithm. That although it modifies the
semantics of the functions, it allows them to be useful even after
SHA1 is considered insecure.

In addition to that, the functions which accept a hash algorithm, will
accept a null hash, which instructs the function to select a
reasonable choice.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: document the change of gnutls_x509_crt_sign

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: tolerate leaks in opensc-pkcs11 when present

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added reproducer for safe renegotiation failure with openssl

Relates #259

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

handshake: check SCSVs prior to resuming a session

This ensures that extensions which are also available as SCSVs
are parsed prior to resuming a session. This resolves an issue
with openssl sending SCSV instead of an extension for the safe
renegotiation.

Relates #259

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Use $(LIBDL) instead of hardcoding -ldl.

cmocka: require 1.0.1

This prevents failures in test suite due to insufficient cmocka
library version.

Resolves #268

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tlslite-ng: updated to latest version

This addresses issues with RSA-PSS signing.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

cli-debug-args.def: Fix typo

Signed-off-by: Avinash Sonawane <rootkea@gmail.com>

latex: handle the deprecated function mark [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

.gitlab-ci.yml: give more specific name to windows job artifacts [ci skip]

This allows a more descriptive name to any downloaded artifacts.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tools: removed re-using PIN message when in non-verbose mode

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

p11tool: print public or private key algorithm

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_pkcs11_privkey_generate3: doc update [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: check whether generated private keys are marked private

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: added unit test of p11tool with --set-pin

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: check whether generated or copied keys are marked as sensitive

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

updated auto-generated files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

p11tool: allow obtaining PIN from command line on operations

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: eliminate global use of default_dig

Use instead the cinfo->hash field which is already used
by p11tool.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: krb5-test: disable valgrind mem leak checks for negative checks

Resolves #192

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: check whether p11tool signing with RSA-PSS works

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

p11tool: allow signing with RSA-PSS and specifying an explicit hash

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

sign_params_to_flags: moved to certtool-common.c

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: hash_to_id moved to certtool-common.c

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Fix some typos [ci skip]

occurence -> occurrence
sucessful -> successful

Signed-off-by: Andreas Metzler <ametzler@bebt.de>

Fixed segmentation faults caused by accessing NULL pointers during mutex operations. This bug was triggered while setting priorities.

Signed-off-by: Tom Vrancken <email@tomvrancken.nl>

p11tool: explicitly mark generated keys as sensitive

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>