updated auto-generated files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

p11tool: --generate-xxx options were replaced by generate-privkey

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Fix memleaks in gnutls_x509_trust_list_add_crls()

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

Fix memleak in gnutls_x509_crl_list_import()

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

publickey: fixed incorrect assignment

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

mac: simplified iteration functions

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

corrected input to gnutls_sign_supports_pk_algorithm

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

extensions: corrected flag check

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: updated for new rsa-pss key in doc/credentials

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

cert selection: prioritize RSA-PSS certs over RSA

RSA and RSA-PSS can both be used for RSA-PSS operations, and
as such without prioritizing RSA-PSS certificates it is unknown
which certificate will be used for an RSA-PSS operation. The
reason we want to have only RSA-PSS keys used for RSA-PSS operations
is to cover the use case where a server uses a legacy RSA certificate
for clients that don't support RSA-PSS and an RSA-PSS certificate
for the rest, thus separating the keys used for these client
groups. That separation ensures that any issue on PKCS#1 1.5
(legacy RSA), would not affect sessions which use RSA-PSS.

Resolves #243

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_certificate_credentials_t: combine privkey into cert_st structure

This reduces the number of applications and allows for easier
use of the structure information, as they are now self-contained
for most uses.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: verify whether the RSA-PSS key is preferred on RSA-PSS sigs

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: eliminated unused variable

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added negative tests in provable-privkey

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_pk_params_st: separate flags/qbits and curve

Previously we were using the field flags to store the
size of q in case of GNUTLS_PK_DH, some key generation flags
in case of GNUTLS_PK_RSA, and the curve in case of elliptic
curve key. Separate this into multiple fields to reduce
confusion on the field.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: check whether validation parameters are lost on key re-import

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: improved documentation on --provable option

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: create mapping between --load-x and --info options

That allows using:
certtool --certificate-info --load-certificate FILE
and
certtool --certificate-info --infile FILE

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: removed definitions of non-existing functions

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: updated for the new provable private key format

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls_x509_privkey_verify_seed: improved error on missing validation parameters

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: silence warnings related to --pkcs8

There is no reason to bug the user with such details by default.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: better print provable key validation parameters

That is, include hash in the printable set, and keep spaces
from next fields.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: provable private keys are always exported in PKCS#8 form

That allows the provable parameters to be included.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

x509: no longer emit the previous custom format for provable parameters

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

x509: store and read provable seed in PKCS#8 form of key

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Added information on OID registry

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkix.asn: removed unused DomainParameters

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

x509: separated PKIX1 attributes parsing code for cert request handling

This allows other code to utilize it.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_fbase64_decode will always return non-zero

That is, document that fact and update its callers to remove
checks for zero.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_base64_decode: reject all zero-length string encodings on decoding

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

wrap_nettle_pk_fixup: added sanity check in RSA-PSS param checking

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

_decode_pkcs8_rsa_key: signal error in RSA privkey decoding

Addresses oss-fuzz issue:
  https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2865

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: added reproducer for private key crash

Found using oss-fuzz:
  https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2865

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: added unit test of gnutls_x509_crt_list_import

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: added reproducer applications for psk and srp fuzzers

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

updated auto-generated files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls_server_fuzzer: added ed25519 key/cert

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

removed references for "new" semantics of PEM base64 encode and decode

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

base64: reverted the raw semantics from the PEM encoding/decoding functions

Keeping the complex semantics with NULL headers would most likely cause
issues in the future.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

base64: test the new base64 encoding and decoding functions

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

base64: uniformly use GNUTLS_E_BASE64_DECODING_ERROR for decoding errors

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

base64: introduced new functions for base64 encoding

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: gnutls_x509_privkey_import: enhanced to test DER key import

It seems that this function was not tested for multiple cases of
private keys in DER mode.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls_x509_privkey_import: allow importing ed25519 PKCS#8 keys in DER form

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

sign/digest: separate "brokenness" of signatures and hash algorithms

That is, allow digital signatures to be marked as broken irrespective
of their used hash, and restrict hash brokenness to preimage resistance.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

sign: use C99 syntax for signature algorithm's table

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: enable multiple undefined sub-sanitizers

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

updated auto-generated files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

p11tool: auto-generate the list of PKCS#11 mechanisms from p11-kit

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added unit test for gnutls_x509_privkey_import

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added TLS negotiation with various keys under PKCS#11

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

x509_privkey: handle keys which can only have PKCS#8 form transparently

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: updated for errors returned due to early signature selection

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added check for the negotiation of ext keys

That is, check whether we can negotiate TLS with ext abstract
key types, and whether the algorithms which cannot be used
with that key type, gracefully fail.

Relates #234

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

privkey: reject signing with ext keys and GNUTLS_PK_RSA_PSS or GNUTLS_PK_EDDSA_ED25519

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_check_key_cert_match: use the new API for signing

This ensures that the same signature algorithm is used for
signing and verification.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

privkey: return less specific but more appropriate error on invalid pks for ext keys

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

prior to negotiating a signature check compatibility with private key

That is, check if the private key can support the public key operation
needed for the signature. That in particular includes, excluding the
Ed25519 and RSA-PSS from being used with the 'EXT' keys as the
current API cannot handle them, and RSA-PSS from being used by PKCS#11
RSA keys which do not provide the CKM_RSA_PKCS_PSS mechanism.

Relates #234
Resolves #209

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkcs11: mark RSA PKCS#11 key which can do RSA-PSS

Also refuse to sign with RSA-PSS if the mechanism is not supported.

Relates #208

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

handshake: select a signature algorithm early

That is, select the signature algorithm at the point the certificate and
ciphersuites are decided. Also ensure that a compatible signature algorithm
with the ciphersuite and the key is selected.

That prevents situations where a ciphersuite and a certificate are
negotiated, but later on the handshake we figure that there are no
common signature algorithms.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added basic unit test of gnutls_pkcs11_token_check_mechanism

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_pkcs11_token_check_mechanism: introduced function to check token for a particular mechanism

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

updated auto-generated files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

x509/output: print error on invalid public key parameters on certificate

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_pk_get_oid: return early on unknown algorithm

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: check whether the gnutls_x509_*_set_spki will reject invalid values

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: updated for gnutls_x509_spki_get_rsa_pss_params

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added unit test of generation of legal and illegal rsa-pss parameters

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

spki: combined all exported functions to a single set and get

This simplifies setting parameters for a particular key type,
as well as getting them. The advantage is that they are set
atomically, preventing an inadverterly half-filled structure.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: set RSA-PSS parameters using GNUTLS_KEYGEN_SPKI kdata type

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

introduced error code GNUTLS_E_PK_INVALID_PUBKEY_PARAMS

This is being use to indicate errors in the public key parameters
such as the RSA-PSS salt size or digest algorithm.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_privkey_generate*: allow specifying the SPKI parameters for key generation

This in turn removes the need for reading the flag GNUTLS_PRIVKEY_FLAG_REPRODUCIBLE
on the key generation process. The flag is now only used during key signing
which is also its documented purpose.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_privkey_set_spki: check validity of parameters set

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_cr*_set_spki: check for validity of parameters set

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_x509_check_pubkey_params: removed unnecessary parameter

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added check for import of RSA-PSS key with invalid salt

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_pubkey_import_x509: propagate errors from gnutls_x509_crt_get_pk_algorithm

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_rsa_pss_verify_digest: verify the validity of the salt_size length on verification

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_privkey_import: immediately exit on GNUTLS_E_PK_INVALID_PRIVKEY

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

wrap_nettle_pk_fixup: check RSA PSS parameters for validity on import

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_*_set_spki: removed arbitrary restrictions to setting parameters

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added unit test for the SPKI abstract functions

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: chainverify: included negative and positive tests with RSA-PSS signed chains

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pct_test: use local SPKI structure to override parameters if not set

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

fixup_spki_params: use GNUTLS_E_CONSTRAINT_ERROR for RSA-PSS violations

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_x509_read_pkalgo_params: initialize params structure

That is the primary call on these parameters, thus it should
initialize the structure with something reasonable. That is
similar to behavior of _gnutls_x509_read_rsa_pss_params.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

RSA-PSS parameter checking was moved to lower level functions

That way all PKI callers get protected by the checks.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

signature security level check were moved to lower level functions

That way all callers (including PKI functions) get protected by
the available checks.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_wrap_nettle_pk_encrypt: return GNUTLS_E_INVALID_REQUEST on unsupported algorithms

That is a more specific error code than internal error.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: print signature algorithm in cert verification output

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

verify_crt: translate GNUTLS_E_CONSTRAINT_ERROR to verification status flag

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

x509/sign: in debugging mode print the signature algorithm

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_x509_validate_sign_params: use GNUTLS_E_CONSTRAINT_ERROR for mismatch of RSA-PSS parameters

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_x509_read_rsa_pss_params: fail early on unknown hash algorithms

Also utilize GNUTLS_E_CONSTRAINT_ERROR for signaling differences
between the hash functions.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_pubkey_get_preferred_hash_algorithm: will take into account the RSA-PSS SPKI

In addition it will offer a SHA hash depending on the key size for
RSA public keys.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: sign_params_to_flags: use strtok to parse input

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

certtool: copy SPKI information from private key when available

That also addresses a bug due to which SPKI information was not set.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

x509/output: Subject Public Key parameters are printed just before actual key

That allows to easier figure out algorithm and basic parameters, rather
than having them at the end of long key output.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_crt_set_spki: be more verbose in parameter restrictions

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>