[#4282] fixed TSAN warning

[#4282] removed comment

[#4282] minor changes to comments

[#4282] Added doxygen comment

[#4282] Fixed TSAN reported issue

[#4282] Spelling

[#4282] Unified can't messages

[#4282] Addressed more comments

[#4282] More improvements

[#4282] Addressed first comments

[#4282] Added a ChangeLog entry

[#4282] Added back/front to add

[#4282] Added logs error responses

[#4282] Fixed messages

[#4282] Added 4xx error causes

[#4282] Checkpoint: RFC 5997 UTs

[#4282] Checkpoint: more UTs

[#4282] Checkpoint: doc and UTs

[#4282] Checkpoint: added idle timer

[#4282] Added Radius*Status classes

[#4282] Updated exhonerated list (2)

[#4282] Updated exhonerated list

[#4282] Checkpoint: add Status-Server

[#4288] Cut cycles in UTs

[#4147] Addressed comments

[#4147] Added a ChangeLog entry

[#4147] Added core dump doc

[#4232] clean up code

[#4232] Made fd event handler choice explicit

[#4232] Ported the poll.h include fix

[#4232] Missing poll UTs

[#4232] Finished poll UTs

[#4232] Checkpoint: added wrapper and updated compatible UTs

[#4258] Removed obsolete UT

[#4258] Changed ctor

[#4258] Removed chrono include

[#4258] Used an iterator argument

[#4258] Avoid copies

[#4258] Regen message files

[#4258] Added unbalanced logs

[#4258] Added multi-index

[#4265] Fixed bug and updated UTs

[#4295] Moved ChangeLog to unreleased

[#4295] added ChangeLog entry

[#4295] Added UTs

[#4295] Applied the patch

[#4288] Removed dangling comment

[#4288] Removed variants

[#4288] Checkpoint before removing variants

[#4288] Spelling

[#4288] More doxygen comments

[#4288] Began to address comments

[#4288] Made 1 litterals unsigned

[#4288] Updated redact code

[#4288] Revamped data.* code

[#4288] Made recursion limited

[#4264] Moved to system_timer

[#4266] Replaced BOOST_STATIC_ASSERT

[#4283] Addressed last comment

[#4283] Addressed some minor comments

[#4283] Added large UTs and reorg

[#4283] Checkpoint: added MT UTs

[#4283] Checkpoint: began UTs

[#4283] Checkpoint: to do UTs

[#4176] Address compiler warnings

modified:   src/hooks/dhcp/lease_cmds/lease_cmds.cc
modified:   src/lib/dhcpsrv/lease.cc
modified:   src/lib/dhcpsrv/lease_mgr.cc

[#4176] Fix change log indent.

modified:   4176-ha-lease-syncing-doesn-t-always-update-lease-stats

[#4176] Added ChangeLog entry

new file:   4176-ha-lease-syncing-doesn-t-always-update-lease-stats

[#4176] Further comments

modified:   src/lib/dhcpsrv/lease_mgr.cc
    LeaseMgr::updateStatsOnUpdate(const Lease4Ptr...)
        Do nothing if either lease state is REGISTERED

modified:   src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.cc
    Verify REGISTERED ignored for v4

[#4176] Addressed further comments

modified:   src/hooks/dhcp/lease_cmds/lease_cmds.cc
    now addOrUpdate4 prohibits registered state
modified:   src/hooks/dhcp/lease_cmds/libloadtests/lease_cmds4_unittest.cc
    added UT

modified:   src/lib/dhcpsrv/lease_mgr.*
    renamed bumpStatPrefixPool() to bumpStatPrefix()

modified:   src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.cc
    added missing scenarios

[#4176] Initial review comments

modified:   src/hooks/dhcp/lease_cmds/lease_cmds.cc
modified:   src/hooks/dhcp/lease_cmds/libloadtests/lease_cmds6_unittest.cc
modified:   src/lib/dhcpsrv/lease_mgr.cc
modified:   src/lib/dhcpsrv/lease_mgr.h

[#4176] Add mysql and pgsql tests

modified:   src/hooks/dhcp/mysql/tests/mysql_lease_mgr_unittest.cc
modified:   src/hooks/dhcp/pgsql/tests/pgsql_lease_mgr_unittest.cc
modified:   src/lib/dhcpsrv/lease_mgr.cc

[#4176] Clean up

Clean up, round 1.

src/lib/dhcpsrv/lease_mgr.cc

[#4176] Use common update stats funcs

Initial working commit, needs cleanup

/src/hooks/dhcp/high_availability/ha_service.cc
    Added calls to new LeaseMgr update stat functions

/src/hooks/dhcp/high_availability/tests/ha_service_unittest.cc
    TEST_F(HAServiceTest, asyncSyncLeases4)
    TEST_F(HAServiceTest, asyncSyncLeases6) = updated to check stats

/src/hooks/dhcp/lease_cmds/lease_cmds.*
    Moved updateStats* to LeaseMgr

/src/hooks/dhcp/lease_cmds/libloadtests/lease_cmds6_unittest.cc
    Added line number logging to make diagnosis easier

/src/lib/dhcpsrv/lease.*
    changed Lease::STATE_* to constexpr

/src/lib/dhcpsrv/lease_mgr.*
    Added updateStatOn* functions taken from lease_cmds.
    Replaced updateStatsOnUpdate() implementations
    added constants helper functions

/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    TEST_F(MemfileLeaseMgrTest, updateStatsOn4SameSubnet)
    TEST_F(MemfileLeaseMgrTest, updateStatsOn4DifferentSubnet)
    TEST_F(MemfileLeaseMgrTest, updateStatsOn6SameSubnet)
    TEST_F(MemfileLeaseMgrTest, updateStatsOn6SameSubnetPD)
    TEST_F(MemfileLeaseMgrTest, updateStatsOn6DifferentSubnet)
    TEST_F(MemfileLeaseMgrTest, updateStatsOn6DifferentSubnetPD) - new tests

/src/lib/dhcpsrv/testutils/generic_lease_mgr_unittest.*
    GenericLeaseMgrTest::testUpdateStatsOn4SameSubnet()
    GenericLeaseMgrTest::testUpdateStatsOn4DifferentSubnet()
    GenericLeaseMgrTest::testUpdateStatsOn6SameSubnet()
    GenericLeaseMgrTest::testUpdateStatsOn6SameSubnetPD()
    GenericLeaseMgrTest::testUpdateStatsOn6DifferentSubnet()
    GenericLeaseMgrTest::testUpdateStatsOn6DifferentSubnetPD() - new tests

[#4263] Updated meson in hammer too

[#4263] Moved to meson 1.10.0

[#4186] Typo

[#4186] Applied plan to lease query stats

[#4232] Removed more test files in host cache

[#4232] fix host_cache uts for root

[#4232] Addressed comments

[#4232] Fixed UTs using chmod

[#4187] Addressed comments

[#4187] Added duplicate drop stats

[#4184] Applied Changelog rewording proposal

[#4184] Added a ChangeLog entry

[#4184] Updated last UTs

[#4184] Checkpoint: fixed UTs

[#4184] Checkpoint: UTs to update

[#4249] Additional comment

modified:   src/lib/dhcpsrv/memfile_lease_mgr.cc
    fixed catch expressions

[#4249] Addressed review comments

modified:   src/lib/dhcpsrv/memfile_lease_mgr.cc
   -  minor nits

[#4249] Make leasesX-write more resilient

/src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::writeLeases4Internal()
    Memfile_LeaseMgr::writeLeases6Internal() - rewritten to clean up
    on failure

/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    Updated UTs

[#4259] Fixed typo

[#4259] Replaced some throws by logs

[#4220] Fixed catch statements

modified:   src/lib/dhcpsrv/memfile_lease_mgr.cc

[#4220] Create error msg before clear()

modified:   src/lib/util/csv_file.cc

[#4220] Addressed review comments

 Changes to be committed:
new file:   changelog_unreleased/4220-req-option-for-memfile-to-abort-daemon-on-error
    modified:   src/lib/dhcpsrv/memfile_lease_mgr.cc
    modified:   src/lib/util/csv_file.cc

[#4220] Apply 1 suggestion(s) to 1 file(s)

Co-authored-by: Ben Scott <bscott@isc.org>

[#4220] Added basic UT

/src/lib/dhcpsrv/memfile_lease_mgr.h
    util::ReconnectCtlPtr reconnectCtl() - getter for testing only

/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    TEST_F(MemfileLeaseMgrTest, constructorReconnectParams) - new test

src/lib/util/reconnect_ctl.h
    ReconnectCtl::OnFailAction onFailAction() - new getter

[#4220] Add support on-fail to memfile

/doc/sphinx/arm/database-connectivity.rst
    Added note

/src/lib/dhcpsrv/memfile_lease_mgr.*
    Memfile_LeaseMgr::Memfile_LeaseMgr() - create the connection
    reconnect object, check for invalid retry values.

    Memfile_LeaseMgr::handleDbLost() - new function for invoking
    the db lost callback.

    Added calls to handleDbLost() on CSVFileFatalError(s)

/src/lib/util/csv_file.*
    CSVFile::append() - throw CSVFileFatalError if stream is bad,
    include error specifics

[#4061] Completed CID 1662681