]>
git.ipfire.org Git - thirdparty/kea.git/log
JINMEI Tatuya [Fri, 17 May 2013 23:23:47 +0000 (16:23 -0700)]
[master] make sure 0-clear test buffer to suppress valgrind warnings
confirmed locally, and should be trivial, so I'm committing it directly.
Paul Selkirk [Fri, 17 May 2013 23:23:47 +0000 (19:23 -0400)]
[2522] rewrite TSIG string constructor documentation
Paul Selkirk [Fri, 17 May 2013 22:41:32 +0000 (18:41 -0400)]
[2522] add some SSHFP negative-value unit tests
Paul Selkirk [Fri, 17 May 2013 22:30:01 +0000 (18:30 -0400)]
[2522] MINFO & RP review updates
JINMEI Tatuya [Fri, 17 May 2013 20:31:47 +0000 (13:31 -0700)]
[master] changelog for #2946
JINMEI Tatuya [Fri, 17 May 2013 20:28:25 +0000 (13:28 -0700)]
[master] Merge branch 'trac2946'
JINMEI Tatuya [Fri, 17 May 2013 20:26:19 +0000 (13:26 -0700)]
[2946] simplified the previous fix further: just use it without any prefix.
as stopIOService public any (non templated) derived class can use it.
this seems to be the simplest and portable way to build it.
JINMEI Tatuya [Fri, 17 May 2013 20:16:08 +0000 (13:16 -0700)]
[master] Merge branch 'trac2916'
Paul Selkirk [Fri, 17 May 2013 19:40:23 +0000 (15:40 -0400)]
[2522] TSIG review updates
JINMEI Tatuya [Fri, 17 May 2013 19:19:33 +0000 (12:19 -0700)]
[2937] corrected a minor typo
Paul Selkirk [Fri, 17 May 2013 18:05:22 +0000 (14:05 -0400)]
[2522] more and better SSHFP unit tests
JINMEI Tatuya [Fri, 17 May 2013 16:21:44 +0000 (09:21 -0700)]
[2934] updated docstring for make_blocking, clarifying file vs socket
JINMEI Tatuya [Fri, 17 May 2013 16:19:07 +0000 (09:19 -0700)]
[2934] corrected a typo
JINMEI Tatuya [Fri, 17 May 2013 16:18:15 +0000 (09:18 -0700)]
[2934] updated lettuce README regarding prerequisites programs to be installed.
JINMEI Tatuya [Fri, 17 May 2013 16:04:21 +0000 (09:04 -0700)]
[2934] explained the rationale of the imposed delay for a xfrout test.
Marcin Siodelski [Fri, 17 May 2013 12:36:45 +0000 (14:36 +0200)]
[2786] Use parent class functions to access and modify data in OptionCustom
Marcin Siodelski [Fri, 17 May 2013 11:45:32 +0000 (13:45 +0200)]
[2786] Changes as a result of the second review.
Thomas Markwalder [Fri, 17 May 2013 11:44:28 +0000 (07:44 -0400)]
[master] Updated incorrect file names which broke distcheck make target.
Michal 'vorner' Vaner [Fri, 17 May 2013 10:26:16 +0000 (12:26 +0200)]
Include forgotten header
Include the stdint.h for uint64_t. It compiled on most systems, but
failed on some before.
Michal 'vorner' Vaner [Fri, 17 May 2013 09:25:38 +0000 (11:25 +0200)]
[2937] Compensate for different errors from csv
Compensate for different error message from different versions of the
csv library. We don't really care that much about which exact text of
the error is printed as long as something is printed and makes sense. So
allow both versions know to be produced.
Michal 'vorner' Vaner [Fri, 17 May 2013 09:24:20 +0000 (11:24 +0200)]
[2937] Parse CSV in strict mode
Don't accept invalid inputs. It seems some versions of the csv library
rejected this before, but some didn't. Making sure all of them reject
now, to get more reliable operation and consistent behavior.
Michal 'vorner' Vaner [Fri, 17 May 2013 07:32:08 +0000 (09:32 +0200)]
Merge remote-tracking branch 'refs/remotes/origin/master'
JINMEI Tatuya [Fri, 17 May 2013 07:22:46 +0000 (00:22 -0700)]
[master] style fix: folded long lines
JINMEI Tatuya [Fri, 17 May 2013 06:55:23 +0000 (23:55 -0700)]
[2934] added a lettuce test for axfr, including the scenario of this ticket.
Michal 'vorner' Vaner [Fri, 17 May 2013 06:52:32 +0000 (08:52 +0200)]
Merge #2836
Make the zone loading work even on top of MemorySegmentMapped. In
particular, handle the MemorySegmentGrown exception, which may cause
relocation of data.
Paul Selkirk [Fri, 17 May 2013 05:26:31 +0000 (01:26 -0400)]
[2522] convert SSHFP to use Impl struct
JINMEI Tatuya [Thu, 16 May 2013 22:48:50 +0000 (15:48 -0700)]
[2934] (unrelated fix) make sure closing auth TCP socket after first AXFR.
this only happens for very first TCP connection that does not result in
an answer, so wouldn't be very problematic in practice. but it's still
awkward.
JINMEI Tatuya [Thu, 16 May 2013 21:01:30 +0000 (14:01 -0700)]
[2934] use blocking I/O for sending XFR responses.
Paul Selkirk [Thu, 16 May 2013 21:27:58 +0000 (17:27 -0400)]
[2522] add MasterLexer constructors for in::SSHFP, ch::A, hs::A.
Also removed OldRdataFactory/new_rdata_factory_users stuff, since all Rdata classes now use the new RdataFactory.
JINMEI Tatuya [Thu, 16 May 2013 20:44:02 +0000 (13:44 -0700)]
[master] removed accidentally committed code with the previous fix.
JINMEI Tatuya [Thu, 16 May 2013 17:30:34 +0000 (10:30 -0700)]
[master] (re)make sure to {un,}define USE_SHARED_MEMORY in config.h
this chunk was accidentally removed in
e448bbba3ecae68b261612954aa9777edc384be4
causing test faiulres.
JINMEI Tatuya [Thu, 16 May 2013 16:59:14 +0000 (09:59 -0700)]
[2836] style fix: folded a long line.
JINMEI Tatuya [Thu, 16 May 2013 16:41:31 +0000 (09:41 -0700)]
[2916] corrected type of exception thrown from asiolib
error_code wasn't an exception type; it should have been system_error.
JINMEI Tatuya [Thu, 16 May 2013 16:28:59 +0000 (09:28 -0700)]
[2836] Merge branch 'trac2836' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2836
ommit.
Thomas Markwalder [Thu, 16 May 2013 15:58:25 +0000 (11:58 -0400)]
[master] Added entry 614 for trac 2954.
Thomas Markwalder [Thu, 16 May 2013 15:53:06 +0000 (11:53 -0400)]
[master] Merge branch 'trac2954', this adds dhcp-ddns process to
the source tree.
Michal 'vorner' Vaner [Thu, 16 May 2013 14:21:31 +0000 (16:21 +0200)]
[2836] Call resetHeader at better times
Michal 'vorner' Vaner [Thu, 16 May 2013 14:18:24 +0000 (16:18 +0200)]
[2936] Handle rare relocation
Michal 'vorner' Vaner [Thu, 16 May 2013 14:15:36 +0000 (16:15 +0200)]
[2836] Remove deprecated hack
The create now throws on relocation, so the whole operation is tried
again. No need to worry about object being relocated.
Michal 'vorner' Vaner [Thu, 16 May 2013 14:14:06 +0000 (16:14 +0200)]
[2836] Clarify how to use the segment object holder
Michal 'vorner' Vaner [Thu, 16 May 2013 14:06:52 +0000 (16:06 +0200)]
[2836] Clarify some Grown exceptions
Thomas Markwalder [Thu, 16 May 2013 11:56:32 +0000 (07:56 -0400)]
[2954] Additional review comment cleanup.
Marcin Siodelski [Thu, 16 May 2013 08:28:19 +0000 (10:28 +0200)]
[2786] Always validate the contents of the buffer when provided.
Marcin Siodelski [Thu, 16 May 2013 07:53:40 +0000 (09:53 +0200)]
[2786] Minor: added option code to the exception string.
Marcin Siodelski [Thu, 16 May 2013 07:44:58 +0000 (09:44 +0200)]
[2876] Minor: added paranthesis in the return statement.
JINMEI Tatuya [Thu, 16 May 2013 05:41:27 +0000 (22:41 -0700)]
[2946] get access to base class's static method via 'this' pointer
as some compilers don't allow direct use of Base::method.
Paul Selkirk [Thu, 16 May 2013 03:39:14 +0000 (23:39 -0400)]
Merge branch 'trac2522' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2522
Conflicts:
src/lib/dns/gen-rdatacode.py.in
JINMEI Tatuya [Wed, 15 May 2013 00:30:03 +0000 (17:30 -0700)]
[2522] some simple suggested fixes:
- use the unnamed namespace for the entire content to hide as many things as
possible.
- define rdata_tsig inside the fixture class to avoid initialization fiasco.
(to make it possible, also make toWireCommonChecks a member function).
JINMEI Tatuya [Wed, 15 May 2013 00:27:09 +0000 (17:27 -0700)]
[2522] trivial style fix
JINMEI Tatuya [Wed, 15 May 2013 00:06:17 +0000 (17:06 -0700)]
[2522] minor style fixes
JINMEI Tatuya [Tue, 14 May 2013 23:36:12 +0000 (16:36 -0700)]
[2522] trivial style cleanup: folded long lines
Paul Selkirk [Wed, 8 May 2013 15:29:02 +0000 (11:29 -0400)]
[2522] fix a typo
Paul Selkirk [Wed, 8 May 2013 14:59:40 +0000 (10:59 -0400)]
[2522] initialize impl_ directly in TSIG lexer constructor
Paul Selkirk [Wed, 8 May 2013 04:35:22 +0000 (00:35 -0400)]
[2522] TSIG algorigthm can be a reference, maybe a bit more efficient
Paul Selkirk [Wed, 8 May 2013 03:58:42 +0000 (23:58 -0400)]
[2522] convert TSIG string constructor tests to checkFromText
Paul Selkirk [Wed, 8 May 2013 02:13:22 +0000 (22:13 -0400)]
[2522] more TSIG unit tests
Paul Selkirk [Tue, 7 May 2013 19:59:29 +0000 (15:59 -0400)]
[2522] add MasterLexer constructor for TSIG
Paul Selkirk [Tue, 7 May 2013 17:16:17 +0000 (13:16 -0400)]
[2522] fix RP unit test
Paul Selkirk [Tue, 7 May 2013 17:08:27 +0000 (13:08 -0400)]
[2522] more MINFO unit tests
Paul Selkirk [Mon, 6 May 2013 14:30:04 +0000 (10:30 -0400)]
[2522] add MasterLexer constructor for MINFO
Paul Selkirk [Mon, 6 May 2013 14:28:55 +0000 (10:28 -0400)]
[2522] normalize some RP documentation comments
Paul Selkirk [Sat, 4 May 2013 23:25:30 +0000 (19:25 -0400)]
[2522] add MasterLexer constructor for RP
JINMEI Tatuya [Thu, 16 May 2013 00:09:25 +0000 (17:09 -0700)]
[2946] pass shared_ptr, not a reference to deadline pointer.
I suspect the previous version could cause the same type of use-after-free
bug, although I couldn't come up with an effective test scenario.
JINMEI Tatuya [Thu, 16 May 2013 00:03:49 +0000 (17:03 -0700)]
[2946] documentation update
JINMEI Tatuya [Wed, 15 May 2013 23:57:07 +0000 (16:57 -0700)]
[2946] mix enable_shared_from_this in SyncUDPServer to prevent use-after-free.
to enforce this style of creation, introduce a static factory method and
hide the constructor as private.
JINMEI Tatuya [Wed, 15 May 2013 23:42:08 +0000 (16:42 -0700)]
[2946] added a test case to reproduce the use-after-free situation
JINMEI Tatuya [Wed, 15 May 2013 19:00:20 +0000 (12:00 -0700)]
[2946] use shared_ptr of DNSServer objects for tests
Marcin Siodelski [Wed, 15 May 2013 19:31:07 +0000 (21:31 +0200)]
[2786] Option factory function uses iterators to create OptionCustom.
JINMEI Tatuya [Wed, 15 May 2013 18:31:57 +0000 (11:31 -0700)]
[2916] corrected handling of aux socket wrt exception safety
JINMEI Tatuya [Wed, 15 May 2013 18:27:21 +0000 (11:27 -0700)]
[2916] clarified what would happen if write blocks, and then return from test.
it should be safe to continue as clarified in the comment, but it's probably
better to eliminate any possibility of hangup.
JINMEI Tatuya [Wed, 15 May 2013 18:22:18 +0000 (11:22 -0700)]
[2916] reset global IOService to NULL at end of test for safer operation
JINMEI Tatuya [Wed, 15 May 2013 18:16:33 +0000 (11:16 -0700)]
[2916] clear alarm in the test's destructor.
JINMEI Tatuya [Wed, 15 May 2013 17:44:45 +0000 (10:44 -0700)]
[2836] style fixes: unify short lines
JINMEI Tatuya [Wed, 15 May 2013 17:30:03 +0000 (10:30 -0700)]
[2836] style fix: unify two short lines
JINMEI Tatuya [Wed, 15 May 2013 16:57:29 +0000 (09:57 -0700)]
[2836] corrected minor typo in doxygen doc
Thomas Markwalder [Wed, 15 May 2013 16:45:38 +0000 (12:45 -0400)]
[2954] Removed inadvertant addition of executable, d2srv_unittests.
Thomas Markwalder [Wed, 15 May 2013 16:41:42 +0000 (12:41 -0400)]
[2594] Moved d2Srv to d2, removed "Srv" and "srv" from file names
and source. Corrected other review items.
JINMEI Tatuya [Wed, 15 May 2013 16:40:07 +0000 (09:40 -0700)]
[2836] make tests safer when USE_SHARED_MEMORY is undefined.
- explicitly include config.h in these tests
- move helper function only used with USE_SHARED_MEMORY inside the ifdef block
JINMEI Tatuya [Wed, 15 May 2013 15:59:28 +0000 (08:59 -0700)]
[master] Merge branch 'trac2899-2'
JINMEI Tatuya [Wed, 15 May 2013 15:53:49 +0000 (08:53 -0700)]
[master] Merge branch 'trac2823-regression'
Marcin Siodelski [Wed, 15 May 2013 12:07:48 +0000 (14:07 +0200)]
[2786] Address review comments.
Michal 'vorner' Vaner [Wed, 15 May 2013 11:25:03 +0000 (13:25 +0200)]
[2836] Conditional code compilation
Skip some code if no shared memory support is present.
Michal 'vorner' Vaner [Wed, 15 May 2013 11:17:22 +0000 (13:17 +0200)]
[2836] Update Id generation
Use bigger type, check it never overflows.
Michal 'vorner' Vaner [Wed, 15 May 2013 11:17:09 +0000 (13:17 +0200)]
[2836] Update the docs about trees
Michal 'vorner' Vaner [Wed, 15 May 2013 10:58:20 +0000 (12:58 +0200)]
[2836] More retries on segment growing
Michal 'vorner' Vaner [Wed, 15 May 2013 10:55:20 +0000 (12:55 +0200)]
[2836] Don't leak memory on exception
If we throw an exception from the constructor, destructor is not called.
Call the clean-up manually there, so we don't leak memory.
Mukund Sivaraman [Wed, 15 May 2013 09:25:58 +0000 (14:55 +0530)]
[2823-regression] Make a minor comment update
Mukund Sivaraman [Wed, 15 May 2013 09:24:30 +0000 (14:54 +0530)]
[2823-regression] Fix test name in a comment
Michal 'vorner' Vaner [Wed, 15 May 2013 09:04:17 +0000 (11:04 +0200)]
[2836] Set the segment holder separately
Only allocate the memory for segment holder in the constructor, set it
in separate method. The allocation might throw.
Michal 'vorner' Vaner [Wed, 15 May 2013 07:54:44 +0000 (09:54 +0200)]
Merge branch 'master' into work/grow
Conflicts:
src/lib/datasrc/memory/zone_writer.cc
src/lib/datasrc/tests/memory/Makefile.am
src/lib/datasrc/tests/memory/zone_data_updater_unittest.cc
src/lib/datasrc/tests/memory/zone_finder_unittest.cc
JINMEI Tatuya [Wed, 15 May 2013 00:30:03 +0000 (17:30 -0700)]
[2522] some simple suggested fixes:
- use the unnamed namespace for the entire content to hide as many things as
possible.
- define rdata_tsig inside the fixture class to avoid initialization fiasco.
(to make it possible, also make toWireCommonChecks a member function).
JINMEI Tatuya [Wed, 15 May 2013 00:27:09 +0000 (17:27 -0700)]
[2522] trivial style fix
JINMEI Tatuya [Wed, 15 May 2013 00:06:17 +0000 (17:06 -0700)]
[2522] minor style fixes
JINMEI Tatuya [Tue, 14 May 2013 23:36:12 +0000 (16:36 -0700)]
[2522] trivial style cleanup: folded long lines
JINMEI Tatuya [Tue, 14 May 2013 22:52:00 +0000 (15:52 -0700)]
[2916] a bit more documentation
JINMEI Tatuya [Tue, 14 May 2013 22:50:19 +0000 (15:50 -0700)]
[2916] more documentation
JINMEI Tatuya [Tue, 14 May 2013 22:40:20 +0000 (15:40 -0700)]
[2916] make readCompleted a free function; it doesn't need LocalSocket attr.
JINMEI Tatuya [Tue, 14 May 2013 22:14:49 +0000 (15:14 -0700)]
[2916] catch invalid FD
Jeremy C. Reed [Tue, 14 May 2013 22:08:28 +0000 (17:08 -0500)]
[trac2653] escape double-dash so isn't converted to ndash entity
because can't copy and paste as it was
JINMEI Tatuya [Tue, 14 May 2013 21:05:21 +0000 (14:05 -0700)]
[2916] some more documentation