]>
git.ipfire.org Git - thirdparty/kea.git/log
JINMEI Tatuya [Thu, 2 May 2013 22:42:36 +0000 (15:42 -0700)]
[2850] removed unused functions
Thomas Markwalder [Thu, 2 May 2013 19:37:28 +0000 (15:37 -0400)]
[trac2355] - Added basic parsers unit tests in new file,
dhcp_parsers_unittest.cc. Added Element type checks to
Boolean and String parsers, corrected some commentary.
Paul Selkirk [Thu, 2 May 2013 19:05:06 +0000 (15:05 -0400)]
[2521] divide Rdata_RRSIG_Test.badText into many smaller tests
Paul Selkirk [Thu, 2 May 2013 18:34:50 +0000 (14:34 -0400)]
[2521] style cleanup: remove trailing whitespace
Paul Selkirk [Thu, 2 May 2013 18:20:45 +0000 (14:20 -0400)]
[2521] further DHCID review updates
- fixed multi-line digest aggregator
- remove min-length check, and allow empty string
- removed unit tests for short strings
- added unit tests for empty string and unterminated multi-line base64
Paul Selkirk [Thu, 2 May 2013 16:45:24 +0000 (12:45 -0400)]
[2521] further RRSIG review updates
- fixed multi-line signature aggregator
- allow empty signature
- fixed some unit tests
- added unit test for unterminated multi-line base64
JINMEI Tatuya [Thu, 2 May 2013 16:19:44 +0000 (09:19 -0700)]
[master] create a real instance of IOMessage and pass it to lookup DNS callback
some compilers complained about it if we pass a temporary, as they try to
copy it (IOMessage is nonopyable)
this should fix some error reports from buildbots
JINMEI Tatuya [Thu, 2 May 2013 15:58:04 +0000 (08:58 -0700)]
[master] Merge branch 'trac2906'
JINMEI Tatuya [Thu, 2 May 2013 15:55:24 +0000 (08:55 -0700)]
[master] changelog for #2903
JINMEI Tatuya [Thu, 2 May 2013 15:51:51 +0000 (08:51 -0700)]
[master] Merge branch 'trac2903'
Michal 'vorner' Vaner [Thu, 2 May 2013 14:37:12 +0000 (16:37 +0200)]
[2836] Make zone_data_ a pointer
Make it a pointer instead of reference. We'll need to change it from
time to time when the segment grows.
Mukund Sivaraman [Thu, 2 May 2013 14:14:21 +0000 (19:44 +0530)]
[2850] Move reset() method to the base ZoneTableSegment class
Also update ZoneTableSegmentMapped testcases to test the created segment
as a base ZoneTableSegment.
Michal 'vorner' Vaner [Thu, 2 May 2013 14:04:13 +0000 (16:04 +0200)]
[2836] Test growth of the mapped segment
Fill the memory image with a lot of records, so the segment must grow.
Currently fails, because the growth is not handled.
Mukund Sivaraman [Thu, 2 May 2013 14:00:50 +0000 (19:30 +0530)]
[2850] Update comment about not verifying checksum for a read-only segment
Mukund Sivaraman [Thu, 2 May 2013 13:56:27 +0000 (19:26 +0530)]
[2850] Make isWritable() not throw
Mukund Sivaraman [Thu, 2 May 2013 13:47:56 +0000 (19:17 +0530)]
[2850] Update isWritable() API doc
Michal 'vorner' Vaner [Thu, 2 May 2013 13:22:43 +0000 (15:22 +0200)]
[2836] Use other segments in the tests as well
Use other memory segments than just the test one.
Mukund Sivaraman [Thu, 2 May 2013 08:58:02 +0000 (14:28 +0530)]
[2850] Remove empty ZoneTableSegment destructor
Mukund Sivaraman [Thu, 2 May 2013 08:39:55 +0000 (14:09 +0530)]
[2850] Pass ZoneTableSegment by reference to the ZoneWriter constructor
Mukund Sivaraman [Thu, 2 May 2013 08:22:10 +0000 (13:52 +0530)]
[2850] Change exception type thrown, and document it
Mukund Sivaraman [Thu, 2 May 2013 07:55:00 +0000 (13:25 +0530)]
[2850] Remove getZoneWriter() method
Michal 'vorner' Vaner [Thu, 2 May 2013 07:47:27 +0000 (09:47 +0200)]
[2836] Make the updater tests parametrized
Make the ZoneDataUpdater tests parametrized based on the memory segment
used under the hood. Currently, only the MemorySegmentTest is used, as
before, which makes the test behave exactly the same as before. But
this'll allow us to add more segments to test on, especially the shared
memory segment.
Mukund Sivaraman [Thu, 2 May 2013 06:45:32 +0000 (12:15 +0530)]
[2850] Make getNamedAddress() return a std::pair
Michal 'vorner' Vaner [Thu, 2 May 2013 07:05:11 +0000 (09:05 +0200)]
[2836] Move the actual addition to separate method
Move the actual addition of the data to the memory image to separate
private method. All the allocations from the memory segment should
happen inside this method. Also, the method is mostly exception safe (it
can add some branches in the tree, but they don't bother us and we'll
reuse them).
This'll allow us to retry the addition on the SegmentGrown exception.
Michal 'vorner' Vaner [Thu, 2 May 2013 07:04:06 +0000 (09:04 +0200)]
[2836] Cleanup: use references
Considering the const in front of the parameters, this was the original
intention anyway.
JINMEI Tatuya [Thu, 2 May 2013 05:55:04 +0000 (22:55 -0700)]
[2850] some editorial/style cleanups:
- include style ("" vs <>) per consensus
- null pointer comparison style
- documentation wording fix
Mukund Sivaraman [Thu, 2 May 2013 02:59:43 +0000 (08:29 +0530)]
[1909] EXTRA_DIST the m4 files
... in case someone wants to autoreconf from a tarball.
Mukund Sivaraman [Thu, 2 May 2013 02:57:55 +0000 (08:27 +0530)]
[1909] Remove redundant AC_SUBSTs
JINMEI Tatuya [Thu, 2 May 2013 00:39:16 +0000 (17:39 -0700)]
[2850] constify
JINMEI Tatuya [Wed, 1 May 2013 21:27:05 +0000 (14:27 -0700)]
[2850] simplification: instantiate ZoneWriter directly.
JINMEI Tatuya [Wed, 1 May 2013 21:01:30 +0000 (14:01 -0700)]
[2850] constify
JINMEI Tatuya [Wed, 1 May 2013 18:21:48 +0000 (11:21 -0700)]
[2850] a minor wording fix in doc: use "a zone" instead of "zones" for writer.
as a zone writer can only update a single zone.
JINMEI Tatuya [Wed, 1 May 2013 18:19:45 +0000 (11:19 -0700)]
[2850] use 'update' instead of 'reload' for getZoneWriter doc.
as it's not only used for reloading (or not even for "loading").
JINMEI Tatuya [Wed, 1 May 2013 17:18:42 +0000 (10:18 -0700)]
[2906] removed the 'begin' iterator used within cache zonetable iterator.
we simply didn't need it.
JINMEI Tatuya [Wed, 1 May 2013 16:54:00 +0000 (09:54 -0700)]
[2906] corrected trivial wording errors and typos in documentation.
Mukund Sivaraman [Wed, 1 May 2013 12:26:20 +0000 (17:56 +0530)]
[2906] Update/add some assertions in tests
Mukund Sivaraman [Wed, 1 May 2013 12:25:59 +0000 (17:55 +0530)]
[2906] Make some more minor comment updates
Mukund Sivaraman [Wed, 1 May 2013 12:09:05 +0000 (17:39 +0530)]
[2906] Fix a compile error
Don't make ZoneTableAccessorCache derive from boost::noncopyable,
as ZoneTableAccessor derives from it already.
Mukund Sivaraman [Wed, 1 May 2013 11:58:30 +0000 (17:28 +0530)]
[2906] Make some minor comment updates
Thomas Markwalder [Wed, 1 May 2013 11:39:08 +0000 (07:39 -0400)]
[trac2355] Addressed interrim review comments, and completed remainder
of the common parser refactoring. Replaced individual global variables with
instance of new ParserContext class. Created new base classes PoolParser
and SubnetConfigParser.
Mukund Sivaraman [Wed, 1 May 2013 08:43:55 +0000 (14:13 +0530)]
[2850] Test that the dynamic_cast passes every time
Mukund Sivaraman [Wed, 1 May 2013 08:41:25 +0000 (14:11 +0530)]
[2850] Test resetting a ZoneTableSegmentMapped in READ_WRITE mode when the file exists
Mukund Sivaraman [Wed, 1 May 2013 08:12:10 +0000 (13:42 +0530)]
[2850] Add API documentation
Mukund Sivaraman [Wed, 1 May 2013 05:04:14 +0000 (10:34 +0530)]
[2850] Define and implement ZoneTableSegmentMapped
Mukund Sivaraman [Wed, 1 May 2013 05:03:41 +0000 (10:33 +0530)]
[2850] Add ZoneTableSegment::isWritable() method
Mukund Sivaraman [Wed, 1 May 2013 04:38:35 +0000 (10:08 +0530)]
[1909] Move sqlite3 check to m4macros/ dir
JINMEI Tatuya [Wed, 1 May 2013 03:37:47 +0000 (20:37 -0700)]
[2906] a bit more comment about test setup
JINMEI Tatuya [Wed, 1 May 2013 03:34:13 +0000 (20:34 -0700)]
[2906] some more comments about ZoneSpec::index.
JINMEI Tatuya [Wed, 1 May 2013 03:17:48 +0000 (20:17 -0700)]
[2906] added zone table accessor implementations
JINMEI Tatuya [Tue, 30 Apr 2013 22:10:08 +0000 (15:10 -0700)]
[2903] corrected a minor typo in doxygen doc
JINMEI Tatuya [Tue, 30 Apr 2013 18:21:16 +0000 (11:21 -0700)]
[2903] largely updated close() related log messages
providing more detailed explanations in some cases, revisiting message ID
to be more concise and appropriate. reconsider one log level.
Marcin Siodelski [Tue, 30 Apr 2013 17:38:18 +0000 (19:38 +0200)]
[2902] Corrected some doxygen errors.
JINMEI Tatuya [Tue, 30 Apr 2013 17:05:26 +0000 (10:05 -0700)]
[2903] explicitly initialize a couple of member variables of SyncUDPServer.
it shouldn't have caused a real trouble because of how they are used,
but style-wise it's cleaner, and it suppresses warning from static analyzers.
Marcin Siodelski [Tue, 30 Apr 2013 16:32:58 +0000 (18:32 +0200)]
[2902] Include in_systm.h when ip.h is included.
If in_systm.h is not included before ip.h it will cause compilation error
on NetBSD and OpenBSD. Compiler will complain that n_time is undefined
but used in ip.h.
Marcin Siodelski [Tue, 30 Apr 2013 15:49:56 +0000 (17:49 +0200)]
[2902] Cleanup in comments.
Michal 'vorner' Vaner [Tue, 30 Apr 2013 15:06:59 +0000 (17:06 +0200)]
[2836] Minor docs fixes
Stephen Morris [Tue, 30 Apr 2013 12:57:22 +0000 (13:57 +0100)]
[2467] Miscellaneous minor changes as a result of review
Marcin Siodelski [Tue, 30 Apr 2013 10:41:17 +0000 (12:41 +0200)]
[2902] Source HW address is an interface MAC address.
Marcin Siodelski [Tue, 30 Apr 2013 10:07:23 +0000 (12:07 +0200)]
[2902] Use default HW address if not specified.
Marcin Siodelski [Tue, 30 Apr 2013 09:12:22 +0000 (11:12 +0200)]
[2902] Pass packet object to the function creating ethernet header.
Mukund Sivaraman [Tue, 30 Apr 2013 08:11:14 +0000 (13:41 +0530)]
[1909] Check for presence of sqlite3 program before using it
JINMEI Tatuya [Tue, 30 Apr 2013 07:11:56 +0000 (00:11 -0700)]
[2823] renamed b10-XXX_test to XXX_test, for consistency with other test files
JINMEI Tatuya [Tue, 30 Apr 2013 07:10:08 +0000 (00:10 -0700)]
[2823] renamed "SimpleXXX" classes to "MyXXX", as they are not really simple.
JINMEI Tatuya [Tue, 30 Apr 2013 07:07:11 +0000 (00:07 -0700)]
[2823] removed thread-related beasts from utils.py. they are now unused.
Michal 'vorner' Vaner [Tue, 30 Apr 2013 07:06:46 +0000 (09:06 +0200)]
Merge #2871
Fake work for resolution models testing.
(The correct version of branch now)
Michal 'vorner' Vaner [Tue, 30 Apr 2013 07:05:34 +0000 (09:05 +0200)]
Revert "Merge #2871"
This reverts commit
33e10c84c8b6ab274c157816ba81e6d2fc8ba628 , reversing
changes made to
3a382331f1308099930d6b653dd6d11b70da8e22 .
Revert the merge of wrong version of branch.
Michal 'vorner' Vaner [Tue, 30 Apr 2013 06:56:22 +0000 (08:56 +0200)]
Merge #2871
Fake work for resolution models testing.
JINMEI Tatuya [Tue, 30 Apr 2013 06:47:34 +0000 (23:47 -0700)]
[master] update AC_MSG_ERROR about shared memory support with disabling switch.
JINMEI Tatuya [Tue, 30 Apr 2013 06:40:22 +0000 (23:40 -0700)]
[2823] re-enable w/o from_source test, adjusted test_init_hterr accordingly.
see the added comments about the issue.
Naoki Kambe [Tue, 30 Apr 2013 06:30:46 +0000 (15:30 +0900)]
[2252] add exceptional cases for checking initial statistics of Xfrout
.Xfrout.socket.unixdomain.open should be 1 immediately after Xfrout started.
But Stats could not have the latest statistics of Xfrout if it requests until
Xfrout is ready for accepting a statistics request from Stats. Thus in that
case, Stats would show that .Xfrout.socket.unixdomain.open is 1. For checking
exactly that .Xfrout.socket.unixdomain.open is 1 here, it waits for the second
time until Stats requests all modules which are Auth, Init, and Xfrout. The
Stats configuration "poll-interval" is changed to one second so that timeout in
the lettuce test is avoided.
JINMEI Tatuya [Tue, 30 Apr 2013 06:23:32 +0000 (23:23 -0700)]
[2823] updated command/config tests for stats httpd using new mock class.
JINMEI Tatuya [Tue, 30 Apr 2013 06:20:02 +0000 (23:20 -0700)]
[2823] updated open_template test for stats httpd with new mock class
JINMEI Tatuya [Tue, 30 Apr 2013 06:00:36 +0000 (23:00 -0700)]
[2823] updated nofailure_with_errno_EINTR stats httpd test with new mock.
also prevented open sockets leaving open at the of tests (for supressing
warnings)
Mukund Sivaraman [Tue, 30 Apr 2013 05:48:57 +0000 (11:18 +0530)]
[2850] Make getZoneWriter() non-virtual
This also makes ZoneWriter a concrete class (and removes
ZoneWriterLocal).
JINMEI Tatuya [Tue, 30 Apr 2013 05:11:00 +0000 (22:11 -0700)]
[2823] updated select_error test for stats httpd using new mock class
JINMEI Tatuya [Tue, 30 Apr 2013 05:02:08 +0000 (22:02 -0700)]
[master] Merge branch 'trac2831'
Mukund Sivaraman [Tue, 30 Apr 2013 04:59:53 +0000 (10:29 +0530)]
Merge remote-tracking branch 'origin/trac2831' into trac2850_2
JINMEI Tatuya [Tue, 30 Apr 2013 04:18:20 +0000 (21:18 -0700)]
[2823] updated running test for stats httpd using the new mock class.
this case is a bit tricky. we need to fake select.select() and delegate
test sub test cases (about command handling) to specific test cases;
other than that the sense of the test should be preserved.
for clarity the failure case was extracted into a separate test method.
JINMEI Tatuya [Tue, 30 Apr 2013 03:42:58 +0000 (20:42 -0700)]
[2823] updated httpd_xxx tests for stats httpd using new mock class.
Naoki Kambe [Tue, 30 Apr 2013 01:49:39 +0000 (10:49 +0900)]
[2252] update description of xfrsuccess to the same one as the man doc
JINMEI Tatuya [Tue, 30 Apr 2013 00:51:08 +0000 (17:51 -0700)]
[2823] updtaed stats-httpd mccs test using new mock class
JINMEI Tatuya [Tue, 30 Apr 2013 00:48:51 +0000 (17:48 -0700)]
[2823] updated openclose_mccs test for stats httpd using the new mock class
JINMEI Tatuya [Tue, 30 Apr 2013 00:40:15 +0000 (17:40 -0700)]
[2823] updated init_hterr test for stats httpd using the new mock class
JINMEI Tatuya [Tue, 30 Apr 2013 00:32:54 +0000 (17:32 -0700)]
[2823] updated TestStatsHttpd init test without using threads.
some asserts were simplified at an (I hope) acceptable level. In particular,
I didn't think we need to check the response from CfgMgr: it should be more
than enough if the module name is the expected one.
JINMEI Tatuya [Tue, 30 Apr 2013 00:06:16 +0000 (17:06 -0700)]
[2823] updated TestHttpHandler using new mock httpd class.
it now doesn't depend on the clumsy thread stuff (except for http server
and client).
JINMEI Tatuya [Tue, 30 Apr 2013 00:03:03 +0000 (17:03 -0700)]
[2823] introduced "SimpleStatsHttpd" mock class.
JINMEI Tatuya [Mon, 29 Apr 2013 23:28:43 +0000 (16:28 -0700)]
[2903] updated coment about SyncUDPServer::answer_.
JINMEI Tatuya [Mon, 29 Apr 2013 23:00:57 +0000 (16:00 -0700)]
[2903] logged other errors from asio.
JINMEI Tatuya [Mon, 29 Apr 2013 21:39:32 +0000 (14:39 -0700)]
[2903] clarified one case after YIELD where the error shouldn't happen.
use assert() rather than ignoring it; we should be able to assert it safely
in this case.
JINMEI Tatuya [Mon, 29 Apr 2013 21:05:44 +0000 (14:05 -0700)]
[2903] added more detailed explanation of when post() can throw
Marcin Siodelski [Mon, 29 Apr 2013 17:42:58 +0000 (19:42 +0200)]
[2902] Do not swap local and remote HW address when sending response.
JINMEI Tatuya [Mon, 29 Apr 2013 17:22:43 +0000 (10:22 -0700)]
[2521] style cleanup: removed a space after EOL
Marcin Siodelski [Mon, 29 Apr 2013 17:05:22 +0000 (19:05 +0200)]
[2902] Set valid destination HW address when replying to the DHCP4 client.
Marcin Siodelski [Mon, 29 Apr 2013 15:26:49 +0000 (17:26 +0200)]
[2902] Added data fields storing src/dest HW Address in Pkt4 class.
Marcin Siodelski [Mon, 29 Apr 2013 11:16:45 +0000 (13:16 +0200)]
[2902] Corrected error in the namespace name.
Marcin Siodelski [Mon, 29 Apr 2013 11:15:11 +0000 (13:15 +0200)]
[2902] LPF: receive DHCP traffic only.
Marcin Siodelski [Mon, 29 Apr 2013 09:00:22 +0000 (11:00 +0200)]
[2902] Direct traffic is optional in the Dhcp4Srv to allow unit testing.
Mukund Sivaraman [Mon, 29 Apr 2013 07:41:37 +0000 (13:11 +0530)]
[2831] Make a minor comment update about additional case
JINMEI Tatuya [Sat, 27 Apr 2013 03:22:58 +0000 (20:22 -0700)]
[2823] completely get rid of threads from stats tests.
test_command_show and test_polling cases were a bit tricky.
they are now separated into several independent sub tests, and in each case
we use faked data that would be provided as if they came from other modules.
JINMEI Tatuya [Fri, 26 Apr 2013 21:39:13 +0000 (14:39 -0700)]
[2903] make some more repeatedly-used variables class members.
this will be slightly more efficient as we can avoid construction overhead
per call. also use asio::mutable_buffers_1() instead of asio::buffer();
the latter is a wrapper for the former, so the direct call should be
(in theory) more efficient.