]> git.ipfire.org Git - thirdparty/kea.git/log
thirdparty/kea.git
13 years ago[2364] Minor changes to exception text after review.
Stephen Morris [Mon, 26 Nov 2012 12:43:39 +0000 (12:43 +0000)] 
[2364] Minor changes to exception text after review.

13 years ago[2374] Comments for end of unnamed namespaces
Jelte Jansen [Mon, 26 Nov 2012 10:57:08 +0000 (11:57 +0100)] 
[2374] Comments for end of unnamed namespaces

13 years ago[2374] Use correct type for base of strtoul()
Jelte Jansen [Mon, 26 Nov 2012 10:48:48 +0000 (11:48 +0100)] 
[2374] Use correct type for base of strtoul()

13 years ago[2374] Add tests for escapes in numbers that are really strings
Jelte Jansen [Mon, 26 Nov 2012 10:43:46 +0000 (11:43 +0100)] 
[2374] Add tests for escapes in numbers that are really strings

13 years agoMerge #2375
Michal 'vorner' Vaner [Mon, 26 Nov 2012 10:32:59 +0000 (11:32 +0100)] 
Merge #2375

13 years ago[2374] Fix comments in number tokens
Jelte Jansen [Mon, 26 Nov 2012 10:30:06 +0000 (11:30 +0100)] 
[2374] Fix comments in number tokens

a number directly followed by ;comment was not parsed correctly

13 years agoMerge #2376
Michal 'vorner' Vaner [Mon, 26 Nov 2012 10:13:16 +0000 (11:13 +0100)] 
Merge #2376

Conflicts:
src/lib/datasrc/datasrc_messages.mes

13 years ago[1044] Revert perfdhcp disabled tests
Jelte Jansen [Mon, 26 Nov 2012 10:01:44 +0000 (11:01 +0100)] 
[1044] Revert perfdhcp disabled tests

This still needs to be done, but should probably go into a separate commit straight to master

13 years ago[2225_statistics] remove unused paths
Naoki Kambe [Mon, 26 Nov 2012 07:49:45 +0000 (16:49 +0900)] 
[2225_statistics] remove unused paths

13 years ago[2225_statistics] update counter class names in docstring
Naoki Kambe [Mon, 26 Nov 2012 05:12:09 +0000 (14:12 +0900)] 
[2225_statistics] update counter class names in docstring

13 years ago[2225_statistics] move init() into the Counter class
Naoki Kambe [Mon, 26 Nov 2012 04:35:11 +0000 (13:35 +0900)] 
[2225_statistics] move init() into the Counter class

13 years ago[2225_statistics] move constants which are used in test_rasing_incrementers()
Naoki Kambe [Thu, 22 Nov 2012 08:39:39 +0000 (17:39 +0900)] 
[2225_statistics] move constants which are used in test_rasing_incrementers()

13 years ago[2225_statistics] add tearDown()
Naoki Kambe [Thu, 22 Nov 2012 08:32:45 +0000 (17:32 +0900)] 
[2225_statistics] add tearDown()

clear statistics data when every test is finished

13 years ago[2225_statistics] reload counter module in each testcase
Naoki Kambe [Mon, 26 Nov 2012 08:03:16 +0000 (17:03 +0900)] 
[2225_statistics] reload counter module in each testcase

13 years ago[2225_statistics] add B10_FROM_SOURCE
Naoki Kambe [Mon, 26 Nov 2012 08:09:38 +0000 (17:09 +0900)] 
[2225_statistics] add B10_FROM_SOURCE

13 years ago[2225_statistics] rename class name and add TEST_SPECFILE_LOCATION
Naoki Kambe [Mon, 26 Nov 2012 08:09:16 +0000 (17:09 +0900)] 
[2225_statistics] rename class name and add TEST_SPECFILE_LOCATION

13 years ago[2225_statistics] add some test specfiles
Naoki Kambe [Mon, 26 Nov 2012 07:56:56 +0000 (16:56 +0900)] 
[2225_statistics] add some test specfiles

13 years ago[2375] a few trivial comment updates (fixing copy-paste errors)
JINMEI Tatuya [Mon, 26 Nov 2012 07:40:01 +0000 (16:40 +0900)] 
[2375] a few trivial comment updates (fixing copy-paste errors)

13 years ago[2376] corrected a trivial typo in doc
JINMEI Tatuya [Mon, 26 Nov 2012 06:57:47 +0000 (15:57 +0900)] 
[2376] corrected a trivial typo in doc

13 years ago[2375] cleanup: removed an unused function
JINMEI Tatuya [Mon, 26 Nov 2012 06:55:37 +0000 (15:55 +0900)] 
[2375] cleanup: removed an unused function

13 years ago[2225_statistics] merge TestXfroutCounter and TestXfrinCounter into BaseTestCounter
Naoki Kambe [Thu, 22 Nov 2012 08:14:21 +0000 (17:14 +0900)] 
[2225_statistics] merge TestXfroutCounter and TestXfrinCounter into BaseTestCounter

13 years ago[2225_statistics] open specfile in Counter class
Naoki Kambe [Thu, 22 Nov 2012 05:15:53 +0000 (14:15 +0900)] 
[2225_statistics] open specfile in Counter class

13 years ago[2225_statistics] add _parse_stats_spec() to get each list of names on statistics...
Naoki Kambe [Thu, 22 Nov 2012 04:34:18 +0000 (13:34 +0900)] 
[2225_statistics] add _parse_stats_spec() to get each list of names on statistics spec

13 years ago[2225_statistics] set methods in Counter
Naoki Kambe [Wed, 21 Nov 2012 02:48:16 +0000 (11:48 +0900)] 
[2225_statistics] set methods in Counter

13 years ago[2225_statistics] merge two concrete methods and parameters into _Counter()
Naoki Kambe [Wed, 21 Nov 2012 02:39:06 +0000 (11:39 +0900)] 
[2225_statistics] merge two concrete methods and parameters into _Counter()

13 years ago[2420] use "RRSIG(<covered>)" in logging for RRSIG-only RRsets
JINMEI Tatuya [Mon, 26 Nov 2012 05:29:20 +0000 (14:29 +0900)] 
[2420] use "RRSIG(<covered>)" in logging for RRSIG-only RRsets

13 years ago[2420] made a comment line less confusing (separate unrelated one and add new)
JINMEI Tatuya [Mon, 26 Nov 2012 05:16:37 +0000 (14:16 +0900)] 
[2420] made a comment line less confusing (separate unrelated one and add new)

13 years ago[2225_statistics] make Counter class hidden(rename Counter to _Counter), add Counter...
Naoki Kambe [Mon, 26 Nov 2012 04:59:57 +0000 (13:59 +0900)] 
[2225_statistics] make Counter class hidden(rename Counter to _Counter), add Counter class, and move empty methods in it.

13 years ago[2353] unrelated cleanup: removed an obsolete comment.
JINMEI Tatuya [Mon, 26 Nov 2012 04:42:31 +0000 (13:42 +0900)] 
[2353] unrelated cleanup: removed an obsolete comment.

13 years ago[2157] update doxygen, remove extra header includes
Yoshitaka Aharen [Mon, 26 Nov 2012 02:28:44 +0000 (11:28 +0900)] 
[2157] update doxygen, remove extra header includes

13 years ago[1745] Add pid to all log messages
Mukund Sivaraman [Sun, 25 Nov 2012 21:45:21 +0000 (03:15 +0530)] 
[1745] Add pid to all log messages

Also adjust affected tests accordingly.

13 years ago[2404] Tidying up and refactoring the code
Stephen Morris [Fri, 23 Nov 2012 18:23:21 +0000 (18:23 +0000)] 
[2404] Tidying up and refactoring the code

13 years ago[2398] update doc and comments
Jelte Jansen [Fri, 23 Nov 2012 15:03:07 +0000 (16:03 +0100)] 
[2398] update doc and comments

13 years ago[2398] Test and catch more socket errors
Jelte Jansen [Fri, 23 Nov 2012 14:38:36 +0000 (15:38 +0100)] 
[2398] Test and catch more socket errors

13 years ago[2404] Add ability to update an IPv4 lease
Stephen Morris [Fri, 23 Nov 2012 14:08:00 +0000 (14:08 +0000)] 
[2404] Add ability to update an IPv4 lease

13 years ago[2398] Introduce stop mechanism in msgqM
Jelte Jansen [Fri, 23 Nov 2012 13:58:39 +0000 (14:58 +0100)] 
[2398] Introduce stop mechanism in msgqM

Introduced a lowlevel mechanism into msgq to stop it (other than ye olde SIGTERM); a lowlevel message 'stop' will cause it to stop listening and shut down. Needed to add timeouts to poll() and control() for that, but chose them relatively high (their loop should simply reloop if they time out)

This allows the threaded msgq testing code to be more reliable (and not having to daemonize and arbitrarily kill threads except in the case of major failures, in which case the test itself will fail)

13 years ago[2404] Add method to get lease4 by client ID and subnet ID
Stephen Morris [Fri, 23 Nov 2012 13:48:42 +0000 (13:48 +0000)] 
[2404] Add method to get lease4 by client ID and subnet ID

13 years ago[2404] Add get lease4 by client ID
Stephen Morris [Fri, 23 Nov 2012 12:47:40 +0000 (12:47 +0000)] 
[2404] Add get lease4 by client ID

13 years ago[2404] Add method to get lease4 by hardware address & subnet ID
Stephen Morris [Fri, 23 Nov 2012 12:23:17 +0000 (12:23 +0000)] 
[2404] Add method to get lease4 by hardware address & subnet ID

13 years ago[2404] Now able to get IPv4 leases by hardware address
Stephen Morris [Fri, 23 Nov 2012 12:05:55 +0000 (12:05 +0000)] 
[2404] Now able to get IPv4 leases by hardware address

13 years ago[2490] Changes as a result of review.
Marcin Siodelski [Fri, 23 Nov 2012 09:06:15 +0000 (10:06 +0100)] 
[2490] Changes as a result of review.

13 years ago[2410] Changes as a result of review
Stephen Morris [Thu, 22 Nov 2012 19:22:25 +0000 (19:22 +0000)] 
[2410] Changes as a result of review

13 years ago[1044] Address review comments
Jelte Jansen [Thu, 22 Nov 2012 14:30:18 +0000 (15:30 +0100)] 
[1044] Address review comments

See http://bind10.isc.org/ticket/1044#comment:13

13 years ago[2375] Eliminate fake states
Michal 'vorner' Vaner [Thu, 22 Nov 2012 13:05:15 +0000 (14:05 +0100)] 
[2375] Eliminate fake states

13 years ago[2375] Cover the getNextToken with tests without fakes
Michal 'vorner' Vaner [Thu, 22 Nov 2012 12:59:21 +0000 (13:59 +0100)] 
[2375] Cover the getNextToken with tests without fakes

13 years ago[1486] Merge branch 'master' into trac1486
Stephen Morris [Thu, 22 Nov 2012 11:49:16 +0000 (11:49 +0000)] 
[1486] Merge branch 'master' into trac1486

13 years ago[2375] Simplify the state transition design pattern
Michal 'vorner' Vaner [Thu, 22 Nov 2012 10:53:29 +0000 (11:53 +0100)] 
[2375] Simplify the state transition design pattern

We never have a chain of the transitions. We only do start and zero or
one handle on the returned one. Simplify handle to return void, not
NULL.

Besides simplification, it allows testing without fake states (TBD) - we
had no real state to test the multiple transitions.

13 years ago[2375] fixed a typo in a comment
JINMEI Tatuya [Tue, 20 Nov 2012 07:47:54 +0000 (16:47 +0900)] 
[2375] fixed a typo in a comment

13 years ago[2375] some style matters: mostly about constness, and folded a long line.
JINMEI Tatuya [Thu, 15 Nov 2012 22:00:40 +0000 (14:00 -0800)] 
[2375] some style matters: mostly about constness, and folded a long line.

Conflicts (from cherry-pick):
src/lib/dns/tests/master_lexer_unittest.cc

13 years ago[2375] Return a reference to the token
Michal 'vorner' Vaner [Thu, 22 Nov 2012 10:34:48 +0000 (11:34 +0100)] 
[2375] Return a reference to the token

The copy is shallow anyway, so it wouldn't survive for long.

13 years ago[2375] Handle EOF after unbalanced parentheses
Michal 'vorner' Vaner [Thu, 22 Nov 2012 10:17:55 +0000 (11:17 +0100)] 
[2375] Handle EOF after unbalanced parentheses

If there's an error that manifests at the end of a file, like an
unbalanced parenthesis or a quoted string that does not end, report the
error. But also, return EOF as the next token, not an exception.

13 years ago[2375] Remove exception handling from getNextToken
Michal 'vorner' Vaner [Thu, 22 Nov 2012 10:07:03 +0000 (11:07 +0100)] 
[2375] Remove exception handling from getNextToken

It was deemed unneeded and is removed therefore, to make the code
smaller.

13 years ago[2300] added a test method test_ipsocket_counters() for testing the incrementers...
Naoki Kambe [Fri, 28 Sep 2012 07:04:00 +0000 (16:04 +0900)] 
[2300] added a test method test_ipsocket_counters() for testing the incrementers of the socket counters

13 years ago[2300] added a method _create_ipsocket_functors() for creating incrementers of the...
Naoki Kambe [Fri, 28 Sep 2012 07:02:38 +0000 (16:02 +0900)] 
[2300] added a method _create_ipsocket_functors() for creating incrementers of the socket counters

13 years ago[2274] updated the BaseTestXfrCounter class for testing new statistics items
Naoki Kambe [Wed, 19 Sep 2012 08:45:37 +0000 (17:45 +0900)] 
[2274] updated the BaseTestXfrCounter class for testing new statistics items

- moved up test_xfrrunning_counters() to the BaseTestXfrCounter class

- added a new variable holding a name list from target counter class

13 years ago[2274] updated the XfrinCounter class for adding new statistics items
Naoki Kambe [Wed, 19 Sep 2012 08:51:23 +0000 (17:51 +0900)] 
[2274] updated the XfrinCounter class for adding new statistics items

- moved up _create_xfrrunning_functors() to the Counter class for sharing

- added a name list for new statistics items

13 years ago[2252] corrected the wrong comment of the methods
Naoki Kambe [Fri, 28 Sep 2012 02:47:55 +0000 (11:47 +0900)] 
[2252] corrected the wrong comment of the methods

13 years ago[2225] removed duplicate assignment
Naoki Kambe [Fri, 28 Sep 2012 02:46:26 +0000 (11:46 +0900)] 
[2225] removed duplicate assignment

13 years ago[2252] corrected the order
Naoki Kambe [Fri, 28 Sep 2012 02:46:00 +0000 (11:46 +0900)] 
[2252] corrected the order

13 years ago[2252] added tests for the XfrinCounter class
Naoki Kambe [Wed, 12 Sep 2012 07:30:55 +0000 (16:30 +0900)] 
[2252] added tests for the XfrinCounter class

 - added a test class TestXfroutCounter for the XfrinCounter class
 - Common methods were moved out of the test class
 - added tests for the base class Counter
 - added a base class BaseTestXfrCounter for handling common tests
   between Xfrin and Xfrout

13 years ago[2252] added path of xfrin into PYTHONPATH and removed unnecessary TESTDATASRCDIR
Naoki Kambe [Wed, 12 Sep 2012 07:30:39 +0000 (16:30 +0900)] 
[2252] added path of xfrin into PYTHONPATH and removed unnecessary TESTDATASRCDIR

13 years ago[2252] added XfrinCounter class
Naoki Kambe [Wed, 12 Sep 2012 07:30:00 +0000 (16:30 +0900)] 
[2252] added XfrinCounter class

 - added XfrinCounter class
 - Common methods between Xfrout and Xfrin are gotten rid of out of
   each class, which is incrementer, decrementer, etc.
 - added an abstract class for concrete XfroutCounter and  XfrinCounter
   classes, in which common methods were defined
 - added per-zone counters into XfrinCounter
 - added per-zone timer handlers into XfrinCounter, which can start or
   stop a timer

13 years ago[2157] minor comment fix
Yoshitaka Aharen [Thu, 22 Nov 2012 06:50:22 +0000 (15:50 +0900)] 
[2157] minor comment fix

13 years ago[2157] use predefined variable for awk path
Yoshitaka Aharen [Thu, 22 Nov 2012 06:07:22 +0000 (15:07 +0900)] 
[2157] use predefined variable for awk path

13 years ago[2157] add ChangeLog
Yoshitaka Aharen [Thu, 22 Nov 2012 05:53:22 +0000 (14:53 +0900)] 
[2157] add ChangeLog

13 years ago[2157] update systest
Yoshitaka Aharen [Thu, 22 Nov 2012 05:46:21 +0000 (14:46 +0900)] 
[2157] update systest

13 years ago[2157] update lettuce feature
Yoshitaka Aharen [Thu, 22 Nov 2012 04:05:31 +0000 (13:05 +0900)] 
[2157] update lettuce feature

13 years ago[2374] Add Number lexer state
Jelte Jansen [Wed, 21 Nov 2012 20:34:03 +0000 (21:34 +0100)] 
[2374] Add Number lexer state

13 years ago[2404] Add getLease4(const IOAddress&, SubnetId)
Stephen Morris [Wed, 21 Nov 2012 19:38:26 +0000 (19:38 +0000)] 
[2404] Add getLease4(const IOAddress&, SubnetId)

Add ability to select IPv4 leases by address and Subnet ID.

13 years ago[2410] Fix race condition in DHCP4 test
Stephen Morris [Wed, 21 Nov 2012 18:18:28 +0000 (18:18 +0000)] 
[2410] Fix race condition in DHCP4 test

Same change as in commit 9f454868d6240a3113bed21cd719293ddb10991f
but applied to the DHCP4 test.

13 years ago[2410] Attempt to fix race condition in test
Stephen Morris [Wed, 21 Nov 2012 18:03:04 +0000 (18:03 +0000)] 
[2410] Attempt to fix race condition in test

Attempts to fix a process/subprocess race condition by having
the parent process loop waiting for output instead of assuming
that the subprocess has started and has written something by the
time it gets round to reading it.

Also closes a few unclosed file descriptors at the end of a test.

13 years ago[2490] Removed redundant parameters.
Marcin Siodelski [Wed, 21 Nov 2012 16:32:49 +0000 (17:32 +0100)] 
[2490] Removed redundant parameters.

13 years ago[2490] Improvements to option definition validation function.
Marcin Siodelski [Wed, 21 Nov 2012 15:58:57 +0000 (16:58 +0100)] 
[2490] Improvements to option definition validation function.

13 years ago[2398] Catch EPIPE in msgq
Jelte Jansen [Wed, 21 Nov 2012 15:13:51 +0000 (16:13 +0100)] 
[2398] Catch EPIPE in msgq

And kill the socket if this is caught. This is similar to the other case where __send_data is called.

13 years ago[2398] Add test setup for sending messages in msgq
Jelte Jansen [Tue, 20 Nov 2012 10:52:52 +0000 (11:52 +0100)] 
[2398] Add test setup for sending messages in msgq

Test setup raising arbitrary exceptions from the write socket.

We can extend this to do the same for reading I think.

Also added tests; some for things that worked already (EAGAIN, EWOULDBLOCK), but also for the SIGPIPE that is the problem in #2398

13 years ago[2490] Added descriptions for option definition tests.
Marcin Siodelski [Wed, 21 Nov 2012 14:56:02 +0000 (15:56 +0100)] 
[2490] Added descriptions for option definition tests.

13 years ago[2490] Added support for string data field within an option.
Marcin Siodelski [Wed, 21 Nov 2012 14:35:39 +0000 (15:35 +0100)] 
[2490] Added support for string data field within an option.

13 years ago[2157] add testcase
Yoshitaka Aharen [Wed, 21 Nov 2012 12:57:03 +0000 (21:57 +0900)] 
[2157] add testcase

13 years ago[2376] Fix test compilation
Michal 'vorner' Vaner [Wed, 21 Nov 2012 12:56:27 +0000 (13:56 +0100)] 
[2376] Fix test compilation

An include was missing.

13 years ago[2376] Some forward declarations
Michal 'vorner' Vaner [Wed, 21 Nov 2012 12:52:27 +0000 (13:52 +0100)] 
[2376] Some forward declarations

So we can include less

13 years ago[2157] corrected condition for "request.badednsver"
Yoshitaka Aharen [Wed, 21 Nov 2012 12:48:17 +0000 (21:48 +0900)] 
[2157] corrected condition for "request.badednsver"

13 years ago[2376] Split off the add callback
Michal 'vorner' Vaner [Wed, 21 Nov 2012 12:48:02 +0000 (13:48 +0100)] 
[2376] Split off the add callback

So the issue callbacks don't depend on other things.

13 years ago[2404] Basic Lease4 functionality working
Stephen Morris [Wed, 21 Nov 2012 12:44:18 +0000 (12:44 +0000)] 
[2404] Basic Lease4 functionality working

13 years ago[2376] Rename LoaderCallbacks to MasterLoaderCallbacks
Michal 'vorner' Vaner [Wed, 21 Nov 2012 12:19:17 +0000 (13:19 +0100)] 
[2376] Rename LoaderCallbacks to MasterLoaderCallbacks

And few other similar renames.

13 years ago[2376] Rename loader_callbacks to master_loader_callbacks
Michal 'vorner' Vaner [Wed, 21 Nov 2012 12:10:06 +0000 (13:10 +0100)] 
[2376] Rename loader_callbacks to master_loader_callbacks

13 years ago[2490] Improved comments in OptionDefinition class.
Marcin Siodelski [Tue, 20 Nov 2012 19:26:47 +0000 (20:26 +0100)] 
[2490] Improved comments in OptionDefinition class.

13 years agoMerge branch 'master' into trac2451
Mukund Sivaraman [Tue, 20 Nov 2012 18:04:13 +0000 (23:34 +0530)] 
Merge branch 'master' into trac2451

13 years ago[2490] Support for creating options using a collection of string values.
Marcin Siodelski [Tue, 20 Nov 2012 17:32:29 +0000 (18:32 +0100)] 
[2490] Support for creating options using a collection of string values.

13 years ago[2353] style fixes: folded long lines
JINMEI Tatuya [Tue, 20 Nov 2012 13:24:23 +0000 (22:24 +0900)] 
[2353] style fixes: folded long lines

13 years ago[2450] Document in the guide that ldconfig has to be run sometimes
Mukund Sivaraman [Tue, 20 Nov 2012 12:51:13 +0000 (18:21 +0530)] 
[2450] Document in the guide that ldconfig has to be run sometimes

13 years ago[2404] lease_time renamed valid_lifetime in lease4 table
Stephen Morris [Tue, 20 Nov 2012 12:49:38 +0000 (12:49 +0000)] 
[2404] lease_time renamed valid_lifetime in lease4 table

Make the names of the columns consistent between the lease4 and
lease6 tables.

13 years ago[2404] Add another Lease4 constructor
Stephen Morris [Tue, 20 Nov 2012 12:47:22 +0000 (12:47 +0000)] 
[2404] Add another Lease4 constructor

This constructore is for use by the MySQL code.  By passing buffer
addresses and lengths, the need for the creation of intermediate
std::vectors is avoided.

13 years ago[2404] Minor changes to make files conform to programming style
Stephen Morris [Tue, 20 Nov 2012 12:45:01 +0000 (12:45 +0000)] 
[2404] Minor changes to make files conform to programming style

13 years ago[2353] style fix: folded a long line
JINMEI Tatuya [Tue, 20 Nov 2012 11:36:06 +0000 (20:36 +0900)] 
[2353] style fix: folded a long line

13 years ago[2157] add testcase
Yoshitaka Aharen [Tue, 20 Nov 2012 11:28:32 +0000 (20:28 +0900)] 
[2157] add testcase

13 years ago[2421] Print a message (when running make install) about default services
Mukund Sivaraman [Tue, 20 Nov 2012 10:00:17 +0000 (15:30 +0530)] 
[2421] Print a message (when running make install) about default services

There isn't a portable way (across automake versions) of printing
something right at the end of `make install`. So we use the portable
install-exec-hook and display the message in yellow color so that
the user notices it.

echo -e may not be portable, so we continue even if it fails.

13 years ago[2451] Update the guide too about services in default config
Mukund Sivaraman [Tue, 20 Nov 2012 09:43:51 +0000 (15:13 +0530)] 
[2451] Update the guide too about services in default config

13 years ago[2451] Update message in README about services in default config
Mukund Sivaraman [Tue, 20 Nov 2012 09:39:18 +0000 (15:09 +0530)] 
[2451] Update message in README about services in default config

13 years ago[2375] grammar/typo fixes in comments/doc
JINMEI Tatuya [Tue, 20 Nov 2012 07:43:22 +0000 (16:43 +0900)] 
[2375] grammar/typo fixes in comments/doc

13 years ago[2157] use ADD_FAILURE instead of ASSERT_FALSE("string")
Yoshitaka Aharen [Mon, 19 Nov 2012 08:00:28 +0000 (17:00 +0900)] 
[2157] use ADD_FAILURE instead of ASSERT_FALSE("string")