JINMEI Tatuya [Fri, 27 Jan 2012 08:22:44 +0000 (00:22 -0800)]
[1574] 1st step of NSEC3 load support: revise the internal zone data structure
so that it can hold both normal name tree and NSEC3 space. a simple test case
was added.
JINMEI Tatuya [Fri, 27 Jan 2012 01:00:23 +0000 (01:00 +0000)]
[master] an urgent care fix to build failure after #1614 with older boost.
we should either/both consider revisiting the interface so we avoid the
issue as a result or require higher version of boost. but for now this
should be okay.
JINMEI Tatuya [Thu, 26 Jan 2012 09:06:55 +0000 (01:06 -0800)]
[1575] Introduced a new NSEC3Hash class based on a Nsec3Param in datasrc,
fixing bugs like case-sensitivity or corner cases for empty salts.
provided more detailed tests and documentation.
JINMEI Tatuya [Thu, 26 Jan 2012 04:56:21 +0000 (20:56 -0800)]
[1575] [1573] corrected the from text constructor so it accepts an empty salt.
not directly related but would be helpful for the purpose of the branch.
JINMEI Tatuya [Wed, 25 Jan 2012 22:52:22 +0000 (14:52 -0800)]
[1614] don't use masterLoad() for bad RRSIG data with mixed cover types;
the change introduced in this branch breaks the assumption of the
callback function used in the test code.
JINMEI Tatuya [Wed, 25 Jan 2012 20:08:28 +0000 (12:08 -0800)]
[1611] added a note about how to identify whether zone is signed with NSEC(3)
in the database zone finder. right now it's a TODO and the current
implementation is a kind of workaround.
JINMEI Tatuya [Wed, 25 Jan 2012 20:02:41 +0000 (12:02 -0800)]
[1611] pydoc updates: revise overall doc that referred to "FindResult"
(which was C++ version only); corrected the return value description of
find_all() which was accidentally broken.
JINMEI Tatuya [Wed, 25 Jan 2012 07:25:02 +0000 (23:25 -0800)]
[1614] make sure that RRSIGs of different types covered are regarded as
separate RRsets. As noted in the previous comment the previous behavior
was okay in practice within the expected restriction of the current
implementation, but as we are probably going to accept more generic forms
of input it would be prudent to fix it at this timing.
JINMEI Tatuya [Wed, 25 Jan 2012 06:52:18 +0000 (22:52 -0800)]
[1614] handle adding of RRSIGs correctly. It now takes into account the
covered type and attaches the RRSIGs to the covered RRset. It also performs
some additional validations on RRSIGs. As a result an empty RRset is
now prohibited (which is correct in this context anyway), so some existing
tests were updated, too.
JINMEI Tatuya [Wed, 25 Jan 2012 06:46:16 +0000 (22:46 -0800)]
[1614] constify some of RRSIG related interface of RRset.
this is not absolutely necessary for the purpose of this branch, but
it will help make it less ugly.
JINMEI Tatuya [Mon, 23 Jan 2012 22:09:54 +0000 (14:09 -0800)]
[1611] clean up: completely removed commented out test data that made test fail.
Removing them was actually correct as commented with "=>": they were not
atcually a wildcard match. The interface change correctly caught the
differences and made the test fail. (I separated the change of this point
from the first commit so that the intent is clearer.)
JINMEI Tatuya [Mon, 23 Jan 2012 21:57:41 +0000 (13:57 -0800)]
[1611] updated the database zonefinder implementation to use new FindResult.
specifically, it now uses the separate flags field for wildcard and NSEC/NSEC3
signed information. WILDCARD(_xxx) result codes were deprecated and removed.
Adjusted tests and python code accordingly. Finally removed the temporary
workaround in auth::Query.
JINMEI Tatuya [Sat, 21 Jan 2012 01:59:52 +0000 (17:59 -0800)]
[1431] updated auth test MockZoneFinder to confirm to the new result format.
the tentative attempt of returning NSEC3 RRsets in negative cases were
canceled, and updated the doxygen doc accordingly.
JINMEI Tatuya [Sat, 21 Jan 2012 01:18:52 +0000 (17:18 -0800)]
[1431] introduced FindResultFlags so that we can separate find result codes
themselves and special attributes. for now, provided a quick-hack wrapper
for auth::Query so we don't have to all data source implementations at once.
JINMEI Tatuya [Fri, 20 Jan 2012 05:01:52 +0000 (21:01 -0800)]
[1431] extended MockZoneFinder::find() so that it will return an empty
NSEC3 RRset for some types of negative responses. (tentatively) added meta
tests to check this behavior, too.
JINMEI Tatuya [Fri, 20 Jan 2012 00:01:10 +0000 (16:01 -0800)]
[1431] implemented FindNSEC3() for MockZoneFinder used in auth Query tests.
while doing so, revisisted the interface and the method now returns both
the closest enclosure proof and next closer proof in a single call.
JINMEI Tatuya [Wed, 18 Jan 2012 18:11:24 +0000 (10:11 -0800)]
[master] disabled IfaceMgrTest::detectIfaces_linux. It continuously fails
and is not expected to be fixed at least until early next week. it's not
good to keep receiving failure reports from a buildbot when it's not expected
to be fixed immediately, so I'm disabling it.
okayed on jabber.