Ken Raeburn [Mon, 17 Sep 2007 23:47:00 +0000 (23:47 +0000)]
Make config.status itself update the timestamp file associated with
autoconf.h, so that we don't need a redundant invocation of
config.status during the first build.
Ken Raeburn [Tue, 11 Sep 2007 01:12:49 +0000 (01:12 +0000)]
Before the error-message tests, make sure the host principal exists,
so we get consistent errors. Expect the "keytab not found" error,
rather than the "principal doesn't exist" error.
Tom Yu [Wed, 5 Sep 2007 19:53:33 +0000 (19:53 +0000)]
Revise patch to avoid 32-byte overflow which remained after the
initial patch. Memory written to by the IXDR macro calls had not been
accounted for. Thanks to Kevin Coffman, Will Fiveash, and Nico
Williams for discovering this bug and assisting with patch
development.
Add support for building 64-bit AMD64 MSI install packages
in addition to 32-bit i386 MSI install packages.
Differences between 32-bit MSI and 64-bit MSI include:
* no krb4 binaries and libraries
* no kclient binaries and libraries
* no krb524 binaries and libraries
* no leash32.exe
* new AMD64 UpgradeCode permits parallel installation with 32-bit MSI
* support for Visual Studio 2005 (VS8, CL1400) merge modules
Open Issues:
* 32-bit MSI installs kfwlogon.dll on AMD64 systems
* 32-bit and 64-bit NetIDMgr.exe as startup. Need to decide
which should be executed by default. Only one can run at
a time.
* Need to make sure that src/windows/build properly configures
the site-local.wxi file for Visual Studio 2005 and platform.
File locking was non-existant in this code and fccs chained list was
not used at all. This resulted in an assertion failure when closing the
cache. Code has been reorganized to parallel the code in krb5_fcc_resolve
for easier maintenence.
Commented out test in t_cc.c has been updated to actually test this code.
Ken Raeburn [Wed, 5 Sep 2007 00:12:30 +0000 (00:12 +0000)]
Rework error-mapping code to preserve status code values when returned
by only one mechanism. Revert RPC code to relying on this.
Build error-mapping code on a bidirectional map instead of a simple
array. When a status code is returned but has been seen returned from
a different mechanism already, generate a new number, starting at
100,000.
Use gssrpcint_printf for some more debugging code.
Tom Yu [Wed, 29 Aug 2007 22:59:52 +0000 (22:59 +0000)]
Make ccache handle referrals better by storing both server principal
names if they differ between the creds structure and the encoded
ticket and by looking up the server principal using the client's realm
if not found and server's realm was initially the referral (empty)
realm.
Jeffrey Altman [Wed, 29 Aug 2007 22:38:26 +0000 (22:38 +0000)]
NIM file ccache support improvements
NIM supports the ability of the user to specify an
explicit ccache name for use with an identity. If
this ccache is a FILE ccache, we need to be able to
store credentials into the ccache. krb5cred.dll
did not previously specify the KRB5_TC_OPENCLOSE flag
on the ccache when setting other flags such as
KRB5_TC_NOTICKET (which is used with MSLSA ccaches).
As a result, open/close mode was turned off, the
ccache file would be opened in read-only mode and
attempts to store credentials into the ccache would
fail. This is fixed by specifying KRB5_TC_OPENCLOSE
when setting the ccache flags.
When a CCAPI implementation is unavailable, we need
to automatically generate the FILE ccache name if
one has not already been specified. We default to
a file stored in the user's Local Settings\Temp
directory. The generated ccache is then added to
the file ccache watch list.
Finally, some users have complained about the
behavior of Microsoft Vista's UAC mode and how
it makes the CCAPI cache useless for storing
credentials that must be used in conjunction
with processes that do not have restricted
privileges since those processes run in a
separate logon session. For these users we
have added a "DefaultToFileCache" registry
value that can be specified to force the use
of FILE ccaches in preference to CCAPI ccaches
when there is no explicit ccache specified
for a given identity. Unlike CCAPI ccaches,
the FILE ccaches are accessible from both
restricted and unrestricted processes when
UAC is active.
Ken Raeburn [Wed, 29 Aug 2007 20:16:03 +0000 (20:16 +0000)]
test program build problem
Split out the "standalone" test code from trval.c, so we produce
trval.o only once, instead of twice with different compilation flags.
One case generated the "trval" program directly, but produced and
deleted trval.o as an intermediate step in the compiler, which messes
things up if make thinks it's already built trval.o for another test
program.
Make the standalone test into t_trval.
Build problem reported by Will Fiveash of Sun, about ten minutes ago.
Jeffrey Altman [Tue, 28 Aug 2007 20:58:45 +0000 (20:58 +0000)]
NIM: 64-bit Windows Support and Removal of Compile Time Warnings
This patch permits Network Identity Manager to be built for 64-bit Windows.
In the process all compile time warnings have been taken care of.
For 64-bit Windows, we do not build the Kerberos v4 Credential Provider
and we will not attempt to load the krb524 library.
Note that when testing the 64-bit NIM, there is no CCAPI at the
moment so you must manually specify a FILE: ccache as part of the
identity's Kerberos v5 configuration if you want to use cache's
other than the MSLSA.
This patch also consolidates the computation of the default ccache
name into utility functions:
Ken Raeburn [Tue, 28 Aug 2007 00:28:17 +0000 (00:28 +0000)]
Remove macros and associated comments that appear to be for
multiple-inclusion protection of only sub-portions of k5-int.h,
presumably from a time when those portions were separate files. Since
the entire file is now protected against multiple inclusions, these
other macros aren't needed.
A few are left, mostly because they also appear in other files.
Ken Raeburn [Mon, 27 Aug 2007 23:31:33 +0000 (23:31 +0000)]
Define KRB5_ATTR_DEPRECATED (and undef at end of file) and attach it
to the function declarations enabled by KRB5_DEPRECATED. Definition
depends on having GCC version 3.2.3 or later. (Earlier versions may
have supported it, but that's what I found docs for. Windows compiler
support coming later, based on Jeff's suggestions.)
Jeffrey Altman [Mon, 27 Aug 2007 07:08:24 +0000 (07:08 +0000)]
Windows 64-bit - avoid missing symbol errors
Microsoft defaults stack checking (/Gs) to on. This requires
that bufferoverflowU.lib be included in the link step. The
macro SCLIB in the build system specifies this library on
versions of Windows that require it. Include SCLIB on the
link line of the makefile.
Ken Raeburn [Fri, 24 Aug 2007 23:33:44 +0000 (23:33 +0000)]
Remove from export list several encode_* and decode_* symbols that are
not used outside the krb5 library. (In some cases, the only use is in
our own test programs, which means two things: The test programs
should probably be changed to use the accessor interface, and some of
the newer encoder/decoder functions aren't being unit-tested.)
Jeffrey Altman [Fri, 24 Aug 2007 14:52:59 +0000 (14:52 +0000)]
NIM: Revert ticket 5604
There was a spurious trigger for reloading the layout of the Network
Identity Manager timer code. This was presumably introduced to
mitigate a problem where the identity and outline status might become
stale. (Ticket 5604)
Jeffrey Altman [Fri, 24 Aug 2007 14:51:46 +0000 (14:51 +0000)]
NIM: Reposition New Credentials Dialog if necessary
The new credentials dialog in Network Identity Manager does not check
whether it is positioned outside of the display screen. It tries to
position itself in the center of the primary display if the Network
Identity Manager window is hidden and it tries to center itself over
the main window if the main window is visible. If the main window is
too close to the edge of the screen, this may result in the new
credentials window being partially outside the display area. This is
especially a problem when the new credentials dialog switches to the
advanced view.
The patch checks whether the window rectangle is visible before
repositioning the new credentials dialog and adjusts the window
rectangle so that it is.
Jeffrey Altman [Fri, 24 Aug 2007 14:49:42 +0000 (14:49 +0000)]
NIM: External changes to default identity are improperly reflected by krb5 provider
The Kerberos v5 identity provider for Network Identity Manager
monitors the "Software\MIT\kerberos5" registry key for the logged in
user for changes to the "ccname" value. If a change is noticed, it
would query the Kerberos v5 library for the default credentials cache
and attempt to determine the new default identity, which it would then
communicate to the Network Identity Manager application.
When the identity provider queried the Kerberos v5 library after a
registry change notification, it used a cached krb5_context for the
thread. The default credentials cache found using this krb5_context
may not be what the registry specified.
This patch modifies the code in k5_ccname_monitor_thread() to create a
use a new krb5_context when querying for the default credentials cache
following a registry change notification. Doing so ensures that
Kerberos v5 library takes the new registry value into account.
Jeffrey Altman [Fri, 24 Aug 2007 14:47:30 +0000 (14:47 +0000)]
NIM: khcint_remove_space() frees memory too soon
The Network Identity Manager Configuration Provider module keeps track
of the application and plug-in configuration settings organized into
configuration spaces. The state of each configuration space is
maintained in a reference counted object. Once all the references are
released, the Configuration Provider will attempt to free the
resources allocated for the object.
If the configuration space was marked for deletion, then the registry
keys associated with the object need to be deleted when the
object is being discarded. Due to a coding error, the memory
allocated for the object would be freed before the associated registry
keys were deleted. This could result in a memory access error.
The patch corrects the code in khcint_remove_space() to free the
allocated memory after all the remaining clean-up steps have been
performed.
Jeffrey Altman [Fri, 24 Aug 2007 14:45:37 +0000 (14:45 +0000)]
NIM: Add Identity Provider Pre-Process Message
The Network Identity Manager application does not provide a user
interface for identity specification. That responsibility lies with
the identity provider. Whenever a dialog needs to allow the user to
specify an identity, the identity provider has to populate the dialog
with the necessary controls so that the user can specify an identity.
In the case of the Kerberos v5 identity provider, the controls allow
the user to specify a username and a realm.
Once the dialog is populated, the application will dispatch window
messages to the identity provider. The identity provider will handle
the window messages and notify the application when the selected
identity changes.
One deficiency of the API was that there was no message to notify the
identity provider that an identity selection has to be made
immediately. When the user invokes the default action for a dialog by
hitting enter, the only message received by the dialog is a command
identifier of the default action. In this case, the identity provider
will not get a chance to notify the application of the identity
selection.
This patch fixes the API deficiency by introducing a new message,
WMNC_IDENT_PREPROCESS, which the application can use to notify the
identity provider that the dialog box is about to be processed. In
response, the identity provider can notify the application of the
selected identity even if no other messages were received by the
identity provider.
Jeffrey Altman [Fri, 24 Aug 2007 14:43:30 +0000 (14:43 +0000)]
NIM: Keep API release documentation up to date
Update the Network Identity Manager developer documentation to include
a reference to the 1.3.0 release which was included with Kerberos for
Windows 3.2.1.
The release history and, in particular, the API versions corresponding
to each release is important for third-party plug-in developers.
Jeffrey Altman [Fri, 24 Aug 2007 14:41:52 +0000 (14:41 +0000)]
NIM: support include files in schemas
The ccsv.pl and csvschema.cfg scripts are used to generate "C" source
code from CSV files containing tabular data. In particular, these are
used to define the configuration schema for Network Identity Manager
and some of its plug-ins.
It is desirable to be able to include arbitrary header files and
define macros in the generated C code so that the schema definition
can use them. This patch allows the CSV files to contain headers that
define lines of text that will be included literally in the generated
C code. Lines at the start of schema CSV file that begin with '#@'
will be stripped of the '#@' prefix and inserted into the C code.
E.g: The following line at the start of a schema CSV file:
#@#include<windows.h>
,will result in the following text in the C code:
#include<windows.h>
Then the schema definition can use macros of the form:
ClrHeaderExpSel, KC_INT32, "RGB(195, 94, 94)"
,which use macros such as RGB that are defined in the included header
file.
Jeffrey Altman [Fri, 24 Aug 2007 14:40:23 +0000 (14:40 +0000)]
NIM: remove unused code from ui/credwnd.c
Remove unused code from Network Identity Manager credwnd.c. The code
was meant to construct a user interface context based on where the
user right clicks on the credentials display. However, doing so
without indicating the changed selection to the user results in the
application performing an operation on an identity or credential that
the user didn't intend to select.
The code was commented out and was never used in any recent release of
Kerberos for Windows.
Jeffrey Altman [Fri, 24 Aug 2007 14:38:45 +0000 (14:38 +0000)]
NIM: Selection Issues
Credentials selection in Network Identity Manager has usability
issues due to the following causes:
- The "cursor row" is not always selected.
The "cursor row" is the row which the "cursor" is on. Navigating the
credentials view using the keyboard or clicking the credentials
display with the mouse will move the cursor to different rows.
However, this cursor row is not always selected, especially when
Network Identity Manager starts.
Having the selection be independent of the cursor row is a
requirement for supporting "toggle" selections (holding the 'ctrl'
key while clicking), which is a standard way of doing multiple
selections on Windows.
The problem with the cursor row not being selected when Network
Identity Manager starts is due to the delayed start of its plug-ins.
Even though the first row is initially selected, when plug-ins
complete initialization and notify the application about the
credentials that they see, those credentials end up accumulating
under different identities. The existing code didn't enforce the
selection state of the identity on the newly added
credentials. Since there were unselected credentials under the
selected outline level, the code would then turn off the selected
bit for the outline (which usually is an outline level for an
identity) for consistency.
The patch changes the behavior to enforce the selection state of the
enclosing outline on any new outline levels or credentials that are
added under it. This prevents an outline level from losing its
selection state when new credentials are added under it.
- Identities may have stale data associated with it.
The credentials view maintains a set of cached properties for each
identity that has credentials. During each refresh cycle, it would
go through the credentials and update the properties of each
identity. However it would not update the properties for identities
that are not associated with any credentials.
When the credentials associated an identity were deleted, the cached
properties for that identity sometimes never got reset. If the
identity was marked as "always visible", then it would be listed in
the credentials view along with the stale properties.
This patch properly initializes the properties of identities which
are not associated with any identities.
- Selection state is not updated when switching views.
The credentials view maintains selection state for individual
credentials when switching views. The same is not true for the
outlines since the outline needs to be reconstructed during the
switch.
The exising code failed to update the selection state of the
outlines after switching the view to reflect the the selection state
of the credentials. As a result, once a the user switched a view,
she might see outline levels which do not appear to be selected even
though all the credentials contained at the outline level appear
selected.
This patch properly adjusts the selection state of outline nodes to
correspond to the selection state of the contained credentials.
- Selection state may be inconsistent when more than one credential is
associated with a single row.
Some rows may represent more than one credential. A collapsed
outline represents all the credentials contained within that outline
level. In addition, two credentials that will appear the same to
the user (because all the displayed properties are the same) will be
represented by one row.
The selection state of these rows should be consistent with the
selection state of all the credentials that it represents. The
previous code did not enforce this constraint. This patch aims to
fix this by enumerating all the credentials that are represented
by each row and setting the selection state of each credential to
match the selection state of the row.
Jeffrey Altman [Fri, 24 Aug 2007 14:37:07 +0000 (14:37 +0000)]
NIM: Handle WM_PAINT messages without update regions
It is possible to receive a WM_PAINT message in Windows without there
being an update region. For example, this can be caused by someone
calling RedrawWindow() with the RDW_INTERNALPAINT flag set. In this
case, GetUpdateRect() will indicate that there is no update region and
calling BeginPaint()/EndPaint() results in incorrect behavior.
The credentials window in Network Identity Manager needs to perform
special handling for this case by obtaining a proper device context
and completing the drawing operation.
Jeffrey Altman [Fri, 24 Aug 2007 14:34:30 +0000 (14:34 +0000)]
NIM: do not permit resizing of filler columns
The credentials display of Network Identity Manager allows the user to
change the order and size of the displayed columns. However, some
columns are not resizable.
An oversight in the earlier code allowed the user to change the size
of "filler" columns. These columns are sized to fill up the remainder
of the display area after the other columns have been allocated.
Their width is determined by the size of the credentials display and
the width of the other columns. They are used in the basic view where
the only columns are the flags column (fixed width) and the identity
column (filler).
This patch prevents the "filler" columns (columns with the
KHUI_CW_COL_FILLER flag) from being resized.
Jeffrey Altman [Fri, 24 Aug 2007 14:33:09 +0000 (14:33 +0000)]
NIM: Cannot cancel timers which have inserted a WM_TIMER message into the queue
The credentials view in Network Identity Manager displays several user
interface elements that need to be updated periodically such as any
fields that denote the time remaining for a credential or an identity,
or an icon and coloring used to indicate the expiration state. When
the display rows are computed, the credentials view creates a set of
timers that reference each row that times out when that row needs to
be redrawn.
Since the rows change when switching views or when the outline is
recomputed, all the timers are canceled and re-scheduled. However, a
race conditions exists where the timer times-out before it is
canceled, in which case a WM_TIMER message is placed in the
credential window's message queue. Windows does not support
canceling a timer that has already fired and has been placed on the
message queue.
By the time the WM_TIMER message is received by the window, the rows
of the display would have been recomputed and the row that the message
references may not be what it intended to reference. A spurious
WM_TIMER message is harmless when it refers to a row corresponding to
a credential. However, the existing code assumed that if a timer event
is received that referred to an outline row, then that outline must be
an expanded view of an identity, which is currently the only type of
outline row that receives timers. This assumption does not always
hold in the case of a spurious WM_TIMER message and may lead to the
code attempting to use the outline data as a handle to an identity.
The patch fixes the problem by checking if the row is actually an
expanded view of an identity and ignoring the message if it is not.
Jeffrey Altman [Fri, 24 Aug 2007 14:29:37 +0000 (14:29 +0000)]
NIM: Context menu selection issues
The handler for WM_CONTEXTMENU in the credentials view of Network
Identity Manager assumed that the context menu was invoked using the
mouse. If it was, then the message parameters would specify the x and
y co-ordinates of the mouse. The context menu can also be invoked via
the keyboard, in which case the x- and y- coordinates are set to
(-1,-1).
An additional problem with the code is that it was not selecting the
row that was right-clicked on if it was not already selected. This
results in the some of the commands on the context menu targetting
credentials that the user didn't intend to target.
This patch adds support for handling the context menu when it is
invoked via the keyboard and also sets the selection to the row that
was right-clicked if the user invokes the context menu using the
mouse.
Jeffrey Altman [Fri, 24 Aug 2007 14:28:21 +0000 (14:28 +0000)]
NIM: Color Schemas
The default color scheme used by the Network Identity Manager credentials
display can sometimes cause the text to be difficult to read. In
addition, since some of the colors are derived from colors used by the
current Windows theme, the selection, window background and text
colors may be mismatched with the colors that are hardcoded into the
application.
To rememdy this problem, this patch defines a new set of colors
that will be used with the credentials display. The new scheme
doesn't use a special color to distinguish the default identity which
is already indicated with the text "(Default)" displayed alongside it.
Instead the colors are used to denote the remaining lifetime of
credentials and identities.
Also, the color scheme defines all the colors that it uses instead of
deriving some of them from the Windows color scheme.
All the color information is now kept in the Network Identity Manager
UI schema. The schema automatically maps to the registry, so users
(and deployers) can override the colors by creating the necessary
registry keys and values. The registry keys containing color
information are:
Software\MIT\NetIDMgr\CredWindow\Themes and
Software\MIT\NetIDMgr\CredWindow\Themes\Default
The "Default" key contains the default color scheme. The color value
names are defined in ui\uiconfig.csv under Themes\_Schema
configuration subspace. Each color is represented by a 32-bit number.
The low-order 24 bits contain a COLORREF value. The high-order 8 bits
contain an alpha value which, if non-zero, will be used to blend the
color with the selection color (color value named ClrSelection).
Jeffrey Altman [Fri, 24 Aug 2007 14:26:11 +0000 (14:26 +0000)]
NIM: New command-line options --hide and --show / new command-line help dialog
Add two command-line options to the Network Identity Manager application:
--hide : If there is already an instance of Network Identity Manager
running in the user's session, this will cause the main
window of that instance to be hidden.
--show : Unhides the main window of the running instance.
If no options are specified when starting netidmgr.exe while another
instance is running, the running instance will perform the default
action as configured in the user's preferences. By default, this will
be to show the main window.
The message box that displayed the command-line options if an invalid
option is specified has been replaced with a dialog box that shows the
options in a more readable rich text control. The contents of the
control are specified in ui/lang/<lang>/cmdline.rtf.
Do not edit cmdline.rtf with Microsoft Word. The output of Word is
incompatible with the RichEdit20 component.
Jeffrey Altman [Fri, 24 Aug 2007 14:23:14 +0000 (14:23 +0000)]
NIM: Identity Configuration Panel Fixes
In the identity configuration panel of Network Identity Manager, the
user can specify a new identity which can then be configured.
The existing code didn't check if the identity specified by the user
already exists. The patch adds the check. If the identity already
exists, the user is notified as such.
Another bug prevented the user from configuring an identity that was
added back in following the deletion of the same identity during the
same session. The deleted status of the identity was not reset when
it was added back.
Additionally, this patch adds code that has already been added to the
new credentials dialog to apply Windows XP theme textures to the child
dialogs used as tab panels in the configuration dialog. Child dialogs
don't automatically adjust the theme settings based on whether it is
nested inside a tab control. The theme must be applied manually.
Jeffrey Altman [Fri, 24 Aug 2007 14:20:31 +0000 (14:20 +0000)]
NIM: resource leak in khui_action_trigger()
The khui_action_trigger() function in the Network Identity Manager API
creates a copy of the current user interface context (which contains
information about the credentials and identities that are currently
selected) before triggering the requested action. Then it will use
the copy to restore the user interface context to its previous state.
A coding error results in the copy of the context to never be
released. As a result there is a resource leak.
The attached patch fixes the leak by releasing the context once it
is no longer needed.
Ezra Peisach [Mon, 20 Aug 2007 14:50:41 +0000 (14:50 +0000)]
read_entropy_from_device on partial read will not fill buffer
read_entropy_from_device() will loop in read until the desired number
of bytes are read from the device (/dev/random, /dev/urandom). I have
observed that for /dev/random, if there is not enough bits available
for reading - it will return a partial read. The code would loop in
this case, but never advance the location to place the new bytes -
hence the start of the buffer would be filled again - leaving the tail
end as stack garbage.
Ken Raeburn [Thu, 16 Aug 2007 22:55:06 +0000 (22:55 +0000)]
remap mechanism-specific status codes in mechglue/spnego
This patch creates a mapping in the mechglue/spnego code to modify
mechanism status codes when passing them back to the application, so
that mechglue's display_status dispatcher can determine the correct
mechanism to dispatch to.
This is part of the "get enhanced error messages from gssapi
applications" project; ticket 5590 has updates to the Kerberos 5
mechanism to extract enhanced error messages (when there are any) from
the Kerberos library.
util/gen.pl, util/t_*.pm: New code generation script and templates.
lib/gssapi/generic: Add a new, global mapping that enumerates the
{mechOID,status} pairs as they're seen, allowing a magic mechOID value
to indicate com_err error codes from mechglue and spnego, and
reserving status code 0 for unknown errors. Preload the Kerberos
"wrong principal" error code once for each mechanism OID used for
Kerberos, so the entries get fixed positions (1-3) in the table.
lib/gssapi/gss_libinit.c: Call the initializer and destructor
functions.
lib/gssapi/mechglue, lib/gssapi/spnego: Enter all mechanism-generated
or locally-generated status codes into the mapping table, and return
the table index to the application. Do the reverse in display_status,
to get the messages from the mechanism..
lib/rpc: Define new function gssrpcint_printf to use for debugging
instead of printf, to redirect output away from dejagnu; add a couple
more debugging calls. Check for minor status codes 1-3 now instead of
KRB5KRB_AP_WRONG_PRINC.
tests/dejagnu/krb-standalone/gssftp.exp: Test getting more detailed
error messages back, by having the ftp client attempt to authenticate
to a non-existent service, and examining the error message for the
service principal name.
Ezra Peisach [Thu, 16 Aug 2007 01:52:10 +0000 (01:52 +0000)]
Change prototype for g_token_size to match function declaration later
in file. (OM_Uint32 changed to unsigned int). On a 64 bit architecture, they
are different.
Ezra Peisach [Tue, 14 Aug 2007 18:22:58 +0000 (18:22 +0000)]
t_ser should no longer use kdb libraries
Remove the call to krb5_db_fini() - as rest of the db code was pulled
during DAL integration. This removes dependency on db libraries -
alter Makefile.in.
Kevin Koch [Fri, 10 Aug 2007 14:37:04 +0000 (14:37 +0000)]
Simulate changing views when the REFRESH action is run and when credentials are updated.
This makes the symptoms go away but does not solve whatever the underlying problem is.
Ken Raeburn [Thu, 9 Aug 2007 20:09:48 +0000 (20:09 +0000)]
need more dylib_file specs for darwin
Currently the KDB LDAP plugin won't build on Mac OS X 10.4 if a tree
hasn't been previously installed, because it can't find the libraries
that we haven't installed yet. (Finding earlier versions isn't
sufficient, if symbols are needed that are not present in the
installed versions.)
Add -dylib_file specs for libkadm5srv and libkdb to LDCOMBINE, in
addition to libkrb5support that was already there.
Unfortunately, this makes shlib.conf dependent on more library version
numbers.
Jeffrey Altman [Wed, 8 Aug 2007 17:45:37 +0000 (17:45 +0000)]
Patch developed by kpkoch with style changes from jaltman
The size/position of the main application window is
internally updated in response to WM_MOVE messages but is
only written to the registry after a timeout period. This
is done due to the large number of WM_MOVE messages that
can be delivered during a windows drag / resize operation
involving the user or explorer shell's tile and cascade
operations. (or those involving third party desktop managers.)
In NIM 1.8 two different application view modes (standard
and advanced) replaced the single view mode in previous
releases. The size/position update logic was not modified
to take into consideration the possibility that a user might
move/resize the window and then quickly toggle modes before
the new location or size were recorded to the registry.
This change ensures that when a mode change occurs, via a
call to khm_set_main_window_mode(), that the current
location/size will be written to the registry and any
outstanding timer, MW_RESIZE_TIMER, will be cleared.
The logic to save the location/size has been extracted
into the new static function main_wnd_save_sizepos().
main_wnd_save_sizepos() is only called after the application
window has been created.
Jeffrey Altman [Mon, 6 Aug 2007 15:19:50 +0000 (15:19 +0000)]
missing comma
The pkinit additions in revision 18973 left out a comma after the
last function in the list. This caused builds that did not define
DESIGNATED_INITIALIZERS to break.
projects / thirdparty / krb5.git / log
