Tom Hromatka [Tue, 9 Mar 2021 19:50:11 +0000 (19:50 +0000)]
ftests: Add a cgconfigparser test that loads a directory
Add a cgconfigparser test that loads its configuration files
from a specified directory.
-----------------------------------------------------------------
Test Results:
Run Date: Mar 09 19:49:49
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 21.22
018-cgconfig-load_dir.py 0.94
teardown 0.00
---------------------------------------------------------
Total Run Time 22.16
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 9 Mar 2021 19:17:49 +0000 (19:17 +0000)]
ftests: Add a simple cgconfigparser test
Add a simple cgconfigparser test that operates on a
single configuration file.
-----------------------------------------------------------------
Test Results:
Run Date: Mar 09 19:19:17
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 17.78
017-cgconfig-load_file.py 0.70
teardown 0.00
---------------------------------------------------------
Total Run Time 18.48
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 10 Mar 2021 18:20:24 +0000 (18:20 +0000)]
api.c: Don't fail a recursive write if value isn't dirty
When cgroup_modify_cgroup() invokes cgroup_set_values_recursive(),
some of the settings within the cgroup may not be writable. Avoid
failing the entire write by ignoring write failures on settings that
do not explicitly have the dirty flag set.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 10 Feb 2021 17:25:10 +0000 (17:25 +0000)]
cgget: Major refactor
Previously cgget used data structures unlike anywhere else
within libcgroup. cgget had arrays of strings to hold the
list of controllers, settings, and values.
Update cgget to utilize struct cgroup and struct
cgroup_controller.
This patch is intended to have no functional changes.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Mon, 8 Feb 2021 23:05:24 +0000 (16:05 -0700)]
wrapper.c: Add support for empty values in cgroup_add_value_string()
cgroup_add_value_string() is the fundamental building block
for adding a name/value pair to a cgroup_controller struct.
Add support for a NULL value field.
Currently it only supports adding a valid value, but in a
subsequent commit, cgget will utilize this function to build
up a hierarchy of cgroups, controllers, and setting names.
The values are NULL at the time the struct are populated and
will be read from sysfs at a later time.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 9 Feb 2021 23:23:10 +0000 (23:23 +0000)]
ftests: Add cgget invalid parameter test
Add a cgget test that passes in various invalid parameter
combinations.
-----------------------------------------------------------------
Test Results:
Run Date: Feb 09 23:24:14
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 18.89
016-cgget-invalid_options.py 0.93
teardown 0.00
---------------------------------------------------------
Total Run Time 19.82
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 11 Feb 2021 19:28:18 +0000 (19:28 +0000)]
ftests: Add cgget '-a' test
Add a cgget test that utilizes the '-a' flag.
-----------------------------------------------------------------
Test Results:
Run Date: Feb 11 19:27:39
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 20.61
014-cgget-a_flag.py 1.01
teardown 0.00
---------------------------------------------------------
Total Run Time 21.62
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 11 Feb 2021 00:00:48 +0000 (00:00 +0000)]
ftests: Add multiline cgget test
Add a cgget test that receives a multiline setting.
-----------------------------------------------------------------
Test Results:
Run Date: Feb 11 00:00:16
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 16.49
015-cgget-multiline_r_flag.py 0.63
teardown 0.00
---------------------------------------------------------
Total Run Time 17.12
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 9 Feb 2021 22:35:05 +0000 (22:35 +0000)]
ftests: Add cgget test with multiple '-g' flags
Add cgget test with multiple '-g' flags. This test verifies
the following cgget operation:
$ cgget -g freezer -g cpu 013cgget
-----------------------------------------------------------------
Test Results:
Run Date: Feb 09 22:35:21
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 22.29
013-cgget-multiple_g_flags.py 1.18
teardown 0.00
---------------------------------------------------------
Total Run Time 23.47
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
-----------------------------------------------------------------
Test Results:
Run Date: Feb 09 21:39:23
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 16.92
012-cgget-multiple_r_flags2.py 1.83
teardown 0.00
---------------------------------------------------------
Total Run Time 18.75
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
-----------------------------------------------------------------
Test Results:
Run Date: Feb 09 21:24:10
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 17.28
011-cgget-r_flag_two_cgroups.py 1.47
teardown 0.00
---------------------------------------------------------
Total Run Time 18.76
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 9 Feb 2021 21:04:21 +0000 (21:04 +0000)]
ftests: Add cgget test with '-g' <controller>:<cgroup> flag
Add a test that exercises the '-g' <controller>:<cgroup> option
in cgget. This test verifies the following cgget operation:
$ cgget -g cpu:010cgget
-----------------------------------------------------------------
Test Results:
Run Date: Feb 09 21:04:46
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 20.73
010-cgget-g_flag_controller_and_cgroup.py 0.60
teardown 0.00
---------------------------------------------------------
Total Run Time 21.33
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 9 Feb 2021 20:49:43 +0000 (20:49 +0000)]
ftests: Add cgget test with '-g' <controller> flag
Add a test that exercises the '-g' <controller> option
in cgget. This test verifies the following cgget operation:
$ cgget -g cpu 009cgget
-----------------------------------------------------------------
Test Results:
Run Date: Feb 09 20:49:33
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 21.28
009-cgget-g_flag_controller_only.py 0.57
teardown 0.00
---------------------------------------------------------
Total Run Time 21.85
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
-----------------------------------------------------------------
Test Results:
Run Date: Feb 09 20:48:45
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 18.71
008-cgget-multiple_r_flags.py 0.78
teardown 0.00
---------------------------------------------------------
Total Run Time 19.49
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 10 Feb 2021 20:29:13 +0000 (20:29 +0000)]
ftests: Throw an exception if len(stderr) > 0
To better facilitate error handling, throw a RunError
if the stderr has been populated.
cgclassify currently prints warnings to stderr if a
setting isn't in the allow or deny list; ignore these
warnings for now. Also, non-containerized Github
Actions runs complain about missing coverage files for
cgget; ignore those errors.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 10 Feb 2021 20:25:22 +0000 (20:25 +0000)]
ftests: Clean up handling of bytes vs string
The conversion of bytes to string was being done
piecemeal within the functional tests. Consolidate
these conversions all into one location within the
run() method.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Mon, 1 Mar 2021 16:38:58 +0000 (16:38 +0000)]
ftests: Add cgroup v2 cgrules test
Add a simple cgrulesengd tests. Note that it cannot run within
a container.
-----------------------------------------------------------------
Test Results:
Run Date: Mar 01 16:56:22
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 0.00
007-cgrules-basic_cgrules_v2.py 7.13
teardown 0.00
---------------------------------------------------------
Total Run Time 7.13
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Mon, 1 Mar 2021 16:38:03 +0000 (16:38 +0000)]
ftests: Add cgroup v1 cgrules test
Add a simple cgrulesengd tests. Note that it cannot run within
a container.
-----------------------------------------------------------------
Test Results:
Run Date: Mar 01 16:43:17
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 0.00
006-cgrules-basic_cgrules_v1.py 5.21
teardown 0.00
---------------------------------------------------------
Total Run Time 5.21
Tom Hromatka [Mon, 1 Mar 2021 16:37:38 +0000 (16:37 +0000)]
ftests: Clean up a few exceptions
In the ftests and process files, two exceptions were
erroneously throwing ValueException rather than
ValueError. Fix this.
In CgroupVersion.get_version(), it returned CGROUP_UNK
if it couldn't determine the version. Make this method
more pythonic by raising a ValueError exception.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 23 Feb 2021 20:47:38 +0000 (13:47 -0700)]
api.c: Fix erroneous error handling in cgroup_set_values_recursive()
Ignore the positive length returned by asprintf() and only act
upon the error code returned from cg_set_control_value(). Previously
cgroup_set_values_recursive() mishandled the error handling when
the value's dirty flag was set.
Reported-by: Bharani viswas <bharani.viswas@gmail.com> Fixes: 092e4aeb0416f ("api.c: Refactor duplicate logic in cgroup modify and create") Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 23 Feb 2021 20:55:40 +0000 (13:55 -0700)]
gunit: Update test 009 to better test dirty flag
When the dirty flag is set, cgroup_set_values_recursive()
was erroneously failing the recursive setting of values.
There were two problems in the unit test that caused this to
be missed:
1. The dirty flag wasn't being set
2. If fgets() returned a NULL ptr, the contents of the
settings file weren't being checked
Reported-by: Bharani viswas <bharani.viswas@gmail.com> Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 3 Feb 2021 17:32:14 +0000 (10:32 -0700)]
ftests: Make the Process() class instantiable
Make the process class instantiable so that it can
better manage its list of children processes. This
helps ensure that individual tests don't collide with
each other.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 3 Feb 2021 17:07:36 +0000 (10:07 -0700)]
ftests: Ensure the deny list file exists
It's possible that the libcgroup tests are being run
on a system that doesn't have libcgroup installed.
Ensure that the deny list file (currently named
cgsnapshot_blacklist.conf but slated to be renamed)
exists.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 3 Feb 2021 17:00:52 +0000 (10:00 -0700)]
ftests: Use sudo for many cgroup commands when not in a container
When not running in a container, prepend 'sudo' to the
front of cgcreate, cgdelete, cgset, and cgclassify.
It would be advantageous to properly utilize permissions
within Linux so that we don't need to 'sudo' these
commands, but that's more of a kernel/sysfs/cgroups
issue than a libcgroup issue. (Yes, libcgroup does allow
for setting owners and permissions, so someday we should
test this, but that's not a high priority at present.)
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 3 Feb 2021 16:54:55 +0000 (09:54 -0700)]
ftests: Test 004 must be run within a container
Test 004-cgsnapshot-basic_snapshot_v1.py must be
run within a container because the cgsnapshot
data will vary slightly when inside/outside of a
container. Add a check to its prereqs function
to enforce this.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 3 Feb 2021 16:42:44 +0000 (09:42 -0700)]
ftests: Add --container and --no-container flags
In preparation of running the tests outside of a
container, add two flags to ftests.py: --container
and --no-container. As the names imply, these flags
are used to specify whether the tests should be
containerized or not.
Note1: Some tests (cgrulesengd) will only work
in a non-containerized environment.
Note2: Running the tests in a non-containerized
environment could be destructive to a
system as cgroup changes could be made that
adversely affect the entire system.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 24 Dec 2020 21:13:40 +0000 (21:13 +0000)]
ftests: Fix failure cause when multiple tests don't pass
When multiple tests don't pass, the last failure_cause
recorded was the one being displayed. Append the
failure_cause to the failed_tests[] and skipped_tests[]
arrays, so that each failure is properly saved and
reported.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 18:39:11 +0000 (11:39 -0700)]
cgsnapshot: Replace hardcoded "tasks" file
Replace the hardcoded building of the tasks path in
cgsnapshot with a call to cgroup_build_tasks_procs_path().
By calling cgroup_build_tasks_procs_path(), cgsnapshot
now supports both cgroup v1 and cgroup v2.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> Reviewed-by: Dhaval Giani <dhaval.giani@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 22:14:54 +0000 (15:14 -0700)]
ftests: Add cgroup v2 cgsnapshot test
Add a cgroup v2 cgsnapshot test.
-----------------------------------------------------------------
Test Results:
Run Date: Dec 17 22:18:33
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 16.83
005-cgsnapshot-basic_snapshot_v2.py 1.13
teardown 0.00
---------------------------------------------------------
Total Run Time 17.96
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 20:48:35 +0000 (13:48 -0700)]
ftests: Add cgroup v1 cgsnapshot test
Add a cgroup v1 cgsnapshot test.
-----------------------------------------------------------------
Test Results:
Run Date: Dec 17 22:13:22
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 18.66
004-cgsnapshot-basic_snapshot_v1.py 0.47
teardown 0.00
---------------------------------------------------------
Total Run Time 19.14
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 20:38:43 +0000 (13:38 -0700)]
ftests: Add support for cgsnapshot
Add functional test support for cgsnapshot to the
Cgroup class. The method, snapshot(), invokes libcgroup's
cgsnapshot and returns a dictionary of Cgroup class
instantiations (which are analogous to struct cgroup
within libcgroup.)
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 21:54:13 +0000 (14:54 -0700)]
ftests: Make the Cgroup class instantiable
Add logic to the functional test's Cgroup class to
make it analogous to libcgroup's struct cgroup.
By adding __init__(), __str__(), and __eq__() methods,
the cgroup class can very closely mirror struct cgroup.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 19:47:48 +0000 (12:47 -0700)]
ftests: Add a cgroup controller class
Add a controller class that mirrors libcgroup's
struct cgroup_controller. The controller class
contains a dictionary that represents the array
of struct control_values. To simplify the usability
within the functional tests, the __str__() and
__eq__() methods have been overridden.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 19:02:06 +0000 (12:02 -0700)]
ftests: Move cgroup version enums to their own class
In preparation for adding non-static functionality to
the Cgroup class, move the cgroup version enumerations
to their own class. (Enums and __init__() can collide
in strange ways.)
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 18:24:13 +0000 (11:24 -0700)]
github: Display ftests.sh.log in the CI GUI
Now that we invoke ftests.sh in the functional tests'
Makefile.am, test-suite.log isn't that useful. Display
ftests.sh.log in the Github Actions GUI since
ftests.sh.log contains pass/fail info for each test.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 15:03:32 +0000 (08:03 -0700)]
github: Improve logging and reporting
Display the high-level log, test-suite.log, in
the github work for all jobs. Also, archive the
functional test logs to facilitate debugging a
failed run.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 17 Dec 2020 14:59:52 +0000 (07:59 -0700)]
ftests: Invoke ftests.sh in Makefile.am
Invoke a wrapper script, ftests.sh, in the TESTS target
within Makefile.am. This provides two advantages:
1. When new tests are added, Makefile.am does not need
to be updated
2. This adds verbose logging to the continuous integration
suite
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 15 Dec 2020 22:11:01 +0000 (15:11 -0700)]
README.md: Update the coveralls badge
The coveralls.io badge wasn't consistently updating
after a successful run. Remove the "?branch=master"
parameter and switch to using a png rather than an
svg.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Add a Github Actions continuous integration workflow. This
workflow runs the unit tests, the cgroup v1 functional tests,
and the cgroup v2 functional tests. The code coverage results
from all of the runs are collated at coveralls.io.
Like Travis CI, Github Actions currently does not provide a
distro that natively runs cgroup v2. (And it also doesn't
expose the kernel boot command line.) So, like our previous
Travis CI solution, unmount the cpuset controller and enable
it in cgroup v2.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 15 Dec 2020 20:45:46 +0000 (13:45 -0700)]
github: Add a Github Action to setup the libcgroup directory
Add a Github Action to setup the libcgroup directory.
This action installs the required dependencies, run
bootstrap.sh, runs configure, and invokes make.
Since the action is invoked locally (and not via Github
Action's published action mechanism), the repository must
be git cloned prior to running this action.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 3 Nov 2020 15:04:20 +0000 (08:04 -0700)]
ftests: Add a cgroup v2 basic cgget test
Add a test - 003-cgget-basic_cgget_v2.py - that tests
cgget on a cgroup v2 system.
-----------------------------------------------------------------
Test Results:
Run Date: Nov 03 17:49:35
Passed: 1 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 3.76
003-cgget-basic_cgget_v2.py 0.70
teardown 0.00
---------------------------------------------------------
Total Run Time 4.46
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 28 Oct 2020 15:34:13 +0000 (15:34 +0000)]
ftests: Fix config typo in test 001
Test 001 erroneously set the test number in the wrong place -
config.test_num. This caused all the tests to run when only
test 001 was invoked. The correct setting is config.args.num
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 28 Oct 2020 14:43:19 +0000 (14:43 +0000)]
ftests: Run a cgv1 process in the recursive cgdelete test
For cgroup v1, run a process in the child cgroup during
the recursive cgdelete tests - 002-cgdelete-recursive_delete.py.
In cgroup v1, cgdelete should migrate the process to its
parent cgroup.
If the test is being run on a cgroup v2 system, don't
create the process. Cgroup v2 doesn't support processes
running in a non-leaf cgroup, so cgdelete's recursive
command doesn't really make sense.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 28 Oct 2020 14:08:59 +0000 (14:08 +0000)]
ftests: Add support for shell commands in containers
Add support for shell commands to Container.run() method.
The parameter, shell_bool, is passed directly to Run.run()
and is ultimately sent on to subprocess.Popen(). As the
name implies, when shell_bool is set to true, the requested
command will be executed through the shell.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Tue, 27 Oct 2020 18:18:57 +0000 (18:18 +0000)]
ftests: Add symlink to sed
LXC on Ubuntu 20.04 placed at /bin/sed rather than
/usr/bin/sed like the cgtools scripts expect. Create
a symlink at /usr/bin/sed so that the cgroup tools can
run like usual.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 28 Oct 2020 14:57:09 +0000 (14:57 +0000)]
travis: Add test job on cgroup v2 Ubuntu 20.04
Add a test job on Ubuntu 20.04. Prior to running the tests, unmount
the cpuset cgroup controller and enable it in the cgroup v2 unified
hierarchy. Once each job is complete, it notifies coveralls via a
REST call.
Unfortunately, Travis CI doesn't provide a cgroup v2 system image
and also doesn't allow us to modify the kernel boot parameters.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Thu, 15 Oct 2020 21:58:19 +0000 (15:58 -0600)]
api.c: Replace hardcoded "/tasks" in delete functions
Replace the hardcoded building of the tasks path in
cg_delete_cgroup_controller() and cgroup_delete_cgroup_ext()
with a call to cgroup_build_tasks_procs_path(). By calling
cgroup_build_tasks_procs_path(), both delete functions now
support cgroup v1 and v2.
cgdelete now supports cgroup v2.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Fri, 16 Oct 2020 14:58:12 +0000 (14:58 +0000)]
ftests: Add recursive cgdelete functional test
Add a test that creates a cgroup hierarchy and then invokes
cgdelete on the parent cgroup with the recursive flag set.
-----------------------------------------------------------------
Test Results:
Run Date: Oct 16 14:54:20
Passed: 2 test(s)
Skipped: 0 test(s)
Failed: 0 test(s)
-----------------------------------------------------------------
Timing Results:
Test Time (sec)
---------------------------------------------------------
setup 15.11
001-cgget-basic_cgget.py 0.53
002-cgdelete-recursive_delete.py 0.26
teardown 0.00
---------------------------------------------------------
Total Run Time 15.90
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 23 Sep 2020 16:41:32 +0000 (10:41 -0600)]
api.c: Verify if a controller is enabled for a v2 cgroup
Add a function, cgroupv2_controller_enabled(), that checks if the
requested cgroup v2 controller can be used for the specified path.
Again, in cgroup v2, to use a controller, it must be added to the
parent cgroup's cgroup.subtree_control file.
This check is required to ensure that the cgexec and cgclassify
operations will succeed. And with this commit, cgexec and cgclassify
work on both cgroup v1 and cgroup v2 hierarchies.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 23 Sep 2020 16:41:00 +0000 (10:41 -0600)]
api.c: Add function to read the cgroup.subtree_control file
Add a function, cgroupv2_get_subtree_control(), that verifies
if a controller is enabled in the cgroup.subtree_control file
for the requested path.
This function will be used in the next commit - "api.c: Add function
to check if a controller is enabled for a cgroup v2 cgroup" - to
determine if the requested cgroup v2 controller is enabled for a
cgroup. This is a required check to ensure that the
cgclassify/cgexec operation will succeed.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 23 Sep 2020 16:39:33 +0000 (10:39 -0600)]
api.c: Add function to build tasks/procs path
Replace the inline logic in multiple functions that concatenates
the path and cgroup v1 tasks file with a function -
cgroup_build_tasks_procs_path() - that works for both cgroup v1
and v2. In the v1 case, it appends tasks, and in the v2 case, it
appends cgroup.procs.
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 23 Sep 2020 16:49:12 +0000 (10:49 -0600)]
gunit: Add unit tests for cgroupv2_controller_enabled()
This commit adds unit tests for cgroupv2_controller_enabled()
[----------] 4 tests from CgroupV2ControllerEnabled
[ RUN ] CgroupV2ControllerEnabled.CgroupV1Controller
[ OK ] CgroupV2ControllerEnabled.CgroupV1Controller (0 ms)
[ RUN ] CgroupV2ControllerEnabled.RootCgroup
[ OK ] CgroupV2ControllerEnabled.RootCgroup (1 ms)
[ RUN ] CgroupV2ControllerEnabled.ControllerEnabled
[ OK ] CgroupV2ControllerEnabled.ControllerEnabled (0 ms)
[ RUN ] CgroupV2ControllerEnabled.ControllerDisabled
[ OK ] CgroupV2ControllerEnabled.ControllerDisabled (0 ms)
[----------] 4 tests from CgroupV2ControllerEnabled (1 ms total)
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Tom Hromatka [Wed, 23 Sep 2020 16:48:34 +0000 (10:48 -0600)]
gunit: Add unit tests for cgroupv2_get_subtree_control()
This commit adds unit tests for cgroupv2_get_subtree_control()
[----------] 6 tests from GetSubtreeControlTest
[ RUN ] GetSubtreeControlTest.SingleControllerEnabled
[ OK ] GetSubtreeControlTest.SingleControllerEnabled (0 ms)
[ RUN ] GetSubtreeControlTest.SingleControllerNoMatch
[ OK ] GetSubtreeControlTest.SingleControllerNoMatch (0 ms)
[ RUN ] GetSubtreeControlTest.SingleControllerNoMatch2
[ OK ] GetSubtreeControlTest.SingleControllerNoMatch2 (0 ms)
[ RUN ] GetSubtreeControlTest.MultipleControllersEnabled
[ OK ] GetSubtreeControlTest.MultipleControllersEnabled (0 ms)
[ RUN ] GetSubtreeControlTest.MultipleControllersEnabled2
[ OK ] GetSubtreeControlTest.MultipleControllersEnabled2 (0 ms)
[ RUN ] GetSubtreeControlTest.MultipleControllersNoMatch
[ OK ] GetSubtreeControlTest.MultipleControllersNoMatch (0 ms)
[----------] 6 tests from GetSubtreeControlTest (0 ms total)
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
projects / thirdparty / libcgroup.git / log
