]> git.ipfire.org Git - thirdparty/openssh-portable.git/log
thirdparty/openssh-portable.git
2 days agoupstream: Factor out hex2bin into a shared helper function. master anongit/master
dtucker@openbsd.org [Tue, 16 Jun 2026 22:27:10 +0000 (22:27 +0000)] 
upstream: Factor out hex2bin into a shared helper function.

Replace sscanf %hhx (which is C99) with plain %x for better compatibility
in -portable. ok djm@

OpenBSD-Regress-ID: 4d30bb27ffdf2154f1a9f2317df18d256717b300

2 days agoupstream: Use awk instead of cut to help -portable. github-selfhosted/master github/master
dtucker@openbsd.org [Tue, 16 Jun 2026 10:58:42 +0000 (10:58 +0000)] 
upstream: Use awk instead of cut to help -portable.

Some platforms have size limits on cut.

OpenBSD-Regress-ID: fe871e8ed43fd92efb0df76f61c5cc9c5429ea82

2 days agoupstream: Include stdarg.h for va_list (needed for xmalloc.h).
dtucker@openbsd.org [Tue, 16 Jun 2026 09:00:47 +0000 (09:00 +0000)] 
upstream: Include stdarg.h for va_list (needed for xmalloc.h).

OpenBSD-Regress-ID: 34a6d5db48eec77f92f868093dfa0bfc10ae4622

2 days agoupstream: Include stdlib.h for malloc/free and sort headers.
dtucker@openbsd.org [Tue, 16 Jun 2026 08:15:35 +0000 (08:15 +0000)] 
upstream: Include stdlib.h for malloc/free and sort headers.

OpenBSD-Regress-ID: 4f5f427b131f5d6b32ed107b9bef098153f768ce

3 days agoRemove check for OpenSSL w/out AES192/256.
Darren Tucker [Tue, 16 Jun 2026 08:16:32 +0000 (18:16 +1000)] 
Remove check for OpenSSL w/out AES192/256.

This was the case for some old Solaris versions, but the support for it
has long been removed from our compat layer so there's no point checking
for it.

4 days agoupstream: use different strategy to check whether keys are present or
djm@openbsd.org [Mon, 15 Jun 2026 06:36:52 +0000 (06:36 +0000)] 
upstream: use different strategy to check whether keys are present or

absent in the agent; helps some -portable tests on platforms that have stupid
grep(1)

OpenBSD-Regress-ID: 0cee7ecc437eee7471dc6ccc3b3a0c2b60c1ad2d

4 days agoupstream: avoid use of paste(1); helps portable
djm@openbsd.org [Mon, 15 Jun 2026 06:24:20 +0000 (06:24 +0000)] 
upstream: avoid use of paste(1); helps portable

OpenBSD-Regress-ID: ce3ad41b34af9fc16af83e4711a62231ee52a95c

4 days agoanother place mldsa-ed25519 keys need deactivation
Damien Miller [Mon, 15 Jun 2026 02:53:53 +0000 (12:53 +1000)] 
another place mldsa-ed25519 keys need deactivation

4 days agoupstream: fix multiple problems with testing hostkey types that are not
djm@openbsd.org [Mon, 15 Jun 2026 01:55:44 +0000 (01:55 +0000)] 
upstream: fix multiple problems with testing hostkey types that are not

enabled by default.

1) Add all hostkey types in the "multiple hostkeys" subtest.
  Previously known_hosts was accidentally clobbered, causing
  only the last added hostkey type to be used.
2) Explicitly enable the hostkey types under test via
  HostKeyAlgorithms

OpenBSD-Regress-ID: 8f12d18b79b5cc8a748e187a0e95529cd85a9dcc

4 days agobring back mlkem768x25519-sha256 stubs
Damien Miller [Mon, 15 Jun 2026 01:43:52 +0000 (11:43 +1000)] 
bring back mlkem768x25519-sha256 stubs

should fix C89 compile

4 days agodon't build ML-KEM/ML-DSA code with <C99 compilers
Damien Miller [Sun, 14 Jun 2026 10:32:12 +0000 (20:32 +1000)] 
don't build ML-KEM/ML-DSA code with <C99 compilers

4 days agoinclude includes.h
Damien Miller [Sun, 14 Jun 2026 10:24:25 +0000 (20:24 +1000)] 
include includes.h

5 days agoprovide a htobe32() replacement
Damien Miller [Sun, 14 Jun 2026 08:56:31 +0000 (18:56 +1000)] 
provide a htobe32() replacement

5 days agohook up new regress/unittests/crypto
Damien Miller [Sun, 14 Jun 2026 05:02:24 +0000 (15:02 +1000)] 
hook up new regress/unittests/crypto

5 days agoupstream: unit and regression tests for composite PQ ML-DSA44/Ed25519
djm@openbsd.org [Sun, 14 Jun 2026 04:08:05 +0000 (04:08 +0000)] 
upstream: unit and regression tests for composite PQ ML-DSA44/Ed25519

keys.

Includes a new unittests/crypto test that tests basic functionality
of the underlying crypto primitives against public test vectors

OpenBSD-Regress-ID: 4463b2e8adec391efa24a953f3c911b72892ca80

5 days agoupstream: make crypto_sign_ed25519_keypair_from_seed non-static.
djm@openbsd.org [Sun, 14 Jun 2026 04:16:19 +0000 (04:16 +0000)] 
upstream: make crypto_sign_ed25519_keypair_from_seed non-static.

The new ML-DSA/ed25519 code needs it

OpenBSD-Commit-ID: 48d00a2094bca8e422494aaa76105c708837436e

5 days agoupstream: Add experimental support for a composite post-quantum
djm@openbsd.org [Sun, 14 Jun 2026 03:59:34 +0000 (03:59 +0000)] 
upstream: Add experimental support for a composite post-quantum

signature scheme that combines ML-DSA 44 and Ed25519 using the construction
specified in draft-ietf-lamps-pq-composite-sigs. There's also an early draft
documenting use of the integration of this scheme into SSH as
draft-miller-sshm-mldsa44-ed25519-composite-sigs

This scheme is not enabled by default. To you use, you'll need
to add it to HostKeyAlgorithms, PubkeyAcceptedAlgorithms, etc.
Keys may be generated using "ssh-keygen -t mldsa44-ed25519".

The ML-DSA implementation comes from libcrux. Thanks to
Jonas Schneider-Bensch and Jonathan Protzenko for their work to
make this available.

Consensus is that it's time to get this in to allow people to
experiment with it.

feedback markus@ tb@ logan@ deraadt@

OpenBSD-Commit-ID: 85f2d41e3d3374b4e8c28a45a7c92f153c4489e2

5 days agoupstream: when replying to a "query" SSH_AGENTC_EXTENSION request,
djm@openbsd.org [Sat, 13 Jun 2026 00:37:13 +0000 (00:37 +0000)] 
upstream: when replying to a "query" SSH_AGENTC_EXTENSION request,

don't append an SSH_AGENT_SUCCESS to the reply to the query. bz3967 ok
dtucker@

OpenBSD-Commit-ID: b51418708096e26dbf73a0c1d3cb49b7352bc899

11 days agoupstream: Make crypto_sign_ed25519_keypair_from_seed()
dtucker@openbsd.org [Sun, 7 Jun 2026 08:50:17 +0000 (08:50 +0000)] 
upstream: Make crypto_sign_ed25519_keypair_from_seed()

static to prevent compiler warnings since it's only used within ed25519.c.

OpenBSD-Commit-ID: cf8b1e8f364167eb1766f646cc18a40f32242991

12 days agoupstream: Import updated moduli
dtucker@openbsd.org [Sun, 7 Jun 2026 08:21:07 +0000 (08:21 +0000)] 
upstream: Import updated moduli

OpenBSD-Commit-ID: c3081ccc6e4c1cb21e68c36f5a92e6d9f09e70b3

12 days agosync fmt_scaled.c with OpenBSD upstream
Damien Miller [Sat, 6 Jun 2026 23:56:41 +0000 (09:56 +1000)] 
sync fmt_scaled.c with OpenBSD upstream

Notably picks up this commit:

revision 1.24
date: 2026/06/06 23:49:25;  author: djm;  state: Exp;  lines: +28 -12;  commitid: oznzDs0MaUT3FEqO;
rearrange scan_scaled(3) ordering of multiplications and divisions
to better preserve accuracy for large exponents. From metsw24-max
via https://github.com/openssh/openssh-portable/pull/671/

ok tb@

2 weeks agoupstream: pass >9 commandline arguments to the internal-sftp server,
djm@openbsd.org [Fri, 5 Jun 2026 08:53:07 +0000 (08:53 +0000)] 
upstream: pass >9 commandline arguments to the internal-sftp server,

previously they were silently dropped; reported by Steve Caffrey ok deraadt@

OpenBSD-Commit-ID: ee6cd5430a3ca027c3223af54b58ad3cc7ccd624

2 weeks agoupstream: avoid truncation of pathnames headed to lstat() for
djm@openbsd.org [Fri, 5 Jun 2026 08:48:43 +0000 (08:48 +0000)] 
upstream: avoid truncation of pathnames headed to lstat() for

systems where PATH_MAX is not the actual max; reported by sahvx655-wq via
GHPR688

OpenBSD-Commit-ID: fcbeeff99d857f2f3916ad06570fa05fc38b0f07

2 weeks agoupstream: rename a variable to be more accurate
djm@openbsd.org [Fri, 5 Jun 2026 06:51:02 +0000 (06:51 +0000)] 
upstream: rename a variable to be more accurate

OpenBSD-Commit-ID: bf277f2832125eb40ac2c9fa3ea66e31214f2131

2 weeks agoupstream: add signature malleability and pubkey validity checks to 686/head 687/head
djm@openbsd.org [Thu, 4 Jun 2026 04:26:51 +0000 (04:26 +0000)] 
upstream: add signature malleability and pubkey validity checks to

ed25519 verification (SSH doesn't depend on these properties) Pointed out by
Soatok Dreamseeker

Add an explicit-seed variant of the keygen function.

feedback / "looks fine" tb@

OpenBSD-Commit-ID: 2a71926bfda24628cf34a88357f44a790e338d5d

2 weeks agoupstream: refer to RFC9987 instead of I-D
djm@openbsd.org [Tue, 2 Jun 2026 06:18:27 +0000 (06:18 +0000)] 
upstream: refer to RFC9987 instead of I-D

OpenBSD-Commit-ID: 6b273c50c2aa818b9144b8d9ab568c4239023297

2 weeks agoReformat setup_ci command line.
Darren Tucker [Tue, 2 Jun 2026 11:57:42 +0000 (21:57 +1000)] 
Reformat setup_ci command line.

This prevents setup_ci from running twice on Cygwin due to different
parsing of the command line since on Windows it's run via Powershell.

2 weeks agoFix search for awk formatter.
Darren Tucker [Tue, 2 Jun 2026 12:20:44 +0000 (22:20 +1000)] 
Fix search for awk formatter.

AC_PATH_PROG only takes a single binary to look for, AC_PATH_PROGS is
what's needed for more than one.  Looks like an error by me in 285546b.

2 weeks agoReplace shell-level timeout with dedicated command.
Darren Tucker [Tue, 2 Jun 2026 08:49:02 +0000 (18:49 +1000)] 
Replace shell-level timeout with dedicated command.

It turns out the systems we run this workflow on all have timeout(1),

2 weeks agoAdd a single retry to VM package install steps.
Darren Tucker [Tue, 2 Jun 2026 08:10:25 +0000 (18:10 +1000)] 
Add a single retry to VM package install steps.

These are potentially flaky due to network issues, so hopefully this
will reduce the number of manual retries needed.

2 weeks agoAdd includes.h for compat functions.
Darren Tucker [Tue, 2 Jun 2026 07:44:12 +0000 (17:44 +1000)] 
Add includes.h for compat functions.

Fixes build on at least old AIX.

2 weeks agosetup_ci.sh: add timeout and allow one retry
Darren Tucker [Mon, 1 Jun 2026 10:43:31 +0000 (20:43 +1000)] 
setup_ci.sh: add timeout and allow one retry

2 weeks agoupstream: differentiate between execution failures and subsystem not
djm@openbsd.org [Mon, 1 Jun 2026 08:27:28 +0000 (08:27 +0000)] 
upstream: differentiate between execution failures and subsystem not

found when logging why a subsystem failed to start; GHPR#637 from cuiweixie

OpenBSD-Commit-ID: 42bc40dd6272b7f6726b069a8c4e16025a354056

2 weeks agoDon't install shim for AWK=awk.
Darren Tucker [Mon, 1 Jun 2026 08:26:31 +0000 (18:26 +1000)] 
Don't install shim for AWK=awk.

If configure finds an undadorned awk, don't install the shim to prevent
recursive calls to it.

2 weeks agoPass awk detected by configure to regress tests.
Darren Tucker [Mon, 1 Jun 2026 07:40:03 +0000 (17:40 +1000)] 
Pass awk detected by configure to regress tests.

Some platforms' basic awk don't have toupper, but other awks like nawk
or gawk do.  Pass the one found by configure through to the regress
tests, and make a wrapper for it so we don't need to modify any tests.

2 weeks agoUpdate LibreSSL test 4.3.1->4.3.2.
Darren Tucker [Mon, 1 Jun 2026 07:39:40 +0000 (17:39 +1000)] 
Update LibreSSL test 4.3.1->4.3.2.

2 weeks agoupstream: sk-usbhid: skip unsupported key types in read_rks()
djm@openbsd.org [Mon, 1 Jun 2026 05:49:20 +0000 (05:49 +0000)] 
upstream: sk-usbhid: skip unsupported key types in read_rks()

When enumerating resident keys, encountering a credential with an
unsupported COSE key type (not ES256 or EdDSA) caused the entire
enumeration to abort via goto out, discarding all valid keys.

Move the key type check before the per-credential allocation so
unsupported types can be skipped with continue instead. This
preserves all valid resident keys on the token.

Patch from Akhilesh Arora via GHPR657

OpenBSD-Commit-ID: b344a44ff97d26faf099b8e0cad72ad1e793ac0f

2 weeks agoupstream: Actually set pollfd.events correctly for socket type
djm@openbsd.org [Mon, 1 Jun 2026 05:40:13 +0000 (05:40 +0000)] 
upstream: Actually set pollfd.events correctly for socket type

channels; previously we were throwing away the events we computed if the
channel had a c->sock distinct from it's other read and write fds.
Fortunately, it appears that this case happens rarely, if ever.

Reported by Darafei Praliaskouski via GHPR660

OpenBSD-Commit-ID: d3f483b7919946c5649e8c697d5b927af35aac4b

2 weeks agoupstream: handle compiled-time unsupported options in servconf.h
djm@openbsd.org [Sun, 31 May 2026 13:12:07 +0000 (13:12 +0000)] 
upstream: handle compiled-time unsupported options in servconf.h

better; leave a zero placeholder variable so we don't have #ifdef around
their absence elsehwere in the tree

OpenBSD-Commit-ID: 9601de2c67042aacb0ea12ca424e67c092fa7801

2 weeks agodepend
Damien Miller [Sun, 31 May 2026 12:03:56 +0000 (22:03 +1000)] 
depend

2 weeks agoupstream: unit test for new servconf.[ch] code, including a basic
djm@openbsd.org [Sun, 31 May 2026 11:39:44 +0000 (11:39 +0000)] 
upstream: unit test for new servconf.[ch] code, including a basic

fuzz test for deserialisation

OpenBSD-Regress-ID: f182c21485dc37a41a125f067b59bee48adbfe6c

2 weeks agoupstream: the new configuration dump code emits configuration
djm@openbsd.org [Sun, 31 May 2026 11:31:57 +0000 (11:31 +0000)] 
upstream: the new configuration dump code emits configuration

directives with capitalisation (previously they were all lowercase), so make
the tests that consume them insensitive to case

OpenBSD-Regress-ID: 9a81d8501b8b8fc1c1a0d268d4cc91cbb19668f5

2 weeks agoupstream: flesh out match_pattern() tests, including a new
djm@openbsd.org [Sun, 31 May 2026 04:20:58 +0000 (04:20 +0000)] 
upstream: flesh out match_pattern() tests, including a new

comparison test of the new NFA-based implementation against the original one
for all possible combinations of short inputs and patterns constructed from a
small dictionary of possibilities.

OpenBSD-Regress-ID: a18e86c95afb6243ac270468f5dd0ab4a78c8074

2 weeks agoupstream: big refactor of sshd config management code.
djm@openbsd.org [Sun, 31 May 2026 11:30:50 +0000 (11:30 +0000)] 
upstream: big refactor of sshd config management code.

This generates much of the initialisation, defaults and keyword table
code from a set of macros rather than hand coding them. These same
macros are also used to generate serialisation and deserialisation
code.

The macros are admittedly ugly but have the advantage of forcing a
good degree of consistency across places that need to stay in sync
with each other.

The new de/serialisation code is used to pass configurations across
the various sshd-* process boundaries. This removes the need to pass
around raw text configurations that need to be re-parsed as well as
eliminating some raw pointer leakage across the processes where
structures were previously clumsily serialised.

feedback/ok markus@

OpenBSD-Commit-ID: 9a5109a480637e08c290eeb82aa8ef2ca7e848ce

2 weeks agoupstream: avoid strlen(NULL) crash if an X11 channel was created before
djm@openbsd.org [Sun, 31 May 2026 06:14:42 +0000 (06:14 +0000)] 
upstream: avoid strlen(NULL) crash if an X11 channel was created before

the x11-req SSH_MSG_CHANNEL_REQUEST was sent. Reported by Ben Perry via
GHPR679

OpenBSD-Commit-ID: 31db0da9ab6c73e6bbf4021ffd53dc3ce5c65f23

2 weeks agoupstream: DNS0x20[1] can randomise the case of domain names returned by
djm@openbsd.org [Sun, 31 May 2026 05:55:21 +0000 (05:55 +0000)] 
upstream: DNS0x20[1] can randomise the case of domain names returned by

lookup to force some more uniqueness in queries to reduce the likelihood of
spoofing attacks succeeding.

Normally this should be hidden from the user by the resolver, but
in some cases it can leak through. When it does, it can mess up
ssh's CanonicalizePermittedCNAMEs.

Fix this by forcing the name we received from the system resolver to
lowercase.

bz3966, report and fix by Martin D Kealey

[1] https://datatracker.ietf.org/doc/html/draft-vixie-dnsext-dns0x20-00

OpenBSD-Commit-ID: e0b300d3b3af289e053d928380af71949f95bfb0

2 weeks agoupstream: disallow use of the copy-data extension to read and write
djm@openbsd.org [Sun, 31 May 2026 04:59:51 +0000 (04:59 +0000)] 
upstream: disallow use of the copy-data extension to read and write

to the same inode simultaneously; reported by Qifan Zhang of Palo Alto
Networks; ok markus@

OpenBSD-Commit-ID: 94ceb85146d92dbc1289c55d308498d5f56f274a

2 weeks agoupstream: Fix two separate one-byte out-of-cound reads
djm@openbsd.org [Sun, 31 May 2026 04:51:45 +0000 (04:51 +0000)] 
upstream: Fix two separate one-byte out-of-cound reads

1) if a server sent an empty reply to a SSH2_FXP_REALPATH request
2) if a batch command used the full 2048 byte buffer but ended in a
  literal backslash character

Both reported by Zhenpeng (Leo) Lin from depthfirst

ok markus@

OpenBSD-Commit-ID: d1ccc1f5a6eb109065ce8a552fea8e502381ce59

2 weeks agoupstream: DisableForwarding=yes didn't override PermitTunnel=yes
djm@openbsd.org [Sun, 31 May 2026 04:47:29 +0000 (04:47 +0000)] 
upstream: DisableForwarding=yes didn't override PermitTunnel=yes

Reported independently by Huzaifa Sidhpurwala of Redhat and Marko
Jevtic; ok markus@

OpenBSD-Commit-ID: b5c13f0746cf079b21f8deba47407fad49ccbf4c

2 weeks agoupstream: make the transport protocol stricter by disconnecting if
djm@openbsd.org [Sun, 31 May 2026 04:44:38 +0000 (04:44 +0000)] 
upstream: make the transport protocol stricter by disconnecting if

the peer sends non-KEX messages during a key re-exchange.

Previously an evil peer could continue sending non-KEX messages
without penalty, causing memory to be wasted up until the
connection terminated or the server/client hit a OOM limit.

reported by Marko Jevtic; ok markus@

OpenBSD-Commit-ID: 8937f0f2096156f5c68ae2dce77956373589d757

2 weeks agoupstream: stricter validation of the transport state passed from
djm@openbsd.org [Sun, 31 May 2026 04:37:56 +0000 (04:37 +0000)] 
upstream: stricter validation of the transport state passed from

the unprivileged preauth sshd-auth process to the user-privileged postauth
sshd-session process.

These are harmless unless an attacker had an exploit for sshd-auth
in which case they could be used for post-auth memory DoS or to
crash you own session in a new and exciting way.

Reported by bylee3 and Kayky Vinicius

ok markus

OpenBSD-Commit-ID: 214e256904a4ae4f83d2083096796c9689c1d7b5

2 weeks agoupstream: Enforce a maximum size for usernames in agent key use
djm@openbsd.org [Sun, 31 May 2026 04:31:04 +0000 (04:31 +0000)] 
upstream: Enforce a maximum size for usernames in agent key use

constraints

Along with the match_pattern() performance change that was just
committed this avoids a denial-of-service where an agent client could
waste CPU on an agent by sending user constraints with lots of
wildcards.

Reported by Huzaifa Sidhpurwala of Redhat

ok markus

OpenBSD-Commit-ID: 0483817f1a8accf4dbff42b7073ee4d119105d71

2 weeks agoupstream: fix client use-after-free on error path if cipher_init()
djm@openbsd.org [Sun, 31 May 2026 04:24:39 +0000 (04:24 +0000)] 
upstream: fix client use-after-free on error path if cipher_init()

fails; reported by Qualys Security Advisory Team, ok markus@

OpenBSD-Commit-ID: a8731da0c462b2b9d11314ba505c26ee0cdada83

2 weeks agoupstream: Replace the old recursive match_pattern() with an
djm@openbsd.org [Sun, 31 May 2026 04:19:16 +0000 (04:19 +0000)] 
upstream: Replace the old recursive match_pattern() with an

implementation that uses a NFA for matching. This avoids the exponential
worst- case behaviour for the old implementation.

ok markus@

OpenBSD-Commit-ID: fc6b75a52f4c0acb52b7900658c8d25ff873cbae

2 weeks agoMake failure to set SECCOMP or NO_NEW_PRIVS fatal
Damien Miller [Sat, 30 May 2026 13:24:01 +0000 (23:24 +1000)] 
Make failure to set SECCOMP or NO_NEW_PRIVS fatal

If your Linux system lacks support for these then please don't
enable the seccomp sandbox.

Prompted by manfred.kaiser@ssh-mitm.at

2 weeks agosandbox-seccomp-filter: remove duplicate SC_ALLOW(__NR_clock_gettime64)
Manfred Kaiser [Sun, 24 May 2026 07:53:42 +0000 (09:53 +0200)] 
sandbox-seccomp-filter: remove duplicate SC_ALLOW(__NR_clock_gettime64)

The syscall is already permitted at line 297 in its own ifdef guard.
No functional change.

2 weeks agoupstream: Use the new RELINK feature in bsd.prog.mk to build the
deraadt@openbsd.org [Wed, 27 May 2026 13:57:26 +0000 (13:57 +0000)] 
upstream: Use the new RELINK feature in bsd.prog.mk to build the

relink kits.

OpenBSD-Commit-ID: df5c950444e208b320265fa8a1afd676e2edfa6e

2 weeks agoupstream: ssh: use sentinel idiom for timegm(3) and mktime(3)
tb@openbsd.org [Wed, 27 May 2026 13:54:15 +0000 (13:54 +0000)] 
upstream: ssh: use sentinel idiom for timegm(3) and mktime(3)

There is nothing wrong with times before the epoch, even -1, so use the
idiom recently added to the CAVEATS section to figure out whether there
was an error in the timegm() or mktime() calls.

We should sweep the tree for this. If anyone is bored, feel free to beat
me to it...

ok deraadt djm

OpenBSD-Commit-ID: e2b1721966dc782e776db5d6cfb18958534f9d4b

2 weeks agoupstream: ssh-agent: add -V to usage()
tb@openbsd.org [Wed, 27 May 2026 03:28:07 +0000 (03:28 +0000)] 
upstream: ssh-agent: add -V to usage()

ok djm

OpenBSD-Commit-ID: ea9bc250ce34c4c8317896673ca37f3ee17223c7

2 weeks agoupstream: use "ssh-agent -V" to test the binary is functional after
djm@openbsd.org [Wed, 27 May 2026 03:05:21 +0000 (03:05 +0000)] 
upstream: use "ssh-agent -V" to test the binary is functional after

relinking requested deraadt@

OpenBSD-Commit-ID: eb4169949bf61188fb7336b11b73833019d10d7b

2 weeks agoupstream: add a -V flag to print the version, but mostly as a way
djm@openbsd.org [Wed, 27 May 2026 03:04:30 +0000 (03:04 +0000)] 
upstream: add a -V flag to print the version, but mostly as a way

to check the binary is functional; ok deraadt@

OpenBSD-Commit-ID: 0cc5cb22cbfe09ac4c316dd5da0af7a4193a42af

3 weeks agoupstream: Test all mutually supported algorithms,
dtucker@openbsd.org [Wed, 27 May 2026 23:04:36 +0000 (23:04 +0000)] 
upstream: Test all mutually supported algorithms,

using dropbear's new -Q option to query its algorithms where possible.

OpenBSD-Regress-ID: 7e1fa733dec3bfa9f8931e535a9397209b5953f3

3 weeks agoupstream: Dropbear recently added a -Q option;
dtucker@openbsd.org [Tue, 12 May 2026 13:02:40 +0000 (13:02 +0000)] 
upstream: Dropbear recently added a -Q option;

use it to query KEX if available.

OpenBSD-Regress-ID: beab781f357e27e75dfdd2ec600a7dff2c63cb5b

3 weeks agoupstream: Fix skip message.
dtucker@openbsd.org [Mon, 4 May 2026 10:57:24 +0000 (10:57 +0000)] 
upstream: Fix skip message.

OpenBSD-Regress-ID: d192bbc19cc5914e64a3bb35a347eca0318729af

3 weeks agoRun hardenedmalloc test on ubuntu-latest.
Darren Tucker [Tue, 26 May 2026 00:48:19 +0000 (10:48 +1000)] 
Run hardenedmalloc test on ubuntu-latest.

Needed for newer clang that supports -std=c23.

3 weeks agoHardenedmalloc needs -std=c23 so build with clang.
Darren Tucker [Mon, 25 May 2026 23:33:51 +0000 (09:33 +1000)] 
Hardenedmalloc needs -std=c23 so build with clang.

3 weeks agoFix IPTOS_DSCP_VA fallback
Michael Forney [Thu, 21 May 2026 17:02:00 +0000 (03:02 +1000)] 
Fix IPTOS_DSCP_VA fallback

0x2c is the unshifted value, and was copied over from openbsd before
it was fixed to be 0xb0 in [0].

Source of discrepancy identified by Leah Neukirchen.

[0] https://cvsweb.openbsd.org/log/src/sys/netinet/ip.h#rev1.22

4 weeks agoAdd OpenBSD 7.9 test VM.
Darren Tucker [Thu, 21 May 2026 08:39:54 +0000 (18:39 +1000)] 
Add OpenBSD 7.9 test VM.

4 weeks agoAnother shell portability fix for Solaris.
Darren Tucker [Thu, 21 May 2026 08:38:47 +0000 (18:38 +1000)] 
Another shell portability fix for Solaris.

4 weeks agoUse backticks for shell portability w/ Solaris.
Darren Tucker [Thu, 21 May 2026 08:25:50 +0000 (18:25 +1000)] 
Use backticks for shell portability w/ Solaris.

4 weeks agoAdd interop tests against Dropbear >= 2020.79
Darren Tucker [Tue, 19 May 2026 08:37:26 +0000 (18:37 +1000)] 
Add interop tests against Dropbear >= 2020.79

4 weeks agoupstream: mention that compression could potentially leak
djm@openbsd.org [Thu, 21 May 2026 04:04:57 +0000 (04:04 +0000)] 
upstream: mention that compression could potentially leak

information about session contents (cf. the CRIME attack on TLS) if a
connection allows attacker- controlled traffic over it alongside trused
traffic. This might occur in some forwarding scenarios.

with deraadt@

OpenBSD-Commit-ID: 03d145cdbf3a8713e8309724b5c9a9b76c317749

4 weeks agoupstream: mention usefulness of request type allow/denylisting for
djm@openbsd.org [Thu, 21 May 2026 02:50:59 +0000 (02:50 +0000)] 
upstream: mention usefulness of request type allow/denylisting for

servers accepting untrusted clients

OpenBSD-Commit-ID: 8b991bd263b46374a8e73f02d05cdccca73ae520

4 weeks agoupstream: chacha: avoid -Wunterminated-string-initialization
tb@openbsd.org [Mon, 18 May 2026 04:14:57 +0000 (04:14 +0000)] 
upstream: chacha: avoid -Wunterminated-string-initialization

warning

The sizes of sigma[] and tau[] aren't used, so include a trailing NUL and
thereby avoid upsetting modern compilers about use of dangerous, valid C.

ok deraadt djm

OpenBSD-Commit-ID: 030a71ff16bb1e6135170c6507bc558eabe7345c

4 weeks agoupstream: avoid validating bad cipher or mac lists in config files
djm@openbsd.org [Wed, 13 May 2026 05:58:58 +0000 (05:58 +0000)] 
upstream: avoid validating bad cipher or mac lists in config files

/ commandline arguments as valid.

Identified by SUSE and reported by Camila Camargo de Matos

ok deraadt@ tb@

OpenBSD-Commit-ID: 45d51154f2418549e08b80fa33df6c6532046054

5 weeks agoupstream: fix hard-to-reach NULL deref during pubkey auth
djm@openbsd.org [Wed, 13 May 2026 05:11:02 +0000 (05:11 +0000)] 
upstream: fix hard-to-reach NULL deref during pubkey auth

To hit this, the user must be using a PEM style private key with no
corresponding .pub key adjacent to it.

OpenBSD-Commit-ID: b7150acc5322fa33f21491834d9471fbe3d30f20

5 weeks agoRetire OmniOS r151046 & r151054 test configs.
Darren Tucker [Tue, 12 May 2026 09:53:54 +0000 (19:53 +1000)] 
Retire OmniOS r151046 & r151054 test configs.

They require packages from an external mirror which has been unreliable
lately, so stop relying on it.

5 weeks agoHandle missing packages for FreeBSD 12.4.
Darren Tucker [Tue, 12 May 2026 09:43:48 +0000 (19:43 +1000)] 
Handle missing packages for FreeBSD 12.4.

(Most) FreeBSD mirrors no longer have packages for 12.x, so install the
only thing we need (sudo) from source on.

5 weeks agoOmniOS: check for gcc before installing.
Darren Tucker [Tue, 12 May 2026 08:50:20 +0000 (18:50 +1000)] 
OmniOS: check for gcc before installing.

5 weeks agoAdd VM test versions for : OmniOS and FreeBSD.
Darren Tucker [Tue, 12 May 2026 08:05:24 +0000 (18:05 +1000)] 
Add VM test versions for : OmniOS and FreeBSD.

Add OmniOS r151056 and r151058 (with build-essentials, so hopefully
faster and lower dependency) and FreeBSD 12.4 for better coverage.

5 weeks agoupdate getrrsetbyname.c from OpenBSD upstream
Damien Miller [Tue, 12 May 2026 04:36:27 +0000 (14:36 +1000)] 
update getrrsetbyname.c from OpenBSD upstream

revision 1.15
date: 2026/05/09 01:54:51;  author: tb;  state: Exp;  lines: +14 -13;  commitid: zZPVUWycKAslGJtO;
Avoid recursive cleanup in getrrsetbyname()

Instead of freeing struct dns_query and struct dns_rr by walking the
linked lists recursively, use a simple loop. This avoids a possible
stack exhaustion unlikely to be reachable with the limits modern
resolvers impose.

From Dhiraj Mishra

5 weeks agoci: avoid rsync dependency in NetBSD VM jobs
Darafei Praliaskouski [Sat, 9 May 2026 15:50:31 +0000 (19:50 +0400)] 
ci: avoid rsync dependency in NetBSD VM jobs

6 weeks agoupstream: unbreak; spotted by Darren's test army
djm@openbsd.org [Tue, 5 May 2026 06:21:14 +0000 (06:21 +0000)] 
upstream: unbreak; spotted by Darren's test army

OpenBSD-Commit-ID: e95ceda842a2c7a08fc00ac3a529877d87fee7b2

6 weeks agoupstream: classify dynamic-tcpip channels as bulk, not interactive;
djm@openbsd.org [Tue, 5 May 2026 05:34:27 +0000 (05:34 +0000)] 
upstream: classify dynamic-tcpip channels as bulk, not interactive;

bz3958, ok markus@

OpenBSD-Commit-ID: b18f1c1eaff8423bf069ff6103e8865cec18d64b

6 weeks agoImprove NetBSD PAM tests.
Darren Tucker [Mon, 4 May 2026 13:33:57 +0000 (23:33 +1000)] 
Improve NetBSD PAM tests.

 - Set random password and use for password auth test.
 - When testing PAM builds, test with and without UsePAM.

6 weeks agoImprove FreeBSD PAM tests.
Darren Tucker [Mon, 4 May 2026 13:15:05 +0000 (23:15 +1000)] 
Improve FreeBSD PAM tests.

 - Set random password and use for password auth test.
 - When testing PAM builds, test with and without UsePAM.

6 weeks agoUpdate to FreeBSD 14.4, add 15.0.
Darren Tucker [Mon, 4 May 2026 12:57:58 +0000 (22:57 +1000)] 
Update to FreeBSD 14.4, add 15.0.

6 weeks agoImprove Solaris PAM tests.
Darren Tucker [Mon, 4 May 2026 11:40:52 +0000 (21:40 +1000)] 
Improve Solaris PAM tests.

 - Set up and run tests with SUDO.
 - Set random password to use for password & kbdint auth tests.
 - Only run t-exec when re-testing with PAM, don't rerun unit tests.
 - When testing PAM builds, test with and without UsePAM.

6 weeks agoOnly run t-exec when re-testing with PAM.
Darren Tucker [Mon, 4 May 2026 11:39:01 +0000 (21:39 +1000)] 
Only run t-exec when re-testing with PAM.

There's no point rerunning unit tests.

6 weeks agoAdd Solaris 11.4-clang-19 test.
Darren Tucker [Mon, 4 May 2026 08:47:03 +0000 (18:47 +1000)] 
Add Solaris 11.4-clang-19 test.

6 weeks agoAdd RUN_ONLY_PLATFORM to run a subset of tests.
Darren Tucker [Mon, 4 May 2026 07:41:37 +0000 (17:41 +1000)] 
Add RUN_ONLY_PLATFORM to run a subset of tests.

6 weeks agoskip ("#if 0") strvisx and stravis
Damien Miller [Mon, 4 May 2026 06:05:34 +0000 (16:05 +1000)] 
skip ("#if 0") strvisx and stravis

we don't use the in OpenSSH and some compilers throw warnings
compiling them that break -Werror

7 weeks agoRemove 9.9 and 10.0 branches from build status page.
Darren Tucker [Thu, 30 Apr 2026 23:19:56 +0000 (09:19 +1000)] 
Remove 9.9 and 10.0 branches from build status page.

7 weeks agovm.yml: fix solaris PAM tests
Renaud Allard [Sat, 21 Mar 2026 18:23:04 +0000 (19:23 +0100)] 
vm.yml: fix solaris PAM tests

Add missing SSHD_CONFOPTS="UsePam yes" to the solaris PAM test
step so it actually tests PAM functionality instead of re-running
the default tests with a PAM-enabled binary.

7 weeks agoupstream: fiddle with mask after umask call and not before; avoids
djm@openbsd.org [Wed, 29 Apr 2026 22:22:10 +0000 (22:22 +0000)] 
upstream: fiddle with mask after umask call and not before; avoids

fortify warnings on android. bz3954

OpenBSD-Commit-ID: 82224426b2ee989c68f305caa50aa3d3b4993a84

7 weeks agoupstream: unveil the actual listening socket path and its directory
djm@openbsd.org [Tue, 28 Apr 2026 21:32:05 +0000 (21:32 +0000)] 
upstream: unveil the actual listening socket path and its directory

so it can be cleaned up at exit.

Reported by / tested by David Krause, ok markus@

OpenBSD-Commit-ID: b45d740e9a63dec0fad436ed78f6912b39f0cd53

7 weeks agoupstream: Clarify comment on what setting extended types for
job@openbsd.org [Mon, 20 Apr 2026 07:43:52 +0000 (07:43 +0000)] 
upstream: Clarify comment on what setting extended types for

channels does

OK djm@

OpenBSD-Commit-ID: fa035fb19b74571992fa3adca4396a4c572a7a8a

7 weeks agoAdd tracking for 10.3 branch.
Darren Tucker [Tue, 28 Apr 2026 23:14:31 +0000 (09:14 +1000)] 
Add tracking for 10.3 branch.

7 weeks agoRename obsd arm64 snapshot VM for consistency.
Darren Tucker [Mon, 27 Apr 2026 23:09:57 +0000 (09:09 +1000)] 
Rename obsd arm64 snapshot VM for consistency.

7 weeks agoupstream: Use supported hostkeyalgorithms specifically in
dtucker@openbsd.org [Mon, 27 Apr 2026 05:49:41 +0000 (05:49 +0000)] 
upstream: Use supported hostkeyalgorithms specifically in

sshd_config instead of supported key types, which is almost but not
completely correct.

OpenBSD-Regress-ID: 43c3b348576900f3e710bff5d6a87f0e803c5b3d