Merge pull request #17578 from rgacogne/fix-clang-tidy-newly-created-files

clang-tidy: Properly process newly created files

Merge pull request #17576 from karelbilek/kb/readmes

dnsdist: Fix build readme - link, meson, mac brew

Merge pull request #17556 from karelbilek/kb/doh-fix-doh

dnsdist: TCP multiplexer: update should reset ttd

Merge pull request #17575 from hector-cao/fix-armhf-build

dnsdist: fix build error on 32 bits systems (armhf, ...)

Merge pull request #17577 from arthurscchan/new-fuzzer-3

OSS-Fuzz: Add fuzzer targets dnsdist logic

ci: Fix `ValueError: I/O operation on closed file` in clang-tidy.py

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

clang-tidy: Properly process newly created files

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

OSS-Fuzz: Add fuzzer targets dnsdist logic

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>

dnsdist: Fix build readme - link, meson, mac brew

I have tested mac brew instructions on a fresh Mac VM.

Signed-off-by: Karel Bilek <kb@karelbilek.com>

dnsdist: fix build error on 32 bits systems (armhf, ...)

The YAML configuration field cache.size is a uint64_t, while
DNSDistPacketCache::CacheSettings::d_maxEntries is a size_t. On 32-bit
architectures (e.g. armhf) size_t is 32-bit, so the designated-initializer
assignment is a narrowing conversion, which clang rejects with
-Wc++11-narrowing. Cast explicitly to size_t.

Signed-off-by: Hector Cao <hector.cao@canonical.com>

Merge pull request #17572 from arthurscchan/new-fuzzer-2

OSS-Fuzz: Add new fuzzer for dns packet processing

fuzz_dnspacketroundtrip: Fix clang-tidy warnings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

fuzz: Build the new dnspacketroundtrip target with meson

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16518 from jsoref/codeql-pep8-first-argument-should-be-self

codeql PEP8 first argument should be self

Merge pull request #17569 from zeha/meson-dist

auth: initial meson dist script

Merge pull request #16702 from zeha/dynamic-mods

auth: meson: fix missing symbols for dynamic backends

Merge pull request #17571 from jsoref/use-ubuntu-keyserver

docs: replace mit keyserver with ubuntu

Merge pull request #17573 from miodvallat/rcpeit

auth: minor SVCB record parsing fixes

Merge pull request #17562 from miodvallat/whereami

auth: stricter LOC record parsing

Do not assume char is unsigned when parsing SVCB records off the wire.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

ci: Add action to check for "self"

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `classmethod` ClientSubnetOption.from_wire

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `classmethod` ClientSubnetOption.from_wire

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `classmethod` CookiesOption.from_wire

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `classmethod` ExtendedErrorOption.from_wire

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `classmethod` PaddingOption.from_wire

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.NoSVCCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.NoUpgradePathCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoTCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoHCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoTDifferentAddr1Callback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoTDifferentAddr2Callback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoTUnreachableCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.BrokenResponseCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoHMissingPathCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.EOFCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.ServFailCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.WrongNameCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.WrongIDCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.TooManyQuestionsCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.BadQNameCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoTNoPortCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestBackendDiscovery.UpgradeDoHNoPortCallback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestOutgoingDOHBrokenResponsesOpenSSL.callback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestOutgoingDOHBrokenResponsesGnuTLS.callback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` TestOutgoingDOHXForwarded.callback

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Mark `staticmethod` KeepOpenTCPTest.sendTCPQueryKeepOpen

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

Move range checks before actual computations.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

OSS-Fuzz: Add new fuzzer for dns packet processing

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>

docs: replace mit keyserver with ubuntu

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

auth: initial meson dist script

Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>

Merge pull request #17563 from zeha/auth-meson-version-stopgap

auth: set version in meson.build in autoconf make dist path

auth: set version in meson.build in autoconf make dist path

Stopgap until auth switches to meson dist.

Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>

Merge pull request #17560 from rgacogne/ddist-action-by-name

dnsdist: Add "ByName" support for YAML actions

Merge pull request #17559 from rgacogne/ddist-fix-named-and-or-not-selectors

dnsdist: Fix naming And, Or and Not selectors, Continue action from YAML

Merge pull request #17387 from esensar/feature/mmdbkvstore

dnsdist: add MMDB KV store

Put LOC default values in member initializers.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Rewrite the LOC parser with something more strict and more readable.

The existing code was copied from the LOC RFC.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

dnsdist: Tell ruff to shup up

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Add "ByName" support for YAML actions

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #17549 from karelbilek/kb/doh-fix-dohtobackend

dnsdist: don't close DoH on timeout, do on release

dnsdist: Fix naming Continue action from YAML

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix naming And, Or and Not selectors from YAML

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #17535 from omoerbeek/rec-priv-ywh-250-ws-rust-origin

rec: only set ACCESS_CONTROL_ALLOW_ORIGIN if auth succeeded (#YWH-PGM-6095-250)

Merge pull request #17554 from omoerbeek/protozero-order

protozero: extend test to determine endianess

dnsdist: remove unused iostatehandler add function

Signed-off-by: Karel Bilek <kb@karelbilek.com>

dnsdist: TCP multiplexer: update should reset ttd

Fixes #17555

Signed-off-by: Karel Bilek <kb@karelbilek.com>

Merge pull request #17547 from arthurscchan/add-new-fuzzer

OSS-Fuzz: Add new fuzzer targets record handling

dnsdist: don't close DoH on timeout, do on release

Currently, dnsdist closes outgoing DoH on receive
timeout, instead of keeping TCP connection alive.

On the other hand, when DoH max idle time is
reached, the connection is not closed properly and
the filedescriptor is not properly closed.

The second issue was hard to reach before, as
cleanup interval would need to be lower than TCP
read timeout.

There is a new testcase for this, which needed
slight refactor of test DoH threads.

Signed-off-by: Karel Bilek <kb@karelbilek.com>

protozero: extend test to determine endianess

By using symbols defined by modern compilers

Merge pull request #17550 from rgacogne/auth-fix-meson-build_root-warning

auth: Fix deprecated "meson.build_root" warning

Merge pull request #17553 from zeha/auth-meson-test

auth: meson: avoid having boost_test_framework in all programs

auth: meson: avoid having boost_test_framework in all programs

Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>

Merge pull request #17551 from manuelm/master

auth: declare enable-lua-record-updates unconditionally

Update pdns/auth-main.cc

fix comment.

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
Signed-off-by: Manuel Mausz <manuel@mausz.at>

auth: declare enable-lua-record-updates unconditionally

The Lua record update restrictions added in #17131 rely on the
enable-lua-record-updates setting. When built without Lua record support,
this setting is not defined, causing errors like:

Undefined but needed argument: 'enable-lua-record-updates'

Add the setting unconditionally.

Signed-off-by: Manuel Mausz <manuel@mausz.at>

fuzzing: Silence clang-tidy warning about a global variable we don't control

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

auth: Fix deprecated "meson.build_root" warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

fuzzing: Fix formatting of the recordcontent target

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

fuzzing: Fix clang-tidy warnings in the recordcontent target

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

fuzzing: Build the new recordcontent target with meson

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: add a wrapper type for `MMDBQueryParams` to prevent misuse

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: simplify MMDB functions to always accept vector

The variant with just string is really just to make for an easier user
interface, but MMDB is not used directly, only through Lua functions or
KVS, so this keeps the same interface, but less branching in MMDB code.

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add more types in mmdb tests

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add top level access test for MMDB

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add MMDB regression tests with complex object access

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: Fix one more clang-tidy warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix clang-tidy warnings for the new MMDB code

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: add basic MMDB guide in docs

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: move MMDB feature flag to `mmdb.hh`

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: feature flag "mmdb.hh" include in YAML conf

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add MMDB Lua and YAML variant tests

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: fix ordering of MMDB related imports

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: expect MMDBKV in spell checker

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: accept strings in `MMDB:query` and `MMDB:exists` for easier use

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add MMDB docs

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add basic MMDB regression tests

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add mmdb to YAML configuration

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: add mmdb functions to console completion

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>

dnsdist: replace specific MMDB queries with a single generic query

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>