Merge pull request #16428 from rgacogne/ddist-yaml-rules

dnsdist: Expose `TimedIPSet` to YAML-originated Lua contexts

Fix tests using ANY queries

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Force outgoing ANY queries to use TCP by default

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Change default of recursor.any_to_tcp to true

This is the client side handling.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Prevent missing mdb_env_close in error paths in upgradeToSchemav5.

Using unique_ptr guards as used in getSchemaVersionAndShards, we can
guarantee that there will be no missing calls, regardless of how we
exit the function (which swears^Wthrows a lot).

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

rec: make webserver work without an API key

Currently, recursor web server doesn't work if API key is not set, even
when the API key is not actually used in the webserver auth.

Signed-off-by: Karel Bilek <kb@karelbilek.com>

rec: Build our Rust lib in dev profile when CARGO_USE_DEV is set

Adapted from #16544

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Recognize Accept: */* when deciding which content type to use for replies.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16538 from famfo/nixos-is-cursed

m4/pdns_check_libcrypto: fix ecdsa/eddsa includedir

dnsdist: Report the proper Lua function when parsing fails

It looks like we copy/pasted the `addDynBlockSMT` name when calling
the parser from the `addDynamicBlock` function.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Build our Rust lib in `dev` profile when `CARGO_USE_DEV` is set

It is roughly halving the compile time in my tests, and comes
with more checks (see https://doc.rust-lang.org/cargo/reference/profiles.html#dev)
so I find it useful to be able to explicitly request building
using the `dev` profile. The default remains to build in `release`
mode for performance, of course.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16447 from jsoref/codeql-quality-unused-imports

chore: Remove first set of unused imports

Merge pull request #16539 from famfo/acl-mask

pdns/sstuff: convert mapped IPv4 addresses for ACL

pdns/sstuff: convert mapped IPv4 addresses for ACL

When a mapped address does not get converted, ACLs do not match as
expected. For example ::ffff:127.0.0.1 did not match the ACL 127.0.0.1.

Signed-off-by: famfo <famfo@famfo.xyz>

Merge pull request #16517 from miodvallat/path

auth regress: Fix PDNS_BUILD_PATH for non-meson builds

Merge pull request #16536 from rgacogne/ddist-inc-number-of-fd

dnsdist: Raise the maximum number of descriptors to 1M

Fix PDNS_BUILD_PATH for non-meson builds.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16496 from omoerbeek/rec-tcounters-tidy

rec: Tidy tcounter related code

m4/pdns_check_libcrypto: fix ecdsa/eddsa includedir

On more excotic Linux distributions, like NixOS, the directory in which
the libraries are stored and the directory of the headers is different.
This uses pkg-config to find the right includedir of the headers.

Signed-off-by: famfo <famfo@famfo.xyz>

dnsdist: Raise the maximum number of descriptors to 1M

When running under systemd there is a cap on the number of open file or
socket descriptors that we can have at a given time. We used to set this
to 16k which was a large enough value for most installations, but now that
people are deploying DNSdist to offer DoT/DoH/DoQ/DoH3 to large numbers of
users we are regularly getting complaints that the default value is too low.
On the other hand I'm not aware of any case where having a cap actually
prevented an issue where we would be opening too many descriptors.
Therefore this commit is raising the default value to 1 millions, a large
enough values for even very large setups dealing with > 100k incoming
connections at a time.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16531 from jsoref/spelling

Spelling

spelling: work

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: will

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: where the query was sent

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsupported

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unknown

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transition

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: to

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: threshold

https://clang.llvm.org/extra/clang-tidy/checks/bugprone/easily-swappable-parameters.html#cmdoption-arg-NamePrefixSuffixSilenceDissimilarityThreshold

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: the

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: that

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: that the

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: system

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: successfully

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: successful

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: structure

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: stream

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: still

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: stepped

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: should

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: settings

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: setting

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: separate

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: sanitize

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: response

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: representation

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: record

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: qtype

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: prometheus

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: produce

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: process

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: private key file

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: preferably

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: preamble

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: possible

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: possibility

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: over

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: over other

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: only

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: on which the query was received

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: occurrences

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: occurred

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: necessarily

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: metadata

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: message

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: match, the

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: macos

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: locked

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: locally

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: in which the product was compiled

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: hsm

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: have implemented

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: happens

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: guaranteed

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: get

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: from which the query was received

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: from which the query is coming

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: freshness

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: forwards-and

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: forward-it

https://github.com/llvm/llvm-project/blob/c41f64239954b55468e44e6a6c92c1b4d2a1d8fe/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp#L55

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: for

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: expression

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: exercise

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: exception

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: exception,

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: example

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: every time

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: defaultttl

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: default

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: cyber.gouv.fr

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: covering

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: could

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: corresponding

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: contains

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: contain

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: blocked

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: badalg

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: autoprimary

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: arguments

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>