spelling: cyber.gouv.fr

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: covering

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: could

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: corresponding

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: contains

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: contain

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: blocked

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: badalg

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: autoprimary

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: arguments

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: arecvtcp

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: answer

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: and

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: and the

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: an

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: aggressive

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: aggregation

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: address

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: absence

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: "a"

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16529 from rgacogne/codeql-v4

chore(codeql): Upgrade to CodeQL v4

Merge pull request #16530 from jsoref/codeql-mixed-implicit-and-explicit-returns

Fix mixed implicit and explicit returns

spelling: , depending on the configuration,

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Make AggressiveNSECCacheBase.getMetric return int

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use TestCase.fail() instead of .assertFalse(True)

https://docs.python.org/3/library/unittest.html#unittest.TestCase.fail

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use TestCase.fail() instead of .assertTrue(False)

https://docs.python.org/3/library/unittest.html#unittest.TestCase.fail

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Make RecursorTest.killProcess always return void

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Make getCookieFromServer return None for self.fail

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

chore(codeql): Upgrade to CodeQL v4

See https://github.blog/changelog/2025-10-28-upcoming-deprecation-of-codeql-action-v3/

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16526 from jsoref/codeql-unused-global-variable

Remove unused assignment

Remove unused assignment

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16525 from rgacogne/ddist-avoid-comboaddr-parse

dnsdist: Change bogusV4/bogusV6 addresses to static constants to avoid parse in every call

Merge pull request #16515 from jsoref/codeql-redundant-assignment

Remove redundant assignment

Merge pull request #16516 from jsoref/codeql-unused-assignment

Remove unused assignment

Merge pull request #16523 from jsoref/coverallsapp-github-action-v2.3.7

Update to coverallsapp github-action v2.3.7

dnsdist: Change bogusV4/bogusV6 addresses to static constants to avoid parse in every call

Based on a patch by @delichick (thanks!).

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Update to coverallsapp github-action v2.3.7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Minor docs edit

Co-authored-by: Remi Gacogne <github@coredump.fr>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Avoid leak by using a smart pointer

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add a basic test and always produce HELP line even if text is not available

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Update documentation with getMetric's signature overload

Signed-off-by: Jess Bees <jesse@toomanybees.com>

Combine getMetric and initMetric

initMetric's signature is intentionally backwards compatible with getMetric,
so if there's no performance impact we can transparently combine their
functionality without breaking changes.

Signed-off-by: Jess Bees <jesse@toomanybees.com>

Nits

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Reformat some lines flagged by linter

Signed-off-by: Jess Bees <jesse@toomanybees.com>

dnsdist: FSF shenanigans

dnsdist: Add unit tests for the AF_XDP/XSK code

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Clarify AF_XDP/XSK flags

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix a bug when rewriting an IPv6 XSK packet

The header was not properly set.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Better handling of XSK frames without any data

This might happen when we are creating a frame from scratch.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Harden the XSK code

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Remove unused assignment

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Remove redundant assignment

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16510 from rgacogne/ddist-recvmmsg-performance

dnsdist: Better performance when using `recvmmsg`

dnsdist: Add dot to the end of a comment, as suggested by Miod

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16495 from jsoref/codeql-keyroller-non-callable-called

Remove horrible unused argument with default value

Merge pull request #16502 from jsoref/codeql-use-immediate-class-parent-for-super

Use immediate class parent for super

Merge pull request #16474 from pieterlexis/dnsdist-closer-optional

feat(dnsdist): Make creating Tracer::Closers less messy in calling code

chore(dnsdist): Suppress TSAN warning on InternalQueryState ctor

fix(dnsdist): Don't allocate strings before they are needed

Also make clang-tidy silent by ignoring the decay into pointer warnings

feat(dnsdist): Add `InternalQueryState::getRulesCloser`

Also use `__func__` to prevent typos in tracer function names.

fix(dnsdist): use RAII to set InternalQueryState::appliedRulesToQuery

feat(dnsdist): Add `getCloser` to InternalQueryState

This makes the code in dnsdist.cc easier to read, as it removes several
lines for each call to the OpenTelemetry tracing code.

feat(dnsdist): Add copy and move ctors for Tracer::Closer

feat(dnsdist): Allow setting Span Attributes from Closer

Merge pull request #16511 from rgacogne/ddist-xsk-packets-recv

dnsdist: Reuse the vector of packets between XSK recv rounds

dnsdist: Appease clang-tidy

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Use an `int` since it's what `recvmmsg` returns

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Reuse the vector of packets between XSK recv rounds

The existing code was allocating a new vector for every call
to `XskSocket::recv()` which was just silly.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16509 from jsoref/fix-codeql-use-with-open-as-file-to-ensure-file-is-always-closed

Fix `with open(...) as f:`

dnsdist: Better performance when using `recvmmsg`

`recvmmsg` and `sendmmsg` are Linux-specific syscalls to receive
and send multiple messages on a socket via a single call, which
in theory improves performance a lot, especially with the
speculative execution vulnerabilities mitigations making syscalls
expensive.
We had several reports that turning this feature on in DNSdist did
not really improve performance, which is quite unexpected. Looking
at a CPU profile in `perf`, we were spending an awful lot of time
resizing buffers that did not need to be resized most of the time
because they had not been used. This commit ensures that we only
resize and reset buffers for slots that have been used in the
previous round.

With that I'm getting a nice performance boost from using `recvmmsg`
and `sendmmsg` while processing 80k QPS at 100% cache-hit ratio
from a single thread: the CPU usage shrinks by roughly 15%.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Fix `with open(...) as f:`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16484 from jsoref/codeql-confusing-operator-precedence

Improve reading of operator expression

Merge pull request #16503 from rgacogne/dnsheader_aligned_no_copy

`dnsheader_aligned`: Prevent copies

Merge pull request #16504 from rgacogne/ddist-doq-handle-response

dnsdist: Clarify that our DoQ's `handleResponse` consumes the response

Merge pull request #16505 from rgacogne/ddist-modernize-pc-code

dnsdist: Apply clang-tidy recommendations to the packet cache code

dnsdist: Clarify that our DoQ's `handleResponse` consumes the response

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsheader_aligned: Prevent copies

The `dnsheader_aligned` object contains a pointer that references
either the `dnsheader` passed to the constructor if it is properly
aligned, or the internal `dnsheader` member. In the second case,
making a copy would mean we can reference an object that has been
destructed, which is a serious problem.

This commit also ensures copy elision is done `DNSQuestion:getHeader`,
as otherwise the compiler might refuse to compile.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Apply clang-tidy recommendations to the packet cache code

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16500 from jsoref/codeql-use-with-open-as-file-to-ensure-file-is-always-closed

Use `with open(...) as f:` to ensure file is always closed

Merge pull request #16501 from jsoref/codeql-explicitly-return

Stop mixing implicit and explicit returns

Specify immediate class parent

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Fix class name

- #14593 renamed the class but failed to update the super call

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Change `to_wire` to not mix explicit and implicit returns

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Return void

And omit `;` as python does not really believe in them

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Return void

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Use `with open(...) as f:` to ensure file is always closed

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Merge pull request #16494 from jsoref/codeql-unused-loop-iterator-name

Codeql unused loop iterator name

Typos in comments

Co-authored-by: Remi Gacogne <github@coredump.fr>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16497 from omoerbeek/rec-coverity-20251113

rec: fix coverity 1635199, 1643012, 1643013

Merge pull request #16498 from jsoref/codeql-use-identifiers

Codeql use identifiers

Merge pull request #16490 from jsoref/codeql-do-not-mutate-default-values

Do not mutate default values

Merge pull request #16491 from jsoref/codeql-only-import-module-once

Only import doqclient once

Merge pull request #16493 from jsoref/codeql-unused-argument-to-format

Drop unused format argument

Merge pull request #16492 from jsoref/codeql-imprecise-assert-not-equal

Use assertNotEqual

Merge pull request #16489 from jsoref/codeql-ignore-keyboardexception-and-sysexit

Do not catch `KeyboardInterrupt` or `SystemExit`

Merge pull request #16488 from jsoref/codeql-do-not-exit-with-void-return

Do not call `sys.exit` with a void return

Remove duplicated function

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Check results

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Disambiguate test functions in class

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>