]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
11 months agoterminal-util: rename openpt_allocate_* ret_peer argument
Jelle van der Waa [Thu, 15 May 2025 09:10:27 +0000 (11:10 +0200)] 
terminal-util: rename openpt_allocate_* ret_peer argument

Make it consistent with its implementation.

11 months agotpm2-util: correct argument comments
Jelle van der Waa [Thu, 15 May 2025 09:03:41 +0000 (11:03 +0200)] 
tpm2-util: correct argument comments

11 months agosd-varlink: fix argument comment
Jelle van der Waa [Thu, 15 May 2025 09:02:28 +0000 (11:02 +0200)] 
sd-varlink: fix argument comment

Follow-up for 52068c1e9c541038f1d7fd9a3a488feef0dcc35c

11 months agotpm2-util: rename tpm2_unseal arguments
Jelle van der Waa [Thu, 15 May 2025 08:58:52 +0000 (10:58 +0200)] 
tpm2-util: rename tpm2_unseal arguments

To make it consistent with its implementation.

11 months agohwdb: run "update-hwdb-autosuspend" 37470/head
Zbigniew Jędrzejewski-Szmek [Thu, 15 May 2025 08:47:40 +0000 (10:47 +0200)] 
hwdb: run "update-hwdb-autosuspend"

As usual, mostly additions and a few removals.

11 months agohwdb: run "update-hwdb"
Zbigniew Jędrzejewski-Szmek [Thu, 15 May 2025 08:46:26 +0000 (10:46 +0200)] 
hwdb: run "update-hwdb"

As usual, it seems to be mostly additions and corrections.

The last update was in 0d740f4bc0f03b773264ef75eaf1233ffc89c5b2, Dec 10th. I
think it's reasonable to update the hwdb more often. In particular, I want to
push an update to the stable branches, but it should be updated in 'main'
first.

11 months ago hwdb: append ID_MM_DEVICE_IGNORE to hwdb parser 37471/head
Nuno Sá [Thu, 15 May 2025 08:48:30 +0000 (09:48 +0100)] 
 hwdb: append ID_MM_DEVICE_IGNORE to hwdb parser

11 months agohwdb: add Analog Devices PLUTO SDR
Nuno Sá [Thu, 15 May 2025 08:46:16 +0000 (09:46 +0100)] 
hwdb: add Analog Devices PLUTO SDR

Add hwdb entries for ADI PLUTO. Note that when in DFU (Device Firmware
mode) mode, the pid is different. Thus, the two entries.

We also want to make sure that no AT commands are sent to us and so we
set 'ID_MM_DEVICE_IGNORE=1'.

11 months agoupdate TODO 37469/head
Lennart Poettering [Thu, 15 May 2025 07:53:30 +0000 (09:53 +0200)] 
update TODO

11 months agonetwork: do not drop duplicated entries in loop
Yu Watanabe [Wed, 14 May 2025 21:36:55 +0000 (06:36 +0900)] 
network: do not drop duplicated entries in loop

Fixes #37456.

11 months agocore: name socket unit instances after the socket cookie
Lennart Poettering [Thu, 15 May 2025 07:16:22 +0000 (09:16 +0200)] 
core: name socket unit instances after the socket cookie

On linux sockets have a really good, unique identifier, the SO_COOKIE,
which is used by sockdiag and BPF and elsewhere. Let's expose this more
prominently in the service name of per-connection services invoked via
Accept=yes sockets.

This is really nice, because together with our $SO_COOKIE env var we can
now match up services, process execution contexts, and "ss" outputs, BPF
rules, and more.

11 months agocore: pass the socket cookie to invoked per-connection service instances as $SO_COOKI...
Lennart Poettering [Thu, 15 May 2025 07:15:46 +0000 (09:15 +0200)] 
core: pass the socket cookie to invoked per-connection service instances as $SO_COOKIE env var

The socket cookie is just too useful for identifying connections, let's
emphasize this a bit and pass it as environment variable.

11 months agosocket-util: add trivial socket_get_cookie() helper
Lennart Poettering [Thu, 15 May 2025 07:15:10 +0000 (09:15 +0200)] 
socket-util: add trivial socket_get_cookie() helper

11 months agoman: correct version information when $REMOTE_ADDR/$REMOTE_PORT where added
Lennart Poettering [Thu, 15 May 2025 07:44:02 +0000 (09:44 +0200)] 
man: correct version information when $REMOTE_ADDR/$REMOTE_PORT where added

This was in commit 3b1c524154c876aecebc98787975cc2943100210, i.e. in the
v220 cycle.

11 months agoman: don't claim REMOTE_PORT= was initialized to the protocol for AF_RAW sockets
Lennart Poettering [Thu, 15 May 2025 07:06:52 +0000 (09:06 +0200)] 
man: don't claim REMOTE_PORT= was initialized to the protocol for AF_RAW sockets

This claim has no basis in reality, not even in the original commit
where the sentence was added this was true, see
3b1c524154c876aecebc98787975cc2943100210.

Hence removing.

11 months agobus-polkit: add a generic vtable for methods with no params, but with polkit 37466/head
Lennart Poettering [Thu, 15 May 2025 07:30:37 +0000 (09:30 +0200)] 
bus-polkit: add a generic vtable for methods with no params, but with polkit

11 months agocore: always handle method call params via sd_varlink_dispatch(), even if we accept...
Lennart Poettering [Thu, 15 May 2025 07:30:12 +0000 (09:30 +0200)] 
core: always handle method call params via sd_varlink_dispatch(), even if we accept none

This results in much more precise errors for the clients, and is what we
do everywhere else these days.

11 months agocore: always enable CPU accounting 37448/head
Mike Yuan [Mon, 14 Apr 2025 12:07:59 +0000 (14:07 +0200)] 
core: always enable CPU accounting

Our baseline is v5.4 and cgroup v2 is enforced now,
which means CPU accounting is cheap everywhere without
requiring any controller, hence just remove the directive.

11 months agoman: don't duplicate version in History section
Mike Yuan [Wed, 14 May 2025 18:33:22 +0000 (20:33 +0200)] 
man: don't duplicate version in History section

11 months agoman/systemd-run: --wait shows more than CPU accounting data
Mike Yuan [Wed, 14 May 2025 16:47:16 +0000 (18:47 +0200)] 
man/systemd-run: --wait shows more than CPU accounting data

11 months agosystemctl-show: drop BlockIO* property formatter
Mike Yuan [Wed, 14 May 2025 16:39:50 +0000 (18:39 +0200)] 
systemctl-show: drop BlockIO* property formatter

11 months agocore: drop Manager.blockio_accounting
Mike Yuan [Wed, 14 May 2025 16:36:16 +0000 (18:36 +0200)] 
core: drop Manager.blockio_accounting

Follow-up for 98d64ff5004b497a853e9058217c6eff46065fdb

11 months agocgtop: drop v1 support
Mike Yuan [Mon, 14 Apr 2025 12:07:44 +0000 (14:07 +0200)] 
cgtop: drop v1 support

11 months agomountpoint-util: remove unused TMPFS_LIMITS_SYS_FS_CGROUP
Mike Yuan [Wed, 14 May 2025 19:59:37 +0000 (21:59 +0200)] 
mountpoint-util: remove unused TMPFS_LIMITS_SYS_FS_CGROUP

Follow-up for 6801a9d88afe08648c70e2353b4be8ee04a871e3

11 months agocgroup-util: drop cg_kill() cgroup.threads kludge
Mike Yuan [Wed, 14 May 2025 20:23:09 +0000 (22:23 +0200)] 
cgroup-util: drop cg_kill() cgroup.threads kludge

Our baseline is v5.4 now.

11 months agoresolve: fix typo
Yu Watanabe [Wed, 14 May 2025 22:16:12 +0000 (07:16 +0900)] 
resolve: fix typo

Follow-up for 801ad6a6a9cd8fbd58b9f9c27f20dbb3c87d47dd.

11 months agoportable: Clean up includes 37467/head
Daan De Meyer [Wed, 14 May 2025 21:35:14 +0000 (23:35 +0200)] 
portable: Clean up includes

Split out of #37344.

11 months agocoredump: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:32:00 +0000 (23:32 +0200)] 
coredump: Clean up includes

Split out of #37344.

11 months agohibernate-resume: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:31:07 +0000 (23:31 +0200)] 
hibernate-resume: Clean up includes

Split out of #37344.

11 months agointegritysetup: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:28:54 +0000 (23:28 +0200)] 
integritysetup: Clean up includes

Split out of #37344.

11 months agolocale: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:26:58 +0000 (23:26 +0200)] 
locale: Clean up includes

Split out of #37344.

11 months agonsresourced: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:26:24 +0000 (23:26 +0200)] 
nsresourced: Clean up includes

Split out of #37344.

11 months agouserns-restrict: Move HAVE_VMLINUX check into functions
Daan De Meyer [Wed, 14 May 2025 21:23:31 +0000 (23:23 +0200)] 
userns-restrict: Move HAVE_VMLINUX check into functions

Let's do these checks like we try to do them elsewhere, in the
function, not outside. This avoids having to declare the function
arguments twice and keeps the logic for each function together
instead of spread out across the file.

11 months agomountfsd: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:19:02 +0000 (23:19 +0200)] 
mountfsd: Clean up includes

Split out of #37344.

11 months agonss: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:17:46 +0000 (23:17 +0200)] 
nss: Clean up includes

Split out of #37344.

11 months agoshutdown: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:15:25 +0000 (23:15 +0200)] 
shutdown: Clean up includes

Split out of #37344.

11 months agohashmap: Split out iterator.h
Daan De Meyer [Wed, 14 May 2025 20:59:06 +0000 (22:59 +0200)] 
hashmap: Split out iterator.h

As preparation for #37344, let's split out iterator.h so we can
avoid including the entirety of hashmap.h where it's not needed.

11 months agobusctl: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:11:19 +0000 (23:11 +0200)] 
busctl: Clean up includes

Split out of #37344.

11 months agopath: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:04:52 +0000 (23:04 +0200)] 
path: Clean up includes

11 months agotimedate: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:03:48 +0000 (23:03 +0200)] 
timedate: Clean up includes

Split out of #37344.

11 months agouserdb: Clean up includes
Daan De Meyer [Wed, 14 May 2025 21:03:23 +0000 (23:03 +0200)] 
userdb: Clean up includes

Split out of #37344.

11 months agouser-record: Make sure UserStorage enum has the same name as its typedef
Daan De Meyer [Wed, 14 May 2025 21:59:25 +0000 (23:59 +0200)] 
user-record: Make sure UserStorage enum has the same name as its typedef

11 months agotree-wide: Clean up includes (#37457)
Daan De Meyer [Wed, 14 May 2025 21:53:49 +0000 (23:53 +0200)] 
tree-wide: Clean up includes (#37457)

11 months agotree-wide: Clean up includes 37457/head
Daan De Meyer [Wed, 14 May 2025 20:22:11 +0000 (22:22 +0200)] 
tree-wide: Clean up includes

This commit cleans up the includes for all the small tools across
the tree.

A few cases of returning EXIT_SUCCESS are replaced with returning
0 to avoid including <stdlib.h>.

Split out of #37344.

11 months agotpm2-util: Make sure structs/enums are named and add to forward.h
Daan De Meyer [Wed, 14 May 2025 20:27:28 +0000 (22:27 +0200)] 
tpm2-util: Make sure structs/enums are named and add to forward.h

We have to name structs/enums to be able to forward declare them, so
let's do that and add the missing ones to forward.h.

11 months agonetworkd-util: Avoid call to endswith()
Daan De Meyer [Wed, 14 May 2025 19:41:43 +0000 (21:41 +0200)] 
networkd-util: Avoid call to endswith()

Instead of recalculating the length of the string again after
reading it, let's make sd_netlink_message_read_string() return the
length of the string that we then use to check if the last character
is a dot or not.

This allows us to get rid of the string-util.h include in #37344.

11 months agotest: fix assertion failure with CONFIG_UNIX_DIAG disabled
Luca Boccassi [Wed, 14 May 2025 19:02:34 +0000 (20:02 +0100)] 
test: fix assertion failure with CONFIG_UNIX_DIAG disabled

On OBS the build VM is heavily locked down, with network
disabled in various ways in the custom kernel, to isolate the
build, including disabling CONFIG_UNIX_DIAG.

[  456s] /* test_af_unix_get_qlen */
[  456s] src/test/test-socket-netlink.c:393: Assertion failed: Expected "af_unix_get_qlen(unix_fd, &q)" to succeed, but got error: No such file or directory

[  454s] /* test_sock_diag_unix */
[  454s] src/libsystemd/sd-netlink/test-netlink.c:727: Assertion failed: Expected "sd_netlink_call(nl, message, 0, &reply)" to succeed, but got error: No such file or directory

Follow-up for 89e546e927b8d1fb6b7d44d689586f949109f144
Follow-up for 4a3bf440f26c0577808c16da84a57f731c48eaeb

11 months agoserialize: Move some logic to the implementation file
Daan De Meyer [Wed, 14 May 2025 17:29:00 +0000 (19:29 +0200)] 
serialize: Move some logic to the implementation file

This will allow removing the string-util.h include in #37344.

11 months agovalidatefs: follow ups for recent change (#37447)
Yu Watanabe [Wed, 14 May 2025 19:25:28 +0000 (04:25 +0900)] 
validatefs: follow ups for recent change (#37447)

Follow-ups for #37434.

11 months agoBugprone argument comment - round 4 (#37380)
Yu Watanabe [Wed, 14 May 2025 18:36:16 +0000 (03:36 +0900)] 
Bugprone argument comment - round 4 (#37380)

Follow up from https://github.com/systemd/systemd/pull/37356

11 months agocapability-util: Ignore unknown capabilities instead of aborting
Daan De Meyer [Wed, 14 May 2025 16:46:58 +0000 (18:46 +0200)] 
capability-util: Ignore unknown capabilities instead of aborting

capability_quintet_mangle() can be called with capability sets
containing unknown capabilities. Let's not crash when this is the
case but instead ignore the unknown capabilities.

Fixes d5e12dc75e0e356c62e514e9c347efb200fe60e0

11 months agoSmall fixups after review for stable (#37442)
Yu Watanabe [Wed, 14 May 2025 18:30:41 +0000 (03:30 +0900)] 
Small fixups after review for stable (#37442)

11 months agoImprove hwdb boilerplate texts (#37440)
Yu Watanabe [Wed, 14 May 2025 18:29:53 +0000 (03:29 +0900)] 
Improve hwdb boilerplate texts (#37440)

11 months agovalidatefs: split out validating gpt label and type 37447/head
Yu Watanabe [Wed, 14 May 2025 17:34:18 +0000 (02:34 +0900)] 
validatefs: split out validating gpt label and type

No functional change, just refactoring.
This addresses https://github.com/systemd/systemd/pull/37434#discussion_r2088950725.

11 months agovalidatefs: drop unnecessary empty lines
Yu Watanabe [Wed, 14 May 2025 17:55:50 +0000 (02:55 +0900)] 
validatefs: drop unnecessary empty lines

11 months agoman: fix typo
Yu Watanabe [Wed, 14 May 2025 17:22:23 +0000 (02:22 +0900)] 
man: fix typo

Follow-up for 778cfac5fba45b7ac828571704945b722b2fb718.
Addresses https://github.com/systemd/systemd/pull/37434#discussion_r2088882005.

11 months agodiscover-image: Move some logic to the implementation file
Daan De Meyer [Wed, 14 May 2025 17:04:53 +0000 (19:04 +0200)] 
discover-image: Move some logic to the implementation file

This will allow removing the string-util.h and path-util.h includes
as part of #37344.

11 months agoforward: Add forward declaration for LockFile (#37445)
Daan De Meyer [Wed, 14 May 2025 17:55:18 +0000 (19:55 +0200)] 
forward: Add forward declaration for LockFile (#37445)

11 months agoCleanup up includes #1 (#37438)
Daan De Meyer [Wed, 14 May 2025 17:55:03 +0000 (19:55 +0200)] 
Cleanup up includes #1 (#37438)

11 months agoforward: Add forward declaration for LockFile 37445/head
Daan De Meyer [Wed, 14 May 2025 17:02:36 +0000 (19:02 +0200)] 
forward: Add forward declaration for LockFile

11 months agointegration-tests: several cleanups (#37394)
Yu Watanabe [Wed, 14 May 2025 16:45:10 +0000 (01:45 +0900)] 
integration-tests: several cleanups (#37394)

11 months agofundamental: assume that intmax_t is the biggest integer 37442/head
Zbigniew Jędrzejewski-Szmek [Wed, 14 May 2025 14:39:32 +0000 (16:39 +0200)] 
fundamental: assume that intmax_t is the biggest integer

Allowing intmax_t to be narrower than some other type in the assert
is rather strange. By definition, it is the widest type.

Follow-up for c0239e5f113335f49328286698d4a9f13fed983d.

11 months agosystemd-journald: drop pointless bitfield annotations
Zbigniew Jędrzejewski-Szmek [Wed, 14 May 2025 13:49:44 +0000 (15:49 +0200)] 
systemd-journald: drop pointless bitfield annotations

This actually doesn't change the struct size, because bools are coalesced
anyway. Also group the bool fields together.

11 months agoelf2efi: make code more pythonic
Zbigniew Jędrzejewski-Szmek [Wed, 14 May 2025 13:09:09 +0000 (15:09 +0200)] 
elf2efi: make code more pythonic

Follow-up for 53628612b75b444681fabc729ad7b012299c4c63.

With 'or', we ignore the empty string (but not '0'), and we only call
time.time() lazily. So this works the same as the code that is replaced,
but avoids the ugly repetition.

11 months agoMinor docs cleanups (#37439)
Luca Boccassi [Wed, 14 May 2025 16:16:05 +0000 (17:16 +0100)] 
Minor docs cleanups (#37439)

11 months agohwdb: say that settings can be also set to 0 37440/head
Zbigniew Jędrzejewski-Szmek [Wed, 14 May 2025 15:59:34 +0000 (17:59 +0200)] 
hwdb: say that settings can be also set to 0

We recommend that users create overriddes. This creates the problem that there
is no syntax to unset a property. Thus, the user needs to just set the property
to "something else" in the override file. But then the blurb saying that
"VAR=1" (or "VAR=0" in some cases) is the only allowed value can be confusing.
Say that both 0 and 1 can be set, since this documentation is also intended
for end users.

In our files, we generally don't want the override values anywhere. But we
have a test which checks the rvalue, which should be enough.

11 months agohwdb.d: update/expand boilerplate on various hwdb files
Zbigniew Jędrzejewski-Szmek [Wed, 14 May 2025 15:44:25 +0000 (17:44 +0200)] 
hwdb.d: update/expand boilerplate on various hwdb files

We don't want to encourage people to copy the whole files. The
boilerplate text that recommends an override file rather than a
full copy appeared first in 0213a26f656d72ac83eb201f2104726fcfe60eaa,
but was added in other places in 57bb707d48131f4daad2b1b746eab586eb66b4f3.

Directly inspired by 951e8cb06037d5b67c0ac86f56bcbd73f4fb2d7b, but
the wrong boilerplate was added in other places too.

11 months agohwdb.d: reword and simplify boilerplate texts
Zbigniew Jędrzejewski-Szmek [Wed, 14 May 2025 15:31:57 +0000 (17:31 +0200)] 
hwdb.d: reword and simplify boilerplate texts

Let's keep things simple and uniform. We put a dot at the
end of some commands… This is obviously correct, but might confuse
some poor user.

11 months agodocs/BOOT_LOADER_INTERFACE: minor grammar fixes 37439/head
Zbigniew Jędrzejewski-Szmek [Tue, 6 May 2025 19:04:00 +0000 (21:04 +0200)] 
docs/BOOT_LOADER_INTERFACE: minor grammar fixes

11 months agodocs: punctuation and a typo
Zbigniew Jędrzejewski-Szmek [Wed, 7 May 2025 13:08:46 +0000 (15:08 +0200)] 
docs: punctuation and a typo

11 months agovalidatefs: fix checks on file systems backed by multiple devices (i.e. verity) ...
Lennart Poettering [Wed, 14 May 2025 15:53:06 +0000 (17:53 +0200)] 
validatefs: fix checks on file systems backed by multiple devices (i.e. verity) (#37434)

Fixes #37157

11 months agovmspawn: Clean up includes 37438/head
Daan De Meyer [Wed, 14 May 2025 15:12:06 +0000 (17:12 +0200)] 
vmspawn: Clean up includes

Split out of #37344

11 months agoxdg-autostart-generator: Clean up includes
Daan De Meyer [Wed, 14 May 2025 15:10:53 +0000 (17:10 +0200)] 
xdg-autostart-generator: Clean up includes

Split out of #37344

11 months agosd-bus: Make sure sd_bus_error and sd_bus_error_map structs are named
Daan De Meyer [Wed, 14 May 2025 15:20:57 +0000 (17:20 +0200)] 
sd-bus: Make sure sd_bus_error and sd_bus_error_map structs are named

Otherwise we can't forward declare them.

Split out of #37344

11 months agohashmap: Make sure Iterator struct is named
Daan De Meyer [Wed, 14 May 2025 15:14:35 +0000 (17:14 +0200)] 
hashmap: Make sure Iterator struct is named

Otherwise we can't forward declare it.

Split out of #37344

11 months agostatic-destruct: Move static_destruct() logic to implementation file
Daan De Meyer [Wed, 14 May 2025 13:06:50 +0000 (15:06 +0200)] 
static-destruct: Move static_destruct() logic to implementation file

This will allow us to remove the memory-util.h include from
static-destruct.h as part of #37344.

11 months agoblockdev-util: Remove dependency on string-util.h
Daan De Meyer [Wed, 14 May 2025 13:33:36 +0000 (15:33 +0200)] 
blockdev-util: Remove dependency on string-util.h

Let's insist on a string literal in SYS_BLOCK_PATH_MAX() so that
we don't accidentally allocate VLAs and let's inline strempty() in
xsprintf_sys_block_path() so we don't need to include string-util.h
in blockdev-util.h

We'll remove the actual string-util.h include as part of #37344.

11 months agoIntroduce forward.h header with forward declarations (#37428)
Daan De Meyer [Wed, 14 May 2025 14:51:10 +0000 (16:51 +0200)] 
Introduce forward.h header with forward declarations (#37428)

In preparation for adopting forward declarations to reduce unnecessary
transitive includes across the tree, let's introduce a forward.h header
with forward declarations for all libc, libsystemd, basic and shared
types.

Additionally, this header exports all basic integer types and errno
constants, as well as all macros including assertions macros. These
header files contain types often used in headers and are always included
in every source file one way or another anyway.

To avoid having to include memory-util.h and alloc-util.h in forward.h,
we split off the parts we need from both into cleanup-util.h and only
include cleanup-util.h in forward.h.

To keep this commit self-contained, we include cleanup-fundamental.h and
cleanup-util.h from the headers that originally contained the same
macros. We'll remove these again in a later commit that optimizes the
includes in src/basic and src/fundamental.

Split out of #37364

11 months agoboot: Use DEFINE_TRIVIAL_CLEANUP_FUNC() to define strv_freep() 37428/head
Daan De Meyer [Wed, 14 May 2025 13:45:15 +0000 (15:45 +0200)] 
boot: Use DEFINE_TRIVIAL_CLEANUP_FUNC() to define strv_freep()

11 months agomount-util: add helper to get source from mountinfo
Luca Boccassi [Mon, 12 May 2025 17:19:02 +0000 (18:19 +0100)] 
mount-util: add helper to get source from mountinfo

11 months agovpick: add path_uses_vpick helper method
maia x. [Sat, 5 Oct 2024 21:27:32 +0000 (14:27 -0700)] 
vpick: add path_uses_vpick helper method

Add a path_uses_vpick helper method to determine if a path matches
the vpick format ('PATH/NAME.SUFFIX.v' or 'PATH.v/NAME___.SUFFIX'):

/* good: returns 1 */
path_uses_vpick("/var/lib/machines/mymachine.raw.v/")
path_uses_vpick("to.v/foo___.raw

/* bad: returns <= 0 */
path_uses_vpick("/")
path_uses_vpick("path/to/foo.mp4.vtt

11 months agomkosi: add socat to minimal-0/1 images
maia x. [Tue, 17 Dec 2024 22:24:02 +0000 (14:24 -0800)] 
mkosi: add socat to minimal-0/1 images

Include 'socat' as part of the tools built with minimal-0/minimal-1
images used for integration testing. This would allow notify-reload
services to signal reloading without using the systemd-notify tool
and other socket communication test cases.

Note that 'ncat', although included in the minimal image, cannot be
used because it dies before systemd can figure out the unit it's
from. See 67e5622bfe037603e47f38cf02e58d522b3c18f7.

11 months agotest: attempt to fix resolved wait-online testcase
Lennart Poettering [Wed, 14 May 2025 12:24:02 +0000 (14:24 +0200)] 
test: attempt to fix resolved wait-online testcase

Fixes: #37430
11 months agoci: extend validatefs testcase to validate verity partitions 37434/head
Lennart Poettering [Wed, 14 May 2025 12:24:51 +0000 (14:24 +0200)] 
ci: extend validatefs testcase to validate verity partitions

11 months agoman: document that gpt-label/gpt-type uuid xattrs are now lists
Lennart Poettering [Wed, 14 May 2025 12:36:09 +0000 (14:36 +0200)] 
man: document that gpt-label/gpt-type uuid xattrs are now lists

11 months agorepart: initialize validatefs xattrs to list *all* verity subordinate partitions
Lennart Poettering [Wed, 14 May 2025 10:35:52 +0000 (12:35 +0200)] 
repart: initialize validatefs xattrs to list *all* verity subordinate partitions

Now that we can actually list multiple gpt labels/type uuids in xattrs,
let's start doing so.

Fixes: #37157
11 months agovalidatefs: properly authenticate all subordinate devices of DM devices
Lennart Poettering [Wed, 14 May 2025 10:18:04 +0000 (12:18 +0200)] 
validatefs: properly authenticate all subordinate devices of DM devices

Previously, we'd only authenticate "one" of the subordinate devices of a
DM device, and which one was somewhat undefined, it would be what we
find in slaves/ first. This is in particular a problem with dm-verity
which generally has two subordinate devices: the data device and the
hash device.

Let's fix this properly. This means two things:

1. iterate through *all* subordinate devices of a DM device (i.e.
   iterate through the sysfs slaves/ subdir), not just
   one

2. permit configuring a list of gpt labels and gpt type uuids in the
   xattrs of mount points, so that all valid combinations can be listed.

This only updates the validation like this. The generation of xattrs
that carry multiple type uuids/labels in systemd-repart will follow in a
later commit.

This extends the syntax of the two gpt-related xattrs, to allow lists of
things. This is a true extension, without breaking compat (but even if
it was, it wouldn't matter given that validatefs was added post v257,
i.e. is not included in a stable release.

Fixes: #37157
11 months agoIntroduce forward.h header with forward declarations
Daan De Meyer [Tue, 13 May 2025 09:50:05 +0000 (11:50 +0200)] 
Introduce forward.h header with forward declarations

In preparation for adopting forward declarations to reduce unnecessary
transitive includes across the tree, let's introduce a forward.h header
with forward declarations for all libc, libsystemd, basic and shared types.

Additionally, this header exports all basic integer types and errno constants,
as well as all macros including assertions macros. These header files contain
types often used in headers and are always included in every source file one
way or another anyway.

To avoid having to include memory-util.h and alloc-util.h in forward.h, we
split off the parts we need from both into cleanup-util.h and only include
cleanup-util.h in forward.h.

To keep this commit self-contained, we include cleanup-fundamental.h and
cleanup-util.h from the headers that originally contained the same macros.
We'll remove these again in a later commit that optimizes the includes in
src/basic and src/fundamental.

Split out of #37364

11 months agovalidatefs: split out validate_fields_check() into three functions
Lennart Poettering [Wed, 14 May 2025 09:30:52 +0000 (11:30 +0200)] 
validatefs: split out validate_fields_check() into three functions

Just some basic refactoring, no actual code changes

11 months agoavoid race between systemd-logind and systemd-udevd in setting ACLs (#36444)
Lennart Poettering [Wed, 14 May 2025 11:03:46 +0000 (13:03 +0200)] 
avoid race between systemd-logind and systemd-udevd in setting ACLs (#36444)

Follow-up for #36408.
Hopefully fixes #24026, #28512, and/or #23547.

11 months agoAddress post-merge issues in the sysfail entry functionality (#37426)
Lennart Poettering [Wed, 14 May 2025 11:03:13 +0000 (13:03 +0200)] 
Address post-merge issues in the sysfail entry functionality (#37426)

11 months agofork-journal: some follow-ups (#37423)
Lennart Poettering [Wed, 14 May 2025 11:02:46 +0000 (13:02 +0200)] 
fork-journal: some follow-ups (#37423)

11 months agojournald: rename primary object from "Server" to "Manager"
Lennart Poettering [Wed, 14 May 2025 09:00:53 +0000 (11:00 +0200)] 
journald: rename primary object from "Server" to "Manager"

In all our daemons the primary entrypoint object is called "Manager".
But so far there was one exception: in journald it was called "Server".
Let's normalize that, and stick to the same nomenclature everywhere, to
make journald less special.

No real code change, just some search&replace.

11 months agosd-device: fix argument comment chase_flags 37380/head
Jelle van der Waa [Fri, 9 May 2025 13:47:00 +0000 (15:47 +0200)] 
sd-device: fix argument comment chase_flags

11 months agobasic: fix consistency of flags argument for chase and chaseat
Jelle van der Waa [Fri, 9 May 2025 13:42:26 +0000 (15:42 +0200)] 
basic: fix consistency of flags argument for chase and chaseat

Both functions have one flags argument, so we don't need to
rename them to `chase_flags`.

11 months agoshared/cred-util: fix argument comment for copy_file_at
Jelle van der Waa [Wed, 7 May 2025 17:53:18 +0000 (19:53 +0200)] 
shared/cred-util: fix argument comment for copy_file_at

11 months agoask-password-api: use flags consistently as argument name
Jelle van der Waa [Wed, 7 May 2025 17:34:11 +0000 (19:34 +0200)] 
ask-password-api: use flags consistently as argument name

11 months agotreewide: fix argument comment for getxattr_at_bool
Jelle van der Waa [Wed, 7 May 2025 17:22:31 +0000 (19:22 +0200)] 
treewide: fix argument comment for getxattr_at_bool

11 months agobasic: fix argument naming for vt_release
Jelle van der Waa [Wed, 7 May 2025 17:15:04 +0000 (19:15 +0200)] 
basic: fix argument naming for vt_release

11 months agohostname: use argument comment name transient_hostname
Jelle van der Waa [Wed, 7 May 2025 17:11:16 +0000 (19:11 +0200)] 
hostname: use argument comment name transient_hostname