]> git.ipfire.org Git - thirdparty/unbound.git/log
thirdparty/unbound.git
5 years agoTravis, fix quotes on config opts for iOS and Android configure.
W.C.A. Wijngaards [Wed, 24 Mar 2021 10:06:10 +0000 (11:06 +0100)] 
Travis, fix quotes on config opts for iOS and Android configure.

5 years agoTravis, debug print config opts.
W.C.A. Wijngaards [Wed, 24 Mar 2021 09:57:59 +0000 (10:57 +0100)] 
Travis, debug print config opts.

5 years agoTravis, fix script with steps and export variables and config opts.
W.C.A. Wijngaards [Wed, 24 Mar 2021 09:49:56 +0000 (10:49 +0100)] 
Travis, fix script with steps and export variables and config opts.

5 years agotravis, script at outer scope so failed lines fail build.
W.C.A. Wijngaards [Wed, 24 Mar 2021 09:42:03 +0000 (10:42 +0100)] 
travis, script at outer scope so failed lines fail build.

5 years agoremove debug output.
W.C.A. Wijngaards [Wed, 24 Mar 2021 09:31:46 +0000 (10:31 +0100)] 
remove debug output.

5 years agoAdd unistd include, and changelog note.
W.C.A. Wijngaards [Wed, 24 Mar 2021 09:22:37 +0000 (10:22 +0100)] 
Add unistd include, and changelog note.

5 years agoTravis, deprecation test also checks if item unavailable.
W.C.A. Wijngaards [Wed, 24 Mar 2021 09:15:24 +0000 (10:15 +0100)] 
Travis, deprecation test also checks if item unavailable.

5 years agoTravis, fix deprecation test to use CFLAGS and CPPFLAGS.
W.C.A. Wijngaards [Wed, 24 Mar 2021 09:07:18 +0000 (10:07 +0100)] 
Travis, fix deprecation test to use CFLAGS and CPPFLAGS.

5 years agoTravis, test deprecation configure output. Debug output from configure
W.C.A. Wijngaards [Wed, 24 Mar 2021 08:57:53 +0000 (09:57 +0100)] 
Travis, test deprecation configure output.  Debug output from configure
and remove a lot of timeconsuming tests temporarily.

5 years agoTravis, use config opts when testing on OSX.
W.C.A. Wijngaards [Tue, 23 Mar 2021 15:51:50 +0000 (16:51 +0100)] 
Travis, use config opts when testing on OSX.

5 years agoTravis, undo the && code and enable other iOS jobs.
W.C.A. Wijngaards [Tue, 23 Mar 2021 15:34:56 +0000 (16:34 +0100)] 
Travis, undo the && code and enable other iOS jobs.

5 years agoTravis, fix location of libexpat, stop on error.
W.C.A. Wijngaards [Tue, 23 Mar 2021 15:27:49 +0000 (16:27 +0100)] 
Travis, fix location of libexpat, stop on error.

5 years agoTravis, turn off homebrew update, and move to 12.2 for OSX compile.
W.C.A. Wijngaards [Tue, 23 Mar 2021 15:03:58 +0000 (16:03 +0100)] 
Travis, turn off homebrew update, and move to 12.2 for OSX compile.

5 years agoTravis, try to enable brew update for the 12.2 osx image.
W.C.A. Wijngaards [Tue, 23 Mar 2021 13:45:14 +0000 (14:45 +0100)] 
Travis, try to enable brew update for the 12.2 osx image.

5 years agoTravis, note changelog, disable homebrew update in script and cfg.
W.C.A. Wijngaards [Tue, 23 Mar 2021 13:22:00 +0000 (14:22 +0100)] 
Travis, note changelog, disable homebrew update in script and cfg.

5 years agotravis, analyzer disabled on test without debug, that does not
W.C.A. Wijngaards [Tue, 23 Mar 2021 12:38:46 +0000 (13:38 +0100)] 
travis, analyzer disabled on test without debug, that does not
run anway.  Turn off failing tests except one.  Update iOS test
to xcode image 12.2.

5 years agoTravis, attempt to omit ios brew update.
W.C.A. Wijngaards [Tue, 23 Mar 2021 08:29:11 +0000 (09:29 +0100)] 
Travis, attempt to omit ios brew update.

5 years agoTravis changelog noted.
W.C.A. Wijngaards [Tue, 23 Mar 2021 08:17:22 +0000 (09:17 +0100)] 
Travis changelog noted.

5 years agoTravis enable all tests again. Clang analyzer only a couple times, when
W.C.A. Wijngaards [Tue, 23 Mar 2021 07:56:42 +0000 (08:56 +0100)] 
Travis enable all tests again.  Clang analyzer only a couple times, when
there is a difference.  homebrew updates disabled, so it does not hang.
removed trailing slashes from configure paths.  Moved iOS tests to
allow-failure.

5 years ago- Reformat pythonmod/pythonmod_utils.{c,h}.
George Thessalonikefs [Mon, 22 Mar 2021 17:45:31 +0000 (18:45 +0100)] 
- Reformat pythonmod/pythonmod_utils.{c,h}.

5 years agoAsan tests shown to work, run OSX test.
W.C.A. Wijngaards [Mon, 22 Mar 2021 16:02:06 +0000 (17:02 +0100)] 
Asan tests shown to work, run OSX test.

5 years ago- Fix for #367: fix memory leak when cannot bind to listening port.
George Thessalonikefs [Mon, 22 Mar 2021 15:46:17 +0000 (16:46 +0100)] 
- Fix for #367: fix memory leak when cannot bind to listening port.

5 years agoTravis test for OSX, ASAN results.
W.C.A. Wijngaards [Mon, 22 Mar 2021 15:36:46 +0000 (16:36 +0100)] 
Travis test for OSX, ASAN results.

5 years ago- Fix memory leak reported by asan in rpz SOA record query name.
W.C.A. Wijngaards [Mon, 22 Mar 2021 14:29:34 +0000 (15:29 +0100)] 
- Fix memory leak reported by asan in rpz SOA record query name.

5 years ago- Fix compile error in listen_dnsport on Android.
W.C.A. Wijngaards [Mon, 22 Mar 2021 14:02:19 +0000 (15:02 +0100)] 
- Fix compile error in listen_dnsport on Android.

5 years agoMerge branch 'master' of github.com:NLnetLabs/unbound
W.C.A. Wijngaards [Mon, 22 Mar 2021 13:53:16 +0000 (14:53 +0100)] 
Merge branch 'master' of github.com:NLnetLabs/unbound

5 years ago- Comment out nonworking OSX and IOS travis tests, vm fails to start.
W.C.A. Wijngaards [Mon, 22 Mar 2021 13:53:05 +0000 (14:53 +0100)] 
- Comment out nonworking OSX and IOS travis tests, vm fails to start.

5 years agoAdd docs badge
Alex Band [Mon, 22 Mar 2021 13:35:30 +0000 (14:35 +0100)] 
Add docs badge

5 years ago- Fix unused-function warning when compiling with --enable-dnscrypt.
George Thessalonikefs [Mon, 22 Mar 2021 13:31:58 +0000 (14:31 +0100)] 
- Fix unused-function warning when compiling with --enable-dnscrypt.

5 years ago- rpz-triggers, remove unused variable warning.
W.C.A. Wijngaards [Mon, 22 Mar 2021 08:52:00 +0000 (09:52 +0100)] 
- rpz-triggers, remove unused variable warning.

5 years ago- rpz-triggers, function documentation comments for iterator callback
W.C.A. Wijngaards [Mon, 22 Mar 2021 08:49:22 +0000 (09:49 +0100)] 
- rpz-triggers, function documentation comments for iterator callback
  functions.

5 years ago- rpz-triggers, fix that after cname an nsdname or nsip trigger has cname
W.C.A. Wijngaards [Mon, 22 Mar 2021 08:42:04 +0000 (09:42 +0100)] 
- rpz-triggers, fix that after cname an nsdname or nsip trigger has cname
  rrsets prepended by the iterator.

5 years ago- rpz-triggers, call rpz callback only if there are auth zones configured.
W.C.A. Wijngaards [Mon, 22 Mar 2021 08:39:12 +0000 (09:39 +0100)] 
- rpz-triggers, call rpz callback only if there are auth zones configured.

5 years ago- iana portlist update.
W.C.A. Wijngaards [Mon, 22 Mar 2021 08:12:41 +0000 (09:12 +0100)] 
- iana portlist update.

5 years agoChangelog note for #449.
W.C.A. Wijngaards [Mon, 22 Mar 2021 07:57:01 +0000 (08:57 +0100)] 
Changelog note for #449.

5 years agoMerge pull request #449 from orbea/build
Wouter Wijngaards [Mon, 22 Mar 2021 07:56:43 +0000 (08:56 +0100)] 
Merge pull request #449 from orbea/build

build: Add missing linker flags.

5 years agobuild: Add missing linker flags. 449/head
orbea [Sun, 21 Mar 2021 23:28:58 +0000 (16:28 -0700)] 
build: Add missing linker flags.

5 years agoUpdate unbound-control.8.in, fix rpz_disable typo 448/head
Sven [Sat, 20 Mar 2021 13:28:10 +0000 (14:28 +0100)] 
Update unbound-control.8.in, fix rpz_disable typo

5 years ago- Fix for #447: squelch connection refused tcp connection failures
W.C.A. Wijngaards [Fri, 19 Mar 2021 16:43:36 +0000 (17:43 +0100)] 
- Fix for #447: squelch connection refused tcp connection failures
  from the log, unless verbosity is high.

5 years ago- rpz triggers, fix query name on trigger after cname.
W.C.A. Wijngaards [Fri, 19 Mar 2021 16:36:09 +0000 (17:36 +0100)] 
- rpz triggers, fix query name on trigger after cname.

5 years ago- rpz triggers, implement qname trigger after cname.
W.C.A. Wijngaards [Fri, 19 Mar 2021 16:31:44 +0000 (17:31 +0100)] 
- rpz triggers, implement qname trigger after cname.

5 years ago- Fix #441: Minimal NSEC range not accepted for top level domains.
W.C.A. Wijngaards [Wed, 17 Mar 2021 13:04:02 +0000 (14:04 +0100)] 
- Fix #441: Minimal NSEC range not accepted for top level domains.

5 years ago- rpz triggers, use tld name for tld pointer in suffix removal.
W.C.A. Wijngaards [Fri, 12 Mar 2021 15:07:37 +0000 (16:07 +0100)] 
- rpz triggers, use tld name for tld pointer in suffix removal.

5 years ago- rpz triggers, rpz_insert_rr nicer.
W.C.A. Wijngaards [Fri, 12 Mar 2021 13:35:34 +0000 (14:35 +0100)] 
- rpz triggers, rpz_insert_rr nicer.

5 years ago- rpz triggers, fix that nsdname suffix removal returns allocated memory
W.C.A. Wijngaards [Fri, 12 Mar 2021 13:32:10 +0000 (14:32 +0100)] 
- rpz triggers, fix that nsdname suffix removal returns allocated memory
  of the correct length and the correct dnamelen.

5 years ago- rpz triggers, document statistics and fix comment about statistics.
W.C.A. Wijngaards [Fri, 12 Mar 2021 12:24:17 +0000 (13:24 +0100)] 
- rpz triggers, document statistics and fix comment about statistics.

5 years ago- rpz triggers, fix to put braces around operator.
W.C.A. Wijngaards [Fri, 12 Mar 2021 12:13:17 +0000 (13:13 +0100)] 
- rpz triggers, fix to put braces around operator.

5 years agorpz triggers, man page fix end label
W.C.A. Wijngaards [Fri, 12 Mar 2021 09:23:20 +0000 (10:23 +0100)] 
rpz triggers, man page fix end label

5 years ago- rpz triggers, man page explanation of rpz zone contents.
W.C.A. Wijngaards [Fri, 12 Mar 2021 09:21:48 +0000 (10:21 +0100)] 
- rpz triggers, man page explanation of rpz zone contents.

5 years ago- rpz triggers, spelling fix.
W.C.A. Wijngaards [Fri, 12 Mar 2021 09:21:29 +0000 (10:21 +0100)] 
- rpz triggers, spelling fix.

5 years ago- rpz trigger, fix tcp only action after merge
W.C.A. Wijngaards [Fri, 12 Mar 2021 08:18:38 +0000 (09:18 +0100)] 
- rpz trigger, fix tcp only action after merge

5 years ago- rpz trigger, fix merge for unsupported ipaddr based trigger action.
W.C.A. Wijngaards [Fri, 12 Mar 2021 08:10:11 +0000 (09:10 +0100)] 
- rpz trigger, fix merge for unsupported ipaddr based trigger action.

5 years agoMerge branch 'master' into rpz-triggers
W.C.A. Wijngaards [Fri, 12 Mar 2021 08:04:54 +0000 (09:04 +0100)] 
Merge branch 'master' into rpz-triggers

5 years ago- man page contents, list new triggers and actions.
W.C.A. Wijngaards [Fri, 12 Mar 2021 07:54:00 +0000 (08:54 +0100)] 
- man page contents, list new triggers and actions.

5 years ago- Fix parse of LOC RR type for decimetres.
W.C.A. Wijngaards [Thu, 11 Mar 2021 12:22:05 +0000 (13:22 +0100)] 
- Fix parse of LOC RR type for decimetres.

5 years agoput tls-use-sni: on a line of its own
Willem Toorop [Wed, 10 Mar 2021 14:14:45 +0000 (15:14 +0100)] 
put tls-use-sni: on a line of its own

Sorry about this, this must have happened when I added the entries for padding queries and responses.

5 years agounbound_munin: Munin categories are lower case
Kim B. Heino [Tue, 9 Mar 2021 10:20:55 +0000 (12:20 +0200)] 
unbound_munin: Munin categories are lower case

5 years agounbound_munin: fix statistics after unbound restart / server reboot
Kim B. Heino [Tue, 9 Mar 2021 10:03:51 +0000 (12:03 +0200)] 
unbound_munin: fix statistics after unbound restart / server reboot

"unbound-control stats" lists only query types that has been seen
after unbound restart. Munin requires list of all types ever seen,
or the generated graphs are mostly empty after restart.

Fix this by adding a state file with list of seen query types etc.

5 years agounbound_munin_: use Munin's helper script to detect state file location
Kim B. Heino [Tue, 9 Mar 2021 09:09:45 +0000 (11:09 +0200)] 
unbound_munin_: use Munin's helper script to detect state file location

5 years agounbound_munin_: remove trailing white space
Kim B. Heino [Tue, 9 Mar 2021 09:03:54 +0000 (11:03 +0200)] 
unbound_munin_: remove trailing white space

5 years ago- Debug output for #411 and #439: printout internal error and details.
W.C.A. Wijngaards [Fri, 5 Mar 2021 12:54:26 +0000 (13:54 +0100)] 
- Debug output for #411 and #439: printout internal error and details.

5 years ago- Workaround for #439: prevent loops in the reuse rbtree.
W.C.A. Wijngaards [Fri, 5 Mar 2021 12:46:36 +0000 (13:46 +0100)] 
- Workaround for #439: prevent loops in the reuse rbtree.

5 years ago- Fix spurious errors about "Could not generate request: out of
W.C.A. Wijngaards [Thu, 4 Mar 2021 13:13:44 +0000 (14:13 +0100)] 
- Fix spurious errors about "Could not generate request: out of
  memory".  The mesh detect cycle routine no longer wrongly stops
  the check when the calling mesh state is unique.

5 years ago- iana portlist update.
W.C.A. Wijngaards [Thu, 4 Mar 2021 09:14:32 +0000 (10:14 +0100)] 
- iana portlist update.

5 years ago- Fix: Resolve interface names on control-interface too.
W.C.A. Wijngaards [Fri, 26 Feb 2021 12:54:10 +0000 (13:54 +0100)] 
- Fix: Resolve interface names on control-interface too.

5 years ago- Fix for #367: rc_ports don't have ub_sock; skip cleaning up.
George Thessalonikefs [Fri, 26 Feb 2021 12:13:37 +0000 (13:13 +0100)] 
- Fix for #367: rc_ports don't have ub_sock; skip cleaning up.

5 years ago- Fix to allow rpz with wildcard that applies to all TLDs at once.
W.C.A. Wijngaards [Thu, 25 Feb 2021 15:54:32 +0000 (16:54 +0100)] 
- Fix to allow rpz with wildcard that applies to all TLDs at once.

5 years agoChangelog note for #365, #367 and #368.
W.C.A. Wijngaards [Thu, 25 Feb 2021 11:00:28 +0000 (12:00 +0100)] 
Changelog note for #365, #367 and #368.
- Merge PR #367 : DNSTAP log local address.  With code from PR #365
  and fixes #368 : dnstap does not log the DNS message ID for
  FORWARDER_QUERY.

5 years agoMerge pull request #367 from NLnetLabs/dnstap-log-local-addr
Wouter Wijngaards [Thu, 25 Feb 2021 10:58:36 +0000 (11:58 +0100)] 
Merge pull request #367 from NLnetLabs/dnstap-log-local-addr

DNSTAP log local address

5 years agoFix comment item. 367/head
W.C.A. Wijngaards [Thu, 25 Feb 2021 07:50:02 +0000 (08:50 +0100)] 
Fix comment item.

5 years agoFix to use a simple pointer in the call of make_sock and make_sock_port.
W.C.A. Wijngaards [Wed, 24 Feb 2021 16:36:22 +0000 (17:36 +0100)] 
Fix to use a simple pointer in the call of make_sock and make_sock_port.

5 years ago- spelling fix in header.
W.C.A. Wijngaards [Wed, 24 Feb 2021 15:56:57 +0000 (16:56 +0100)] 
- spelling fix in header.

5 years ago- Fix unit test for added ulimit checks.
W.C.A. Wijngaards [Wed, 24 Feb 2021 14:30:12 +0000 (15:30 +0100)] 
- Fix unit test for added ulimit checks.

5 years ago- Fix function documentation.
W.C.A. Wijngaards [Wed, 24 Feb 2021 14:25:12 +0000 (15:25 +0100)] 
- Fix function documentation.

5 years ago- On startup of unbound it checks if rlimits on memory size look
W.C.A. Wijngaards [Wed, 24 Feb 2021 13:14:33 +0000 (14:14 +0100)] 
- On startup of unbound it checks if rlimits on memory size look
  sufficient for the configured cache size, and logs warning if not.

5 years ago- ipsecmod: Better logging for detecting a cycle when attaching the
George Thessalonikefs [Wed, 24 Feb 2021 12:59:31 +0000 (13:59 +0100)] 
- ipsecmod: Better logging for detecting a cycle when attaching the
  A/AAAA subquery.

5 years ago- Fix #384: (1) A minor request to improve the log (2) A minor bug in
George Thessalonikefs [Wed, 24 Feb 2021 10:57:48 +0000 (11:57 +0100)] 
- Fix #384: (1) A minor request to improve the log (2) A minor bug in
  one log message.

5 years ago- Fix for zonemd, do not reject insecure result from trust anchor
W.C.A. Wijngaards [Tue, 23 Feb 2021 16:09:40 +0000 (17:09 +0100)] 
- Fix for zonemd, do not reject insecure result from trust anchor
  validation step in dnssec chain of trust.

5 years ago- Fix for zonemd, that domain-insecure zones work without dnssec.
W.C.A. Wijngaards [Tue, 23 Feb 2021 16:03:23 +0000 (17:03 +0100)] 
- Fix for zonemd, that domain-insecure zones work without dnssec.

5 years agoSpelling fix.
W.C.A. Wijngaards [Mon, 22 Feb 2021 16:34:02 +0000 (17:34 +0100)] 
Spelling fix.

5 years ago- Fix for zonemd, that nxdomain for the chain of trust is allowed
W.C.A. Wijngaards [Mon, 22 Feb 2021 16:32:40 +0000 (17:32 +0100)] 
- Fix for zonemd, that nxdomain for the chain of trust is allowed
  for island zones, it is treates as an insecure zone for verification.

5 years ago- Fix #431: Squelch permission denied errors for tcp connect
W.C.A. Wijngaards [Mon, 22 Feb 2021 07:24:04 +0000 (08:24 +0100)] 
- Fix #431: Squelch permission denied errors for tcp connect

5 years ago- rpz skip nsec3param records, and nicer log for unsupported actions.
W.C.A. Wijngaards [Fri, 19 Feb 2021 14:00:39 +0000 (15:00 +0100)] 
- rpz skip nsec3param records, and nicer log for unsupported actions.

5 years ago- Fix #429: rpz: url: with https: broken (regression in 1.13.1).
W.C.A. Wijngaards [Fri, 19 Feb 2021 13:42:02 +0000 (14:42 +0100)] 
- Fix #429: rpz: url: with https: broken (regression in 1.13.1).

5 years agoMerge branch 'master' into dnstap-log-local-addr
W.C.A. Wijngaards [Thu, 18 Feb 2021 12:12:09 +0000 (13:12 +0100)] 
Merge branch 'master' into dnstap-log-local-addr

5 years ago- Fix doxygen and pydoc warnings.
W.C.A. Wijngaards [Thu, 18 Feb 2021 10:39:06 +0000 (11:39 +0100)] 
- Fix doxygen and pydoc warnings.

5 years agoMerge pull request #317 from NLnetLabs/zonemd
Wouter Wijngaards [Thu, 18 Feb 2021 10:17:04 +0000 (11:17 +0100)] 
Merge pull request #317 from NLnetLabs/zonemd

ZONEMD Zone Verification

5 years agoChangelog note for #317 317/head
W.C.A. Wijngaards [Thu, 18 Feb 2021 10:16:19 +0000 (11:16 +0100)] 
Changelog note for #317
- Merge PR #317: ZONEMD Zone Verification, with RFC 8976 support.
  ZONEMD records are checked for zones loaded as auth-zone,
  with DNSSEC if available.  There is an added option
  zonemd-permissive-mode that makes it log but not fail wrong zones.
  With zonemd-reject-absence for an auth-zone the presence of a
  zonemd can be mandated for specific zones.

5 years agoMerge branch 'master' into zonemd
W.C.A. Wijngaards [Thu, 18 Feb 2021 10:11:50 +0000 (11:11 +0100)] 
Merge branch 'master' into zonemd

5 years agoMerge pull request #427 from vstinner/fopen
Wouter Wijngaards [Tue, 16 Feb 2021 10:58:56 +0000 (11:58 +0100)] 
Merge pull request #427 from vstinner/fopen

Fix #426: Replace _Py_fopen() with fopen() in pythonmod.c

5 years agoFix #426: Replace _Py_fopen() with fopen() in pythonmod.c 427/head
Victor Stinner [Tue, 16 Feb 2021 10:11:06 +0000 (11:11 +0100)] 
Fix #426: Replace _Py_fopen() with fopen() in pythonmod.c

The private _Py_fopen() function has been removed in Python 3.10.

Fix build on Python 3.10.

5 years ago- Fix to make tests work with support indicators set for iterator.
W.C.A. Wijngaards [Mon, 15 Feb 2021 13:57:29 +0000 (14:57 +0100)] 
- Fix to make tests work with support indicators set for iterator.

5 years ago- Fix #422: IPv6 fallback issues when IPv6 is not properly
W.C.A. Wijngaards [Mon, 15 Feb 2021 13:40:48 +0000 (14:40 +0100)] 
- Fix #422: IPv6 fallback issues when IPv6 is not properly
  enabled/configured.

5 years agoMerge branch 'master' into zonemd
W.C.A. Wijngaards [Fri, 12 Feb 2021 16:21:51 +0000 (17:21 +0100)] 
Merge branch 'master' into zonemd

5 years agozonemd, review comments, spelling fix.
W.C.A. Wijngaards [Fri, 12 Feb 2021 09:48:38 +0000 (10:48 +0100)] 
zonemd, review comments, spelling fix.

5 years agozonemd, review comments, fix no anchor lookup if none.
W.C.A. Wijngaards [Fri, 12 Feb 2021 08:16:22 +0000 (09:16 +0100)] 
zonemd, review comments, fix no anchor lookup if none.

5 years agozonemd, review comments, stop null dnskey, skip dnssec for insecure islands.
W.C.A. Wijngaards [Fri, 12 Feb 2021 07:33:03 +0000 (08:33 +0100)] 
zonemd, review comments, stop null dnskey, skip dnssec for insecure islands.

5 years agozonemd, review comments, check qname for zonemd dnskey lookup.
W.C.A. Wijngaards [Thu, 11 Feb 2021 16:33:10 +0000 (17:33 +0100)] 
zonemd, review comments, check qname for zonemd dnskey lookup.

5 years agozonemd, review comments, stop callback for a deleted zone.
W.C.A. Wijngaards [Thu, 11 Feb 2021 16:27:59 +0000 (17:27 +0100)] 
zonemd, review comments, stop callback for a deleted zone.

5 years agozonemd, review comments, indentation.
W.C.A. Wijngaards [Thu, 11 Feb 2021 15:05:28 +0000 (16:05 +0100)] 
zonemd, review comments, indentation.