]>
git.ipfire.org Git - thirdparty/unbound.git/log
W.C.A. Wijngaards [Tue, 3 Dec 2019 16:28:51 +0000 (17:28 +0100)]
- make depend
W.C.A. Wijngaards [Tue, 3 Dec 2019 16:23:38 +0000 (17:23 +0100)]
- Fix Hardcoded Constant, reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 16:07:35 +0000 (17:07 +0100)]
- Fix _vfixed not Used, removed from sbuffer code,
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:44:24 +0000 (16:44 +0100)]
- Fix compile error in dnscrypt.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:42:14 +0000 (16:42 +0100)]
- Fix Client NONCE Generation used for Server NONCE,
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:34:53 +0000 (16:34 +0100)]
- Fix Bad Indentation, in dnscrypt.c,
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:29:18 +0000 (16:29 +0100)]
- Fix snprintf() supports the n-specifier,
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:21:04 +0000 (16:21 +0100)]
Note what it did, lower to 256 max count.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:20:24 +0000 (16:20 +0100)]
- Fix Hang in sldns_wire2str_pkt_scan(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:18:47 +0000 (16:18 +0100)]
- Fix Out of Bound Write Compressed Names in rdata_copy(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:17:03 +0000 (16:17 +0100)]
- Fix Insufficient Handling of Compressed Names in dname_pkt_copy(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:10:34 +0000 (16:10 +0100)]
- Fix Out of Bounds Write in sldns_b64_pton(),
fixed by check in sldns_str2wire_int16_data_buf(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 15:01:31 +0000 (16:01 +0100)]
- Fix Out of Bounds Write in sldns_str2wire_str_buf(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:42:34 +0000 (15:42 +0100)]
- Fix OOB Read in sldns_wire2str_dname_scan(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:20:48 +0000 (15:20 +0100)]
- Fix Assert Causing DoS in dname_pkt_copy(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:11:22 +0000 (15:11 +0100)]
- Fix similar code in auth_zone synth cname to add the extra checks.
W.C.A. Wijngaards [Tue, 3 Dec 2019 14:10:36 +0000 (15:10 +0100)]
- Fix Assert Causing DoS in synth_cname(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 3 Dec 2019 11:58:09 +0000 (12:58 +0100)]
- Fix text around serial arithmatic used for RRSIG times to refer
to correct RFC number.
W.C.A. Wijngaards [Tue, 3 Dec 2019 09:03:44 +0000 (10:03 +0100)]
Changelog entry for merge of #124.
- Merge pull request #124 from rmetrich: Changed log lock
from 'quick' to 'basic' because this is an I/O lock.
Wouter Wijngaards [Tue, 3 Dec 2019 09:03:24 +0000 (10:03 +0100)]
Merge pull request #124 from rmetrich/basic_loglock
Changed log lock from 'quick' to 'basic' because this is an I/O lock.
W.C.A. Wijngaards [Mon, 2 Dec 2019 12:59:43 +0000 (13:59 +0100)]
Changelog entry for #122.
- Merge pull request #122 from he32: In tcp_callback_writer(),
don't disable time-out when changing to read.
Wouter Wijngaards [Mon, 2 Dec 2019 12:59:13 +0000 (13:59 +0100)]
Merge pull request #122 from he32/timeout-fix
In tcp_callback_writer(), don't disable time-out when changing to read.
Renaud Métrich [Tue, 26 Nov 2019 15:32:03 +0000 (16:32 +0100)]
Changed log lock from 'quick' to 'basic' because this is an I/O lock.
We cannot use a 'quick' lock (i.e. lock spinning on the CPU) for the log
lock because it can wait a lot on I/Os. Using a 'quick' lock leads to
eating the CPU for no good reason.
Example of 'pidstat' output when using various locks for log_lock:
- 'quick' lock and slow log file system (tail -f on the log file on XFS on RHEL 8)
04:15:11 PM UID TGID TID %usr %system %CPU CPU Command
04:15:21 PM 998 16431 - 100.00 4.20 100.00 2 unbound
04:15:21 PM 998 - 16431 31.00 1.00 32.00 2 |__unbound
04:15:21 PM 998 - 16432 31.30 0.80 32.10 0 |__unbound
04:15:21 PM 998 - 16433 30.20 1.40 31.60 1 |__unbound
04:15:21 PM 998 - 16434 30.70 1.00 31.70 3 |__unbound
- 'quick' lock and log file system being fast
04:15:40 PM UID TGID TID %usr %system %CPU CPU Command
04:15:50 PM 998 16431 - 10.00 1.60 11.60 1 unbound
04:15:50 PM 998 - 16431 2.50 0.50 3.00 1 |__unbound
04:15:50 PM 998 - 16432 2.30 0.40 2.70 3 |__unbound
04:15:50 PM 998 - 16433 2.70 0.30 3.00 0 |__unbound
04:15:50 PM 998 - 16434 2.60 0.40 3.00 2 |__unbound
- 'basic' lock (this commit) and slow log file system (tail -f on the log file on XFS on RHEL 8)
04:29:48 PM UID TGID TID %usr %system %CPU CPU Command
04:29:58 PM 998 11632 - 7.10 14.10 21.20 3 unbound
04:29:58 PM 998 - 11632 1.70 3.20 4.90 3 |__unbound
04:29:58 PM 998 - 11633 1.60 3.30 4.90 1 |__unbound
04:29:58 PM 998 - 11634 2.00 4.10 6.10 1 |__unbound
04:29:58 PM 998 - 11635 1.90 3.50 5.40 1 |__unbound
We can see in the above example, when 'basic' lock is used, that CPU
isn't consumed when log file system is slow.
Another reproducer scenario: put the log file on a NFS share with 'sync'
option.
Havard Eidnes [Mon, 25 Nov 2019 23:02:34 +0000 (00:02 +0100)]
In tcp_callback_writer(), don't disable time-out when changing to read.
W.C.A. Wijngaards [Fri, 22 Nov 2019 14:10:02 +0000 (15:10 +0100)]
- Add make distclean that removes everything configure produced,
and make maintainer-clean that removes bison and flex output.
George Thessalonikefs [Fri, 22 Nov 2019 13:30:56 +0000 (14:30 +0100)]
Fix compiler warnings.
W.C.A. Wijngaards [Fri, 22 Nov 2019 13:23:00 +0000 (14:23 +0100)]
- Fix dname loop maximum, reported by Eric Sesterhenn from X41 D-Sec.
Ralph Dolmans [Fri, 22 Nov 2019 04:56:24 +0000 (12:56 +0800)]
processing RPZ review feedback
W.C.A. Wijngaards [Wed, 20 Nov 2019 14:22:20 +0000 (15:22 +0100)]
- Fix comments for doxygen in dns64.
PMunch [Wed, 20 Nov 2019 14:11:51 +0000 (15:11 +0100)]
Fix return code of init to mirror native modules
The return code of the init procedure was just set to be 1 in the
dynamic library loading module. This ha been rectified and it will now
return whatever is returned from the loaded module.
W.C.A. Wijngaards [Wed, 20 Nov 2019 14:07:09 +0000 (15:07 +0100)]
- Fix python examples/calc.py for eval, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:40:50 +0000 (14:40 +0100)]
- Fix Bad Randomness in Seed, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:37:13 +0000 (14:37 +0100)]
- Fix NULL Pointer Dereference via Control Port,
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:24:31 +0000 (14:24 +0100)]
Review fix of space.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:22:06 +0000 (14:22 +0100)]
- Fix Enum Name not Used, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:05:54 +0000 (14:05 +0100)]
- Fix Unrequired Checks, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:02:58 +0000 (14:02 +0100)]
- Fix Useless memset() in validator, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 13:01:01 +0000 (14:01 +0100)]
- Fix Terminating Quotes not Written, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:51:10 +0000 (13:51 +0100)]
- Fix compile with --enable-alloc-checks, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:30:27 +0000 (13:30 +0100)]
- Fixed Compat Code Diverging from Upstream, reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:28:49 +0000 (13:28 +0100)]
- Changes to compat/getentropy files for,
no link to openssl if using nettle, and hence config.h for
HAVE_NETTLE variable.
compat definition of MAP_ANON, for older systems.
ifdef stdint.h inclusion for older systems.
ifdef sha2.h inclusion for older systems.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:12:36 +0000 (13:12 +0100)]
- Upgrade compat/getentropy_osx.c to version 1.12 from OpenBSD.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:11:05 +0000 (13:11 +0100)]
- Upgrade compat/getentropy_solaris.c to version 1.13 from OpenBSD.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:08:43 +0000 (13:08 +0100)]
- Synchronize compat/getentropy_win.c with version 1.5 from
OpenBSD, no changes but makes the file, comments, identical.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:05:10 +0000 (13:05 +0100)]
- Upgrade compat/getentropy_linux.c to version 1.46 from OpenBSD.
W.C.A. Wijngaards [Wed, 20 Nov 2019 12:00:56 +0000 (13:00 +0100)]
- Fix Integer Underflow in Regional Allocator,
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 11:56:39 +0000 (12:56 +0100)]
- Fix Local Memory Leak in cachedb_init(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 11:02:19 +0000 (12:02 +0100)]
- Fix Config Injection in create_unbound_ad_servers.sh,
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 10:38:11 +0000 (11:38 +0100)]
- Fix Out-of-Bounds Read in dname_valid(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 10:35:07 +0000 (11:35 +0100)]
- Fix Randomness Error not Handled Properly,
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 10:28:53 +0000 (11:28 +0100)]
- Fix Weak Entropy Used For Nettle,
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 10:18:03 +0000 (11:18 +0100)]
- Adjust unbound-control to make stats_shm a read only operation.
W.C.A. Wijngaards [Wed, 20 Nov 2019 10:13:45 +0000 (11:13 +0100)]
- Fix Shared Memory World Writeable,
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 10:01:56 +0000 (11:01 +0100)]
- Fix Race Condition in autr_tp_create(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Wed, 20 Nov 2019 07:28:12 +0000 (08:28 +0100)]
- Fix Out of Bounds Read in rrinternal_get_owner(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 15:54:44 +0000 (16:54 +0100)]
- Fix Out of Bounds Write in sldns_bget_token_par(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 15:46:33 +0000 (16:46 +0100)]
- Fix Out of Bounds Read in sldns_str2wire_dname(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 15:42:17 +0000 (16:42 +0100)]
- Fix Integer Overflow to Buffer Overflow in
sldns_str2wire_dname_buf_origin(), reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 15:32:40 +0000 (16:32 +0100)]
- Fix Integer Overflows in Size Calculations,
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 15:17:06 +0000 (16:17 +0100)]
- Fix Out-of-bounds Read in rr_comment_dnskey(),
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 14:48:18 +0000 (15:48 +0100)]
- Fix Unchecked NULL Pointer in dns64_inform_super()
and ipsecmod_new(), reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 14:38:05 +0000 (15:38 +0100)]
- Fix Integer Overflow in Regional Allocator,
reported by X41 D-Sec.
W.C.A. Wijngaards [Tue, 19 Nov 2019 14:26:57 +0000 (15:26 +0100)]
Cast to unsigned before comparison for assertion.
W.C.A. Wijngaards [Tue, 19 Nov 2019 11:11:28 +0000 (12:11 +0100)]
And check the buffer size precisely.
W.C.A. Wijngaards [Tue, 19 Nov 2019 11:10:03 +0000 (12:10 +0100)]
- Fixes to please lint checks.
W.C.A. Wijngaards [Tue, 19 Nov 2019 09:09:44 +0000 (10:09 +0100)]
- Fix authzone printout buffer length check.
W.C.A. Wijngaards [Tue, 19 Nov 2019 09:06:12 +0000 (10:06 +0100)]
- 1.9.5 is 1.9.4 with bugfix, trunk is 1.9.6 in development.
W.C.A. Wijngaards [Tue, 19 Nov 2019 09:05:18 +0000 (10:05 +0100)]
- Fix CVE-2019-18934, shell execution in ipsecmod.
W.C.A. Wijngaards [Mon, 18 Nov 2019 14:58:19 +0000 (15:58 +0100)]
- gitignore .source tempfile used for compatible make.
W.C.A. Wijngaards [Mon, 18 Nov 2019 14:53:47 +0000 (15:53 +0100)]
- Portable grep usage for reuseport configure test.
- Check return type of HMAC_Init_ex for openssl 0.9.8.
W.C.A. Wijngaards [Mon, 18 Nov 2019 12:52:17 +0000 (13:52 +0100)]
- Provide a prototype for compat malloc to remove compile warning.
W.C.A. Wijngaards [Mon, 18 Nov 2019 09:50:54 +0000 (10:50 +0100)]
- update to bison output of 3.4.1 in code repository.
W.C.A. Wijngaards [Mon, 18 Nov 2019 09:45:47 +0000 (10:45 +0100)]
- In unbound-host use separate variable for get_option to please
code checkers.
W.C.A. Wijngaards [Wed, 13 Nov 2019 14:16:27 +0000 (15:16 +0100)]
- fixes for splint cleanliness, long vs int in SSL set_mode.
W.C.A. Wijngaards [Wed, 13 Nov 2019 10:40:56 +0000 (11:40 +0100)]
- contrib/fastrpz.patch updated to apply for current code.
W.C.A. Wijngaards [Wed, 13 Nov 2019 10:37:06 +0000 (11:37 +0100)]
- iana portlist updated.
W.C.A. Wijngaards [Mon, 11 Nov 2019 13:46:24 +0000 (14:46 +0100)]
Changelog note and configure autoconf generated.
- Merge #102 from jrtc27: Add getentropy emulation for FreeBSD.
Wouter Wijngaards [Mon, 11 Nov 2019 13:45:18 +0000 (14:45 +0100)]
Merge pull request #102 from jrtc27/freebsd-getentropy
Add getentropy emulation for FreeBSD
W.C.A. Wijngaards [Mon, 11 Nov 2019 11:02:51 +0000 (12:02 +0100)]
- Fix #109: check number of arguments for stdin-pipes in
unbound-control and fail if too many arguments.
PMunch [Mon, 4 Nov 2019 15:03:04 +0000 (16:03 +0100)]
Add "dynlib" prefix to example output, log queries
This adds the "dynlib: " prefix to all messages created by the
`helloworld.c` dynamic library example.
It also adds logging of queries that pass through `operate`.
James Clarke [Sat, 2 Nov 2019 18:08:23 +0000 (18:08 +0000)]
Add getentropy emulation for FreeBSD
PMunch [Fri, 1 Nov 2019 09:44:26 +0000 (10:44 +0100)]
Add inplace callback to dynlibmod, improve example
This adds the possibility to properly register inplace callbacks in the
dynamic library module. It works by creating a wrapper procedure that
is available to the dynamic library and will call the given callback
through a whitelisted callback function.
The dynamic library example has already been improved to include
comments and some simple examples on allocating and deallocating memory
and registering callbacks.
W.C.A. Wijngaards [Thu, 24 Oct 2019 07:58:45 +0000 (09:58 +0200)]
- Fix #99: Memory leak in ub_ctx (event_base will never be freed).
George Thessalonikefs [Wed, 23 Oct 2019 12:40:24 +0000 (14:40 +0200)]
Add new configure option `--enable-fully-static` to enable full static build if
requested; in relation to #91.
W.C.A. Wijngaards [Wed, 23 Oct 2019 05:56:17 +0000 (07:56 +0200)]
Changelog note for #97.
- Merge #97: manpage: Add missing word on unbound.conf,
from Erethon.
Wouter Wijngaards [Wed, 23 Oct 2019 05:54:57 +0000 (07:54 +0200)]
Merge pull request #97 from Erethon/master
manpage: Add missing word on unbound.conf
Dionysis Grigoropoulos [Tue, 22 Oct 2019 21:35:49 +0000 (00:35 +0300)]
manpage: Add missing word on unbound.conf
W.C.A. Wijngaards [Tue, 22 Oct 2019 08:32:37 +0000 (10:32 +0200)]
- drop-tld.diff: adds option drop-tld: yesno that drops 2 label
queries, to stop random floods. Apply with
patch -p1 < contrib/drop-tld.diff and compile.
From Saksham Manchanda (Secure64). Please note that we think this
will drop DNSKEY and DS lookups for tlds and hence break DNSSEC
lookups for downstream clients.
PMunch [Tue, 22 Oct 2019 06:42:00 +0000 (08:42 +0200)]
Cleanup some minor things in dynlibmod
PMunch [Mon, 21 Oct 2019 13:02:03 +0000 (15:02 +0200)]
Add support for multiple dynamic modules
Allows the use of multiple dynamic modules. Simply add more "dynlib"
entries to the "modules-config" and the same amount of "dynlib-file"
entries in the dynlib configuration block.
PMunch [Mon, 21 Oct 2019 12:20:33 +0000 (14:20 +0200)]
Improve dynlib module and add documentation
Dynamic library module is now only a thin wrapper that loads dynamic
libraries and forwards all function calls directly to the loaded module.
This meant adding get_mem and clear, and get_mem calls have been added
in the expected places.
Documentation has also been added to the example.conf and the
unbound.conf manpage.
PMunch [Thu, 17 Oct 2019 13:10:33 +0000 (15:10 +0200)]
Add dynamic library support
W.C.A. Wijngaards [Mon, 7 Oct 2019 07:50:04 +0000 (09:50 +0200)]
- Add doxygen comments to unbound-anchor source address code, in #86.
W.C.A. Wijngaards [Thu, 3 Oct 2019 14:29:45 +0000 (16:29 +0200)]
For #86, note credit for Lukas Wunner.
W.C.A. Wijngaards [Thu, 3 Oct 2019 14:22:42 +0000 (16:22 +0200)]
Changelog entry for #86 and whitespace fix.
- Merge #86 from psquarejho: Added -b source address option to
smallapp/unbound-anchor.c.
Wouter Wijngaards [Thu, 3 Oct 2019 14:19:58 +0000 (16:19 +0200)]
Merge pull request #86 from psquarejho/master
Added -b / source address option to smallapp/unbound-anchor.c
W.C.A. Wijngaards [Thu, 3 Oct 2019 09:40:13 +0000 (11:40 +0200)]
- Merge 1.9.4 release with fix for vulnerability CVE-2019-16866.
- Continue with development of 1.9.5.
W.C.A. Wijngaards [Thu, 3 Oct 2019 09:37:22 +0000 (11:37 +0200)]
Merge remote-tracking branch 'origin/branch-1.9.4'
W.C.A. Wijngaards [Thu, 3 Oct 2019 08:34:40 +0000 (10:34 +0200)]
Branch 1.9.4 prepares for 1.9.4 release from 1.9.3
W.C.A. Wijngaards [Thu, 3 Oct 2019 06:59:16 +0000 (08:59 +0200)]
Changelog entry for Merge #90.
- Merge #90 from vcunat: fix build with nettle-3.5.