]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-105699: Fix a Crasher Related to a Deprecated Global Variable (gh-106923)
authorEric Snow <ericsnowcurrently@gmail.com>
Fri, 21 Jul 2023 14:34:09 +0000 (08:34 -0600)
committerGitHub <noreply@github.com>
Fri, 21 Jul 2023 14:34:09 +0000 (08:34 -0600)
commit0ba07b2108d4763273f3fb85544dde34c5acd40a
treeb84bee32e122ca394fcce07c5934e9a543180691
parent87e7cb09e4258c4deb01a07dc52c1021907195d7
gh-105699: Fix a Crasher Related to a Deprecated Global Variable (gh-106923)

There was a slight race in _Py_ClearFileSystemEncoding() (when called from _Py_SetFileSystemEncoding()), between freeing the value and setting the variable to NULL, which occasionally caused crashes when multiple isolated interpreters were used.  (Notably, I saw at least 10 different, seemingly unrelated spooky-action-at-a-distance, ways this crashed. Yay, free threading!)  We avoid the problem by only setting the global variables with the main interpreter (i.e. runtime init).
Misc/NEWS.d/next/Core and Builtins/2023-07-20-12-21-37.gh-issue-105699.08ywGV.rst [new file with mode: 0644]
Objects/unicodeobject.c