]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amdgpu/ttm: Fix crash when handling MMIO_REMAP in PDE flags
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Tue, 18 Nov 2025 08:58:33 +0000 (14:28 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 19 Nov 2025 22:34:15 +0000 (17:34 -0500)
commit0db94da5a0a1cacda080b9ec8425fcbe4babc141
tree822ed5e052ad3137c6f14659208f6ababa306bf5
parent8feeab26c80635b802f72b3ed986c693ff8f3212
drm/amdgpu/ttm: Fix crash when handling MMIO_REMAP in PDE flags

The MMIO_REMAP BO is a special 4K IO page that does not have a ttm_tt
behind it. However, amdgpu_ttm_tt_pde_flags() was treating it like
normal TT/doorbell/preempt memory and unconditionally accessed
ttm->caching. For the MMIO_REMAP BO, ttm is NULL, so this leads to a
NULL pointer dereference when computing PDE flags.

Fix this by checking that ttm is non-NULL before reading ttm->caching.
This prevents the crash for MMIO_REMAP and also makes the code more
defensive if other BOs ever come through without a ttm_tt.

Fixes: fb5a52dbe9fe ("drm/amdgpu: Implement TTM handling for MMIO_REMAP placement")
Suggested-by: Jesse Zhang <Jesse.Zhang@amd.com>
Suggested-by: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Jesse Zhang <Jesse.Zhang@amd.com>
Tested-by: Jesse Zhang <Jesse.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c