]> git.ipfire.org Git - thirdparty/patchwork.git/commit
urls: Encode slashes in message IDs
authorStephen Finucane <stephen@that.guru>
Wed, 11 May 2022 13:52:36 +0000 (14:52 +0100)
committerStephen Finucane <stephen@that.guru>
Fri, 30 Sep 2022 16:41:08 +0000 (17:41 +0100)
commit2653fdbb2f33a9c762936ca97e3c6888b185cb4b
tree1cb59a2c93b37fb5e157e6e39fe80e126b71365d
parent73b0b12df256c4e2e9c5e724828c778e69f0cf13
urls: Encode slashes in message IDs

We were attempting to work around the fact that message IDs could
contain slashes which in some cases broke our ability to generate
meaningful URLs. Rather than doing this, insist that users encode these
slashes so that we can distinguish between semantically meaningful
slashes and those that form the URL. This is a slightly breaking change,
but the current behavior is already broken (see the linked bug) so this
seems reasonable.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Closes: #433
Cc: dja@axtens.net
Cc: siddhesh@gotplt.org
14 files changed:
notes/issue-433-5f048abbe3789556.yaml [new file with mode: 0644]
patchwork/models.py
patchwork/templates/patchwork/partials/download-buttons.html
patchwork/templates/patchwork/partials/patch-list.html
patchwork/templates/patchwork/submission.html
patchwork/tests/api/test_cover.py
patchwork/tests/api/test_patch.py
patchwork/tests/views/test_bundles.py
patchwork/tests/views/test_cover.py
patchwork/tests/views/test_patch.py
patchwork/urls.py
patchwork/views/comment.py
patchwork/views/cover.py
patchwork/views/patch.py