]> git.ipfire.org Git - thirdparty/git.git/commit
sideband: use writev(3p) to send pktlines
authorPatrick Steinhardt <ps@pks.im>
Fri, 13 Mar 2026 06:45:18 +0000 (07:45 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 13 Mar 2026 15:54:14 +0000 (08:54 -0700)
commit26986f4cbaf38d84a82b0b35da211389ce49552c
treecc9d63343f164e017a3870c1206fcc56f9a8ced6
parent1970fcef93adcc5a35f6468d00a5a634d5af2b3c
sideband: use writev(3p) to send pktlines

Every pktline that we send out via `send_sideband()` currently requires
two syscalls: one to write the pktline's length, and one to send its
data. This typically isn't all that much of a problem, but under extreme
load the syscalls may cause contention in the kernel.

Refactor the code to instead use the newly introduced writev(3p) infra
so that we can send out the data with a single syscall. This reduces the
number of syscalls from around 133,000 calls to write(3p) to around
67,000 calls to writev(3p).

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sideband.c