]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-125398: Convert paths in venv activate script when using Git Bash under Windows...
authorJulien <julien@caffeine.lu>
Sat, 19 Oct 2024 17:34:41 +0000 (13:34 -0400)
committerGitHub <noreply@github.com>
Sat, 19 Oct 2024 17:34:41 +0000 (18:34 +0100)
commit2a378dba987e125521b678364f0cd44b92dd5d52
tree34e6429d7c15d79b902860c5459d7bca87b4d049
parent4b421e8aca7f2dccc5ac8604b78589941dd7974c
gh-125398: Convert paths in venv activate script when using Git Bash under Windows (GH-125399)

* Convert paths in venv activate script when using Git Bash under Windows

With https://github.com/python/cpython/pull/112508 the check to converts paths when running on Windows was changed from using the non-posix environment variable `$OSTYPE` to using `uname` instead.

However this missed the fact that when running under Git Bash on Windows, uname reports `MINGW*` (`$OSTYPE` is still `msys`).

This results in `$PATH` being set to something like `D:\a\github-actions-shells\github-actions-shells\venv/Scripts:…`, instead of `/d/a/github-actions-shells/github-actions-shells/venv/Scripts`.

Notably, the Git Bash is the bash shell that’s used for GitHub Actions Windows runners, and ships with VSCode.
Lib/venv/scripts/common/activate
Misc/NEWS.d/next/Library/2024-10-13-15-04-58.gh-issue-125398.UW7Ndv.rst [new file with mode: 0644]