]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-121973: Fix flaky test_pyrepl tests (GH-122140)
authorSam Gross <colesbury@gmail.com>
Tue, 23 Jul 2024 13:17:13 +0000 (09:17 -0400)
committerGitHub <noreply@github.com>
Tue, 23 Jul 2024 13:17:13 +0000 (15:17 +0200)
commit2c1b1e7a07eba0138b9858c6f2bea3cae9af0808
treeb85421160726237e9fc377e310561f90c6c33996
parent624bda76386efd8eecf73c4ad06f997b9b25f07f
gh-121973: Fix flaky test_pyrepl tests (GH-122140)

This fixes the flakiness in:
* test_inspect_keeps_globals_from_inspected_file
* test_inspect_keeps_globals_from_inspected_module

The output already includes newlines. Adding newlines for every entry in
the output list introduces non-determinism because it added '\n' in
places where stdout is flushed or some buffer becomes full.

The regex also needed to be updated because pyrepl includes control
characters -- the visible output on each line doesn't immediately follow
a newline character.

Co-authored-by: Ɓukasz Langa <lukasz@langa.pl>
Lib/test/test_pyrepl/test_pyrepl.py