]> git.ipfire.org Git - thirdparty/curl.git/commit
schannel: add "best effort" revocation check option
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Wed, 26 Feb 2020 10:24:26 +0000 (11:24 +0100)
committerJay Satiro <raysatiro@yahoo.com>
Wed, 18 Mar 2020 07:23:39 +0000 (03:23 -0400)
commit54504284918a4ba19bc7b1efb486a64629d376aa
treed945df3518472bcb02efcd95caf16bbdadd52d33
parenta268ad5d7e84189d8dfec3705d84a88ae064f7fc
schannel: add "best effort" revocation check option

- Implement new option CURLSSLOPT_REVOKE_BEST_EFFORT and
  --ssl-revoke-best-effort to allow a "best effort" revocation check.

A best effort revocation check ignores errors that the revocation check
was unable to take place. The reasoning is described in detail below and
discussed further in the PR.

---

When running e.g. with Fiddler, the schannel backend fails with an
unhelpful error message:

Unknown error (0x80092012) - The revocation function was unable
to check revocation for the certificate.

Sadly, many enterprise users who are stuck behind MITM proxies suffer
the very same problem.

This has been discussed in plenty of issues:
https://github.com/curl/curl/issues/3727,
https://github.com/curl/curl/issues/264, for example.

In the latter, a Microsoft Edge developer even made the case that the
common behavior is to ignore issues when a certificate has no recorded
distribution point for revocation lists, or when the server is offline.
This is also known as "best effort" strategy and addresses the Fiddler
issue.

Unfortunately, this strategy was not chosen as the default for schannel
(and is therefore a backend-specific behavior: OpenSSL seems to happily
ignore the offline servers and missing distribution points).

To maintain backward-compatibility, we therefore add a new flag
(`CURLSSLOPT_REVOKE_BEST_EFFORT`) and a new option
(`--ssl-revoke-best-effort`) to select the new behavior.

Due to the many related issues Git for Windows and GitHub Desktop, the
plan is to make this behavior the default in these software packages.

The test 2070 was added to verify this behavior, adapted from 310.

Based-on-work-by: georgeok <giorgos.n.oikonomou@gmail.com>
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Closes https://github.com/curl/curl/pull/4981
20 files changed:
docs/cmdline-opts/Makefile.inc
docs/cmdline-opts/ssl-revoke-best-effort.d [new file with mode: 0644]
docs/libcurl/opts/CURLOPT_PROXY_SSL_OPTIONS.3
docs/libcurl/opts/CURLOPT_SSL_OPTIONS.3
docs/libcurl/symbols-in-versions
include/curl/curl.h
lib/doh.c
lib/setopt.c
lib/urldata.h
lib/vtls/schannel.c
lib/vtls/schannel_verify.c
packages/OS400/curl.inc.in
src/tool_cfgable.h
src/tool_getparam.c
src/tool_help.c
src/tool_operate.c
src/tool_setopt.c
tests/data/Makefile.inc
tests/data/test2070 [new file with mode: 0644]
tests/runtests.pl