]> git.ipfire.org Git - thirdparty/tor.git/commit
Fix directory self-testing logic
authorNick Mathewson <nickm@torproject.org>
Wed, 12 Sep 2012 14:15:58 +0000 (10:15 -0400)
committerNick Mathewson <nickm@torproject.org>
Wed, 12 Sep 2012 14:26:59 +0000 (10:26 -0400)
commit5cbeb6080596c4442a19cffb56c1a68316b3014a
tree043af62c2910bcc6797f47560ff2721c3ba11b80
parent75c9ccd4f851bac6d32cb08ded557ac207bc8002
Fix directory self-testing logic

When I removed version_supports_begindir, I accidentally removed the
mechanism we had been using to make a directory cache self-test its
directory port.  This caused bug 6815, which caused 6814 (both in
0.2.4.2-alpha).

To fix this bug, I'm replacing the "anonymized_connection" argument to
directory_initiate_command_* with an enumeration to say how indirectly
to connect to a directory server.  (I don't want to reinstate the
"version_supports_begindir" argument as "begindir_ok" or anything --
these functions already take too many arguments.)

For safety, I made sure that passing 0 and 1 for 'indirection' gives
the same result as you would have gotten before -- just in case I
missed any 0s or 1s.
changes/bug6815 [new file with mode: 0644]
src/or/circuitbuild.c
src/or/directory.c
src/or/directory.h
src/or/networkstatus.c
src/or/rendclient.c
src/or/rendservice.c
src/or/router.c
src/or/routerlist.c