]> git.ipfire.org Git - thirdparty/nftables.git/commit
tests: shell: Fix ifname_based_hooks feature check
authorPhil Sutter <phil@nwl.cc>
Wed, 25 Jun 2025 16:53:36 +0000 (18:53 +0200)
committerFlorian Westphal <fw@strlen.de>
Thu, 26 Jun 2025 12:06:51 +0000 (14:06 +0200)
commit646acfaceb1f550c982c31ba6e60996b0bb012d7
tree1c5ff7c58caa7b8c96f133a52a2e9eee23f7985c
parentc9d6f089f0eb2cb615cbca3e4c99b07c5639960f
tests: shell: Fix ifname_based_hooks feature check

The test was technically incorrect: Instead of detecting whether
interface hooks are name-based or not, it actually tested whether
netdev-family chains are removed along with their last hook.

Since the latter behaviour is established in kernel commit fc0133428e7a
("netfilter: nf_tables: Tolerate chains with no remaining hooks") and
thus independent from the name-based hooks change, treating both as the
same kernel feature is not acceptable.

Fix this by detecting whether a netdev-family chain may be added despite
specifying a non-existent interface to hook into. Keep the old check
around with a better name, although unused for now.

Reported-by: Florian Westphal <fw@strlen.de>
Fixes: f27e5abd81f29 ("tests: shell: Adjust to ifname-based hooks")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
tests/shell/features/empty_netdev_chains.sh [new file with mode: 0755]
tests/shell/features/ifname_based_hooks.sh