]> git.ipfire.org Git - thirdparty/linux.git/commit
bitops: Add __attribute_const__ to generic ffs()-family implementations
authorKees Cook <kees@kernel.org>
Mon, 4 Aug 2025 16:43:58 +0000 (09:43 -0700)
committerKees Cook <kees@kernel.org>
Mon, 8 Sep 2025 21:58:50 +0000 (14:58 -0700)
commit6606c8c7e81886565f5cbdb0c0ce82e280c2b229
tree7295c6aafb146a62d116db93fbda8af690709a94
parentb3a7bb71bfcd56c8266af8cf2a5dee3802e7a449
bitops: Add __attribute_const__ to generic ffs()-family implementations

While tracking down a problem where constant expressions used by
BUILD_BUG_ON() suddenly stopped working[1], we found that an added static
initializer was convincing the compiler that it couldn't track the state
of the prior statically initialized value. Tracing this down found that
ffs() was used in the initializer macro, but since it wasn't marked with
__attribute__const__, the compiler had to assume the function might
change variable states as a side-effect (which is not true for ffs(),
which provides deterministic math results).

Add missing __attribute_const__ annotations to generic implementations of
ffs(), __ffs(), fls(), and __fls() functions. These are pure mathematical
functions that always return the same result for the same input with no
side effects, making them eligible for compiler optimization.

Build tested with x86_64 defconfig using GCC 14.2.0, which should validate
the implementations when used by ARM, ARM64, LoongArch, Microblaze,
NIOS2, and SPARC32 architectures.

Link: https://github.com/KSPP/linux/issues/364
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250804164417.1612371-2-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
include/asm-generic/bitops/__ffs.h
include/asm-generic/bitops/__fls.h
include/asm-generic/bitops/builtin-__ffs.h
include/asm-generic/bitops/builtin-__fls.h
include/asm-generic/bitops/builtin-fls.h
include/asm-generic/bitops/ffs.h
include/asm-generic/bitops/fls.h
include/asm-generic/bitops/fls64.h
include/linux/bitops.h
lib/clz_ctz.c