]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.13] gh-117482: Simplify the Fix For Builtin Types Slot Wrappers (gh-121932)
authorEric Snow <ericsnowcurrently@gmail.com>
Wed, 24 Jul 2024 18:02:36 +0000 (12:02 -0600)
committerGitHub <noreply@github.com>
Wed, 24 Jul 2024 18:02:36 +0000 (12:02 -0600)
commit716c6771fcfd3be90bba9f888a579b36c02cdb13
tree66defbd05da3ae05294f9563da62549947a5695b
parent0952ea94d96bf385b775951da5a49f7e4ace836e
[3.13] gh-117482: Simplify the Fix For Builtin Types Slot Wrappers (gh-121932)

In gh-121602, I applied a fix to a builtin types initialization bug.
That fix made sense in the context of some broader future changes,
but introduced a little bit of extra complexity.  For earlier versions
those future changes are not relevant; we can avoid the extra complexity.
Thus we can revert that earlier change and replace it with this one,
which is more focused and conceptually simpler.  This is essentially
the implementation of an idea that @markshannon pointed out to me.

Note that this change would be much smaller if we didn't have to deal
with repr compatibility for builtin types that explicitly inherit tp slots
(see expect_manually_inherited()).  The alternative is to stop
*explicitly* inheriting tp slots in static PyTypeObject values,
which is churn that we can do separately.
Include/internal/pycore_typeobject.h
Objects/typeobject.c