]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Fix for parallel port passthrough for QEMU
authorBeat Jörg <Beat.Joerg@ssatr.ch>
Wed, 23 May 2012 05:50:02 +0000 (07:50 +0200)
committerEric Blake <eblake@redhat.com>
Mon, 4 Jun 2012 22:46:23 +0000 (16:46 -0600)
commit7508338ff3b75b39ee9654e3d83bc58c858dc92a
tree78ba83f29dca06fb1899a3ca7f5c56d2a3426b21
parenta3bc393e3aa87444f1bbfed506116283fef5a0b3
Fix for parallel port passthrough for QEMU

I came across a bug that the command line generated for passthrough
of the host parallel port /dev/parport0 by libvirt for QEMU is incorrect.

It currently produces:
-chardev tty,id=charparallel0,path=/dev/parport0
-device isa-parallel,chardev=charparallel0,id=parallel0

The first parameter is "tty". It sould be "parport".

If I launch qemu with -chardev parport,... it works as expected.

I have already filled a bug report (
https://bugzilla.redhat.com/show_bug.cgi?id=823879 ), the topic was
already on the list some months ago:

https://www.redhat.com/archives/libvirt-users/2011-September/msg00095.html

Signed-off-by: Eric Blake <eblake@redhat.com>
AUTHORS
src/qemu/qemu_command.c
tests/qemuxml2argvdata/qemuxml2argv-parallel-parport-chardev.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-parallel-parport-chardev.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c