]> git.ipfire.org Git - thirdparty/glibc.git/commit
i386: Update ___tls_get_addr to preserve vector registers
authorH.J. Lu <hjl.tools@gmail.com>
Sun, 8 Jun 2025 21:22:10 +0000 (05:22 +0800)
committerH.J. Lu <hjl.tools@gmail.com>
Wed, 18 Jun 2025 20:30:31 +0000 (04:30 +0800)
commit848f0e46f03f22404ed9a8aabf3fd5ce8809a1be
tree5f5ef1adaac3736e7e426a03b463f7b2e58428df
parentabc2e954af77f8d10f4f54754520814590e79830
i386: Update ___tls_get_addr to preserve vector registers

Compiler generates the following instruction sequence for dynamic TLS
access:

leal tls_var@tlsgd(,%ebx,1), %eax
call ___tls_get_addr@PLT

CALL instruction is transparent to compiler which assumes all registers,
except for EFLAGS, AX, CX, and DX, are unchanged after CALL.  But
___tls_get_addr is a normal function which doesn't preserve any vector
registers.

1. Rename the generic __tls_get_addr function to ___tls_get_addr_internal.
2. Change ___tls_get_addr to a wrapper function with implementations for
FNSAVE, FXSAVE, XSAVE and XSAVEC to save and restore all vector registers.
3. dl-tlsdesc-dynamic.h has:

_dl_tlsdesc_dynamic:
/* Like all TLS resolvers, preserve call-clobbered registers.
   We need two scratch regs anyway.  */
subl $32, %esp
cfi_adjust_cfa_offset (32)

It is wrong to use

movl %ebx, -28(%esp)
movl %esp, %ebx
cfi_def_cfa_register(%ebx)
...
mov %ebx, %esp
cfi_def_cfa_register(%esp)
movl -28(%esp), %ebx

to preserve EBX on stack.  Fix it with:

movl %ebx, 28(%esp)
movl %esp, %ebx
cfi_def_cfa_register(%ebx)
...
mov %ebx, %esp
cfi_def_cfa_register(%esp)
movl 28(%esp), %ebx

4. Update _dl_tlsdesc_dynamic to call ___tls_get_addr_internal directly.
5. Add have-test-mtls-traditional to compile tst-tls23-mod.c with
traditional TLS variant to verify the fix.
6. Define DL_RUNTIME_RESOLVE_REALIGN_STACK in sysdeps/x86/sysdep.h.

This fixes BZ #32996.

Co-Authored-By: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
25 files changed:
configure
configure.ac
elf/Makefile
elf/tst-tls23-mod.c [new file with mode: 0644]
elf/tst-tls23.c [new file with mode: 0644]
elf/tst-tls23.h [moved from sysdeps/x86_64/dl-trampoline-save.h with 52% similarity]
sysdeps/aarch64/preconfigure
sysdeps/i386/Makefile
sysdeps/i386/dl-tls-get-addr.c [new file with mode: 0644]
sysdeps/i386/dl-tls.h
sysdeps/i386/dl-tlsdesc-dynamic.h
sysdeps/i386/dl-tlsdesc.S
sysdeps/i386/tls-get-addr-wrapper.h [new file with mode: 0644]
sysdeps/i386/tls_get_addr.S [new file with mode: 0644]
sysdeps/i386/tls_get_addr.h [new file with mode: 0644]
sysdeps/loongarch/preconfigure
sysdeps/loongarch/preconfigure.ac
sysdeps/powerpc/Makefile
sysdeps/x86/Makefile
sysdeps/x86/sysdep.h
sysdeps/x86/tst-tls23.c [new file with mode: 0644]
sysdeps/x86/tst-tls23.h [new file with mode: 0644]
sysdeps/x86_64/Makefile
sysdeps/x86_64/dl-tlsdesc.S
sysdeps/x86_64/dl-trampoline.S