]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commit
runqueue: Really fix sigchld handling
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 18 Mar 2014 22:58:52 +0000 (22:58 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 18 Mar 2014 23:04:49 +0000 (23:04 +0000)
commit973876c706f08735c1b68c791a5a137e5f083dd2
tree87d7c064953adfce16769635543fdabb496071cf
parente39e85803cbe1ef9413a118868c19087c0546d01
runqueue: Really fix sigchld handling

There are several problems. Firstly, a return value of "None" can mean
there is a C signal handler installed so we need to better handle that
case. signal.SIG_DFL is 0 which equates to false so we also need to
handle that by testing explicitly for None.

Finally, the signal handler *must* call waitpid on all child processes
else it will just get called repeatedly, leading to the hanging behaviour
we've been seeing. The solution is to only error for the worker children,
we warn about any other stray children which we'll have to figure out the
sources of in due course.

Hopefully this patch gets things working again properly though.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
lib/bb/runqueue.py