]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-133767: Fix use-after-free in the unicode-escape decoder with an error handler...
authorSerhiy Storchaka <storchaka@gmail.com>
Mon, 12 May 2025 17:42:23 +0000 (20:42 +0300)
committerGitHub <noreply@github.com>
Mon, 12 May 2025 17:42:23 +0000 (20:42 +0300)
commit9f69a58623bd01349a18ba0c7a9cb1dad6a51e8e
tree227d1096d051189bdebbb236e9826a1f4594acb5
parent734e15b70dc044f57df4049a22dd769dffdb7d18
gh-133767: Fix use-after-free in the unicode-escape decoder with an error handler (GH-129648)

If the error handler is used, a new bytes object is created to set as
the object attribute of UnicodeDecodeError, and that bytes object then
replaces the original data. A pointer to the decoded data will became invalid
after destroying that temporary bytes object. So we need other way to return
the first invalid escape from _PyUnicode_DecodeUnicodeEscapeInternal().

_PyBytes_DecodeEscape() does not have such issue, because it does not
use the error handlers registry, but it should be changed for compatibility
with _PyUnicode_DecodeUnicodeEscapeInternal().
Include/internal/pycore_bytesobject.h
Include/internal/pycore_unicodeobject.h
Lib/test/test_codeccallbacks.py
Lib/test/test_codecs.py
Misc/NEWS.d/next/Security/2025-05-09-20-22-54.gh-issue-133767.kN2i3Q.rst [new file with mode: 0644]
Objects/bytesobject.c
Objects/unicodeobject.c
Parser/string_parser.c