]> git.ipfire.org Git - thirdparty/gcc.git/commit
libstdc++: Add workaround for ia32 floating atomics miscompilations [PR100184]
authorJakub Jelinek <jakub@redhat.com>
Thu, 22 Apr 2021 13:08:21 +0000 (15:08 +0200)
committerJakub Jelinek <jakub@redhat.com>
Thu, 22 Apr 2021 13:10:46 +0000 (15:10 +0200)
commita21f3b38c3b9a5c28c79be37b040e7d06d827d76
treef4ca285299348062570e1674e8779a2db4efda46
parent3d8c8b6146ac8998204be818cbb36ff9f7a2fa6e
libstdc++: Add workaround for ia32 floating atomics miscompilations [PR100184]

gcc on ia32 miscompiles various atomics involving floating point,
unfortunately I'm afraid it is too late to fix that for 11.1 and
as I'm quite lost on it, it might take a while for 12 too
(disabling all the 8 peephole2s would be easiest, but then we'd
run into optimization regressions).

While 1.cc just FAILs, with dejagnu 1.6.1 wait_notify.cc hangs the
make check even after the timeout fires.  The following patch therefore
xfails the former and skips the latter.

Tested on x86_64-linux where
make check RUNTESTFLAGS='conformance.exp=atomic_float/*.cc'
is still
                === libstdc++ Summary ===

 # of expected passes            8
and on i686-linux, where it is now
                === libstdc++ Summary ===

 # of expected passes            5
 # of expected failures          1
 # of unsupported tests          1

2021-04-22  Jakub Jelinek  <jakub@redhat.com>

PR target/100182
* testsuite/29_atomics/atomic_float/1.cc: Add dg-xfail-run-if for
ia32.
* testsuite/29_atomics/atomic_float/wait_notify.cc: Add dg-skip-if for
ia32.

(cherry picked from commit 0f4588141fcbe4e0f1fa12776b47200870f6c621)
libstdc++-v3/testsuite/29_atomics/atomic_float/1.cc
libstdc++-v3/testsuite/29_atomics/atomic_float/wait_notify.cc