]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/amd/display: Only restore backlight after amdgpu_dm_init or dm_resume
authorMatthew Schwartz <matthew.schwartz@linux.dev>
Thu, 11 Sep 2025 17:48:51 +0000 (10:48 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 18 Sep 2025 20:59:34 +0000 (16:59 -0400)
commita490c8d77d500b5981e739be3d59c60cfe382536
tree8133478037079341ed2fe1dd1b256dea35c59723
parentcc9a8e238e42c1f43b98c097995137d644b69245
drm/amd/display: Only restore backlight after amdgpu_dm_init or dm_resume

On clients that utilize AMD_PRIVATE_COLOR properties for HDR support,
brightness sliders can include a hardware controlled portion and a
gamma-based portion. This is the case on the Steam Deck OLED when using
gamescope with Steam as a client.

When a user sets a brightness level while HDR is active, the gamma-based
portion and/or hardware portion are adjusted to achieve the desired
brightness. However, when a modeset takes place while the gamma-based
portion is in-use, restoring the hardware brightness level overrides the
user's overall brightness level and results in a mismatch between what
the slider reports and the display's current brightness.

To avoid overriding gamma-based brightness, only restore HW backlight
level after boot or resume. This ensures that the backlight level is
set correctly after the DC layer resets it while avoiding interference
with subsequent modesets.

Fixes: 7875afafba84 ("drm/amd/display: Fix brightness level not retained over reboot")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4551
Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h