]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-35992: Use PySequence_GetItem only if sq_item is not NULL (GH-11857)
authorIvan Levkivskyi <levkivskyi@gmail.com>
Sun, 17 Feb 2019 23:13:46 +0000 (23:13 +0000)
committerGitHub <noreply@github.com>
Sun, 17 Feb 2019 23:13:46 +0000 (23:13 +0000)
commitac28147e78c45a6217d348ce90ca5281d91f676f
tree891d00108f7066f1174788f72dd1696079950b68
parent1bf8845f74013c5f1cc5f49a11e52c652a1fb9dd
bpo-35992: Use PySequence_GetItem only if sq_item is not NULL (GH-11857)

Not using `__class_getitem__()` fallback if there is a non-subcriptable metaclass was caused by a certain asymmetry between how `PySequenceMethods` and `PyMappingMethods` are used in `PyObject_GetItem`. This PR removes this asymmetry. No tests failed, so I assume it was not intentional.
Lib/test/test_genericclass.py
Misc/NEWS.d/next/Core and Builtins/2019-02-14-12-01-44.bpo-35992.nG9e2L.rst [new file with mode: 0644]
Objects/abstract.c