]> git.ipfire.org Git - thirdparty/linux.git/commit
spi: spi-cadence-quadspi: Enable pm runtime earlier to avoid imbalance
authorAnurag Dutta <a-dutta@ti.com>
Wed, 5 Nov 2025 16:11:45 +0000 (21:41 +0530)
committerMark Brown <broonie@kernel.org>
Thu, 13 Nov 2025 18:50:35 +0000 (18:50 +0000)
commitf1eb4e792bb1ee3dcdffa66f8a83a4867cda2dd3
tree8f03333aad6fbc1a8d00b79e0b4c2eba480ff87a
parent66e9feb03e7cf8983b1d0c540e2dad90d5146d48
spi: spi-cadence-quadspi: Enable pm runtime earlier to avoid imbalance

The "probe_setup_failed" label calls pm_runtime_disable(), but
pm_runtime_enable() was placed after a possible jump to this label.
When cqspi_setup_flash() fails, control jumps to the label without
pm_runtime_enable() being called, leading to unbalanced PM runtime
reference counting.

Move pm_runtime_enable() and associated calls above the first
possible branch to "probe_setup_failed" to ensure balanced
enable/disable calls across all error paths.

Fixes: 30dbc1c8d50f ("spi: cadence-qspi: defer runtime support on socfpga if reset bit is enabled")
Signed-off-by: Anurag Dutta <a-dutta@ti.com>
Link: https://patch.msgid.link/20251105161146.2019090-2-a-dutta@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c