]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
watchdog: iTCO_wdt: Account for rebooting on second timeout
authorJan Kiszka <jan.kiszka@siemens.com>
Sun, 30 May 2021 11:24:23 +0000 (13:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:10:47 +0000 (16:10 +0200)
commitf58ab0b02ee7b095e0cae4ba706caa86fff5557b
treeccf232ee74bab3b2fc21502c6bc859d6134d3d3b
parentbcafecd304313f4e3592603cb190166a5642909c
watchdog: iTCO_wdt: Account for rebooting on second timeout

[ Upstream commit cb011044e34c293e139570ce5c01aed66a34345c ]

This was already attempted to fix via 1fccb73011ea: If the BIOS did not
enable TCO SMIs, the timer definitely needs to trigger twice in order to
cause a reboot. If TCO SMIs are on, as well as SMIs in general, we can
continue to assume that the BIOS will perform a reboot on the first
timeout.

QEMU with its ICH9 and related BIOS falls into the former category,
currently taking twice the configured timeout in order to reboot the
machine. For iTCO version that fall under turn_SMI_watchdog_clear_off,
this is also true and was currently only addressed for v1, irrespective
of the turn_SMI_watchdog_clear_off value.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/0b8bb307-d08b-41b5-696c-305cdac6789c@siemens.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/watchdog/iTCO_wdt.c