]> git.ipfire.org Git - thirdparty/openwrt.git/commit
realtek: pcs: fix PLL_CML_CTRL for serdes 0/1
authorMarkus Stockhausen <markus.stockhausen@gmx.de>
Mon, 9 Feb 2026 19:26:07 +0000 (20:26 +0100)
committerRobert Marko <robimarko@gmail.com>
Thu, 12 Feb 2026 15:58:46 +0000 (16:58 +0100)
commitfdc37760684e784d7c305796c7fba4a9ef891f1c
tree7655dd7eba24cff2c4ad1b2dce509ee3cf6f14fe
parent8c6ed4e927373282b654420ad3962a6a0ea110c3
realtek: pcs: fix PLL_CML_CTRL for serdes 0/1

Setup of register PLL_CML_CTRL has two issues.

- It clears out bits 4-31 due to a wrong mask
- Setup of bits 0-3 is not generic but depends on the mode of
  serdes 0/1

Fix that by relocating the code and adapting the mask. The error
exists for longer but it has survived the pcs refactoring. Thus
blame the corresponding refactoring commit.

Fixes: b670d48 ("realtek: pcs: rtl838x: refactor imported code")
Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/21956
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c