From 0524af034f0f62e7d69224c2f13e7f01b93d8740 Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Thu, 6 Nov 2025 12:06:57 +0100 Subject: [PATCH] BUILD: acme: acme_gen_tmp_x509() signedness and unused variables MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fix compilation issues in acme_gen_tmp_x509(). src/acme.c:2665:66: warning: pointer targets in passing argument 4 of ‘X509_NAME_add_entry_by_txt’ differ in signedness [-Wpointer-sign] 2665 | if (X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, "expired", | ^~~~~~~~~ | | | char * In file included from /usr/include/openssl/ssl.h:32, from include/haproxy/openssl-compat.h:19, from include/haproxy/acme-t.h:6, from src/acme.c:16: /usr/include/openssl/x509.h:1074:53: note: expected ‘const unsigned char *’ but argument is of type ‘char *’ 1074 | const unsigned char *bytes, int len, int loc, | ~~~~~~~~~~~~~~~~~~~~~^~~~~ src/acme.c:2630:23: warning: unused variable ‘i’ [-Wunused-variable] 2630 | unsigned int i; | ^ src/acme.c:2629:23: warning: unused variable ‘ctx’ [-Wunused-variable] 2629 | X509V3_CTX ctx; | ^~~ --- src/acme.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/acme.c b/src/acme.c index 9af0a6540..96a0cca42 100644 --- a/src/acme.c +++ b/src/acme.c @@ -2626,8 +2626,6 @@ X509 *acme_gen_tmp_x509() X509 *newcrt = NULL; X509_NAME *name; const EVP_MD *digest; - X509V3_CTX ctx; - unsigned int i; CONF *ctmp = NULL; int key_type; EVP_PKEY *pkey = tmp_pkey; @@ -2662,7 +2660,7 @@ X509 *acme_gen_tmp_x509() goto mkcert_error; /* Set the subject name using the servername but the CN */ - if (X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, "expired", + if (X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, (unsigned char *)"expired", -1, -1, 0) != 1) { X509_NAME_free(name); goto mkcert_error; -- 2.47.3