From 05bc26cbc96bed22e6cfc0cc98e8889c7195caab Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 18 Oct 2017 17:11:21 +0200 Subject: [PATCH] torture: Remove GETADDRINFO test This was the only user of getaddrinfo_send and not run anyway Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- selftest/skip | 1 - source3/selftest/tests.py | 2 +- source3/torture/torture.c | 54 --------------------------------------- 3 files changed, 1 insertion(+), 56 deletions(-) diff --git a/selftest/skip b/selftest/skip index c2c4553c3fe..dd60ab5a1fb 100644 --- a/selftest/skip +++ b/selftest/skip @@ -145,4 +145,3 @@ bench # don't run benchmarks in our selftest ^samba4.blackbox.ktpass # this test isn't portable ... ^samba4.rpc.unixinfo # This contains a server-side getpwuid call which hangs the server when nss_winbindd is in use ^samba.tests.dcerpc.unix # This contains a server-side getpwuid call which hangs the server when nss_winbindd is in use -GETADDRINFO # socket wrapper doesn't support threads diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py index 8efc42c58d0..c1e08d56731 100755 --- a/source3/selftest/tests.py +++ b/source3/selftest/tests.py @@ -72,7 +72,7 @@ tests = ["FDPASS", "LOCK1", "LOCK2", "LOCK3", "LOCK4", "LOCK5", "LOCK6", "LOCK7" "OPEN", "XCOPY", "RENAME", "DELETE", "DELETE-LN", "WILDDELETE", "PROPERTIES", "W2K", "TCON2", "IOCTL", "CHKPATH", "FDSESS", "CHAIN1", "CHAIN2", "OWNER-RIGHTS", "CHAIN3", "PIDHIGH", - "GETADDRINFO", "UID-REGRESSION-TEST", "SHORTNAME-TEST", + "UID-REGRESSION-TEST", "SHORTNAME-TEST", "CASE-INSENSITIVE-CREATE", "SMB2-BASIC", "NTTRANS-FSCTL", "SMB2-NEGPROT", "SMB2-SESSION-REAUTH", "SMB2-SESSION-RECONNECT", "SMB2-FTRUNCATE", "CLEANUP1", diff --git a/source3/torture/torture.c b/source3/torture/torture.c index bb4908fd127..360adad5953 100644 --- a/source3/torture/torture.c +++ b/source3/torture/torture.c @@ -10863,59 +10863,6 @@ static bool run_wbclient_multi_ping(int dummy) return result; } -static void getaddrinfo_finished(struct tevent_req *req) -{ - char *name = (char *)tevent_req_callback_data_void(req); - struct addrinfo *ainfo; - int res; - - res = getaddrinfo_recv(req, &ainfo); - if (res != 0) { - d_printf("gai(%s) returned %s\n", name, gai_strerror(res)); - return; - } - d_printf("gai(%s) succeeded\n", name); - freeaddrinfo(ainfo); -} - -static bool run_getaddrinfo_send(int dummy) -{ - TALLOC_CTX *frame = talloc_stackframe(); - struct fncall_context *ctx; - struct tevent_context *ev; - bool result = false; - const char *names[4] = { "www.samba.org", "notfound.samba.org", - "www.slashdot.org", "heise.de" }; - struct tevent_req *reqs[4]; - int i; - - ev = samba_tevent_context_init(frame); - if (ev == NULL) { - goto fail; - } - - ctx = fncall_context_init(frame, 4); - - for (i=0; i