From 0cce66b3b3a2f5c2523a758498412a02b67a1224 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Tue, 13 May 2025 11:25:43 +0200 Subject: [PATCH] setopt: provide info for CURLE_BAD_FUNCTION_ARGUMENT If CURLE_BAD_FUNCTION_ARGUMENT is returned and failf() has not provided any details, this adds a generic error string that includes the option number. This helps debugging for example the curl tool which does a lot of setopt calls and in reading post fact logs it is not always easy to tell exactly which call that failed. Closes #17337 --- lib/setopt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/setopt.c b/lib/setopt.c index aa8043dc96..885fa8e75d 100644 --- a/lib/setopt.c +++ b/lib/setopt.c @@ -3070,9 +3070,7 @@ CURLcode curl_easy_setopt(CURL *d, CURLoption tag, ...) result = Curl_vsetopt(data, tag, arg); va_end(arg); -#ifdef DEBUGBUILD if(result == CURLE_BAD_FUNCTION_ARGUMENT) - infof(data, "setopt arg 0x%x returned CURLE_BAD_FUNCTION_ARGUMENT", tag); -#endif + failf(data, "setopt 0x%x got bad argument", tag); return result; } -- 2.47.3