From 0e253e250ed0e46f5ff6962c840157da9dab48cd Mon Sep 17 00:00:00 2001 From: Eric Biggers Date: Sat, 1 Nov 2025 18:52:56 -0700 Subject: [PATCH] crypto: x86/aes-gcm-vaes-avx2 - initialize full %rax return register Update aes_gcm_dec_final_vaes_avx2() to be consistent with aes_gcm_dec_final_aesni() and aes_gcm_dec_final_vaes_avx512() by initializing the full %rax return register instead of just %al. Technically this is unnecessary, since these functions return bool. But I think it's worth being extra careful with the result of the tag comparison and also keeping the different implementations consistent. Reviewed-by: Ard Biesheuvel Link: https://lore.kernel.org/r/20251102015256.171536-1-ebiggers@kernel.org Signed-off-by: Eric Biggers --- arch/x86/crypto/aes-gcm-vaes-avx2.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/crypto/aes-gcm-vaes-avx2.S b/arch/x86/crypto/aes-gcm-vaes-avx2.S index d9754e683bde3..93c9504a488ff 100644 --- a/arch/x86/crypto/aes-gcm-vaes-avx2.S +++ b/arch/x86/crypto/aes-gcm-vaes-avx2.S @@ -1123,6 +1123,7 @@ SYM_FUNC_END(aes_gcm_aad_update_vaes_avx2) lea .Lselect_high_bytes_table(%rip), %rax vmovdqu (%rax, TAGLEN64), %xmm1 vpshufb BSWAP_MASK, %xmm1, %xmm1 // select low bytes, not high + xor %eax, %eax vptest %xmm1, %xmm0 sete %al .endif -- 2.47.3