From 0e540f231cbdc8e24e1496cf8ac265b62a983692 Mon Sep 17 00:00:00 2001 From: Shane Lontis Date: Mon, 24 Aug 2020 11:45:57 +1000 Subject: [PATCH] Fix coverity CID #1466375 - Remove dead code. Reviewed-by: Matthias St. Pierre (Merged from https://github.com/openssl/openssl/pull/12708) --- .../encode_decode/encoder_ec.c | 29 +++++++++---------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/providers/implementations/encode_decode/encoder_ec.c b/providers/implementations/encode_decode/encoder_ec.c index ee64e2f802d..ab8e82eb6ed 100644 --- a/providers/implementations/encode_decode/encoder_ec.c +++ b/providers/implementations/encode_decode/encoder_ec.c @@ -69,23 +69,20 @@ static int ossl_prov_print_ec_param_explicit_gen(BIO *out, || EC_POINT_point2bn(group, point, form, gen, ctx) == NULL) return 0; - if (gen != NULL) { - switch (form) { - case POINT_CONVERSION_COMPRESSED: - glabel = "Generator (compressed):"; - break; - case POINT_CONVERSION_UNCOMPRESSED: - glabel = "Generator (uncompressed):"; - break; - case POINT_CONVERSION_HYBRID: - glabel = "Generator (hybrid):"; - break; - default: - return 0; - } - return ossl_prov_print_labeled_bignum(out, glabel, gen); + switch (form) { + case POINT_CONVERSION_COMPRESSED: + glabel = "Generator (compressed):"; + break; + case POINT_CONVERSION_UNCOMPRESSED: + glabel = "Generator (uncompressed):"; + break; + case POINT_CONVERSION_HYBRID: + glabel = "Generator (hybrid):"; + break; + default: + return 0; } - return 1; + return ossl_prov_print_labeled_bignum(out, glabel, gen); } /* Print explicit parameters */ -- 2.47.3