From 0eb727a54d421ac634bee92b6ebaad304fcfe426 Mon Sep 17 00:00:00 2001 From: Rob van der Linde Date: Tue, 31 Oct 2023 12:27:56 +1300 Subject: [PATCH] netcmd: silo member add and remove should not set assigned_silo The Windows tools don't do this either Signed-off-by: Rob van der Linde Reviewed-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- python/samba/netcmd/domain/auth/silo_member.py | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/python/samba/netcmd/domain/auth/silo_member.py b/python/samba/netcmd/domain/auth/silo_member.py index 638ad59b8ca..4094ba76840 100644 --- a/python/samba/netcmd/domain/auth/silo_member.py +++ b/python/samba/netcmd/domain/auth/silo_member.py @@ -69,13 +69,9 @@ class cmd_domain_auth_silo_member_add(Command): if user is None: raise CommandError(f"User '{member}' not found.") - # Set the assigned silo. - user.assigned_silo = silo.dn - - # Add member and save user. + # Add member. try: silo.add_member(ldb, user) - user.save(ldb) except ModelError as e: raise CommandError(e) @@ -172,13 +168,9 @@ class cmd_domain_auth_silo_member_remove(Command): if user is None: raise CommandError(f"User '{member}' not found.") - # Unset the assigned silo. - user.assigned_silo = None - - # Remove member and save user. + # Remove member. try: silo.remove_member(ldb, user) - user.save(ldb) except ModelError as e: raise CommandError(e) -- 2.47.3