From 0fdd7e16a1d2c68e3fa4262c8e7355b0889c5b66 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Thu, 24 Mar 2022 18:39:55 +1300 Subject: [PATCH] samba-tool gpo: clean up tmpdir after create 'fetch' and 'backup' might also leave files in /tmp, but in those cases we want the files. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15006 Signed-off-by: Douglas Bagnall Reviewed-by: David Mulder Autobuild-User(master): Douglas Bagnall Autobuild-Date(master): Sat Aug 6 01:42:09 UTC 2022 on sn-devel-184 --- python/samba/netcmd/gpo.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/samba/netcmd/gpo.py b/python/samba/netcmd/gpo.py index 3b21dc6128c..fe8afa7d9a0 100644 --- a/python/samba/netcmd/gpo.py +++ b/python/samba/netcmd/gpo.py @@ -1296,6 +1296,10 @@ class cmd_create(GPOCommand): else: self.samdb.transaction_commit() + if tmpdir is None: + # Without --tmpdir, we created one in /tmp/. It must go. + shutil.rmtree(self.tmpdir) + self.outf.write("GPO '%s' created as %s\n" % (displayname, gpo)) -- 2.47.3