From 14a333c4f4a81161b9e100c1e7c4bb41e916ac6d Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 12 Nov 2025 17:59:24 +0100 Subject: [PATCH] CLEANUP: stick-tables: Don't needlessly compute shard number in stksess_free() Since commit 0bda33a3e ("MINOR: stick-tables: remove the uneeded read lock in stksess_free()"), the lock on the shard is no longer acquired. So it is useless to still compture the shard number. The result is never used and can be safely removed. --- src/stick_table.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/stick_table.c b/src/stick_table.c index be5db167b..d33c42e5a 100644 --- a/src/stick_table.c +++ b/src/stick_table.c @@ -101,8 +101,6 @@ void __stksess_free(struct stktable *t, struct stksess *ts) */ void stksess_free(struct stktable *t, struct stksess *ts) { - uint shard; - size_t len; void *data; data = stktable_data_ptr(t, ts, STKTABLE_DT_SERVER_KEY); @@ -111,16 +109,6 @@ void stksess_free(struct stktable *t, struct stksess *ts) stktable_data_cast(data, std_t_dict) = NULL; } - if (t->type == SMP_T_STR) - len = strlen((const char *)ts->key.key); - else - len = t->key_size; - - shard = stktable_calc_shard_num(t, ts->key.key, len); - - /* make the compiler happy when shard is not used without threads */ - ALREADY_CHECKED(shard); - __stksess_free(t, ts); } -- 2.47.3