From 14f4f0b820475f65b6a4a7fd3a6a34b0fc50b50a Mon Sep 17 00:00:00 2001 From: Kees Monshouwer Date: Mon, 13 Apr 2015 21:54:54 +0200 Subject: [PATCH] use boost for exception catching --- pdns/test-dnsname_cc.cc | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/pdns/test-dnsname_cc.cc b/pdns/test-dnsname_cc.cc index 2dd4b854ab..42d6449572 100644 --- a/pdns/test-dnsname_cc.cc +++ b/pdns/test-dnsname_cc.cc @@ -114,10 +114,7 @@ BOOST_AUTO_TEST_CASE(test_basic) { build.appendRawLabel("Donald E. Eastlake 3rd"); build.appendRawLabel("example"); BOOST_CHECK_EQUAL(build.toString(), R"(Donald\032E\.\032Eastlake\0323rd.example.)"); - try { - DNSName broken("bert..hubert."); - BOOST_CHECK(0); - }catch(...){} + BOOST_CHECK_THROW(DNSName broken("bert..hubert."), std::runtime_error); DNSName n; n.appendRawLabel("powerdns.dnsmaster"); @@ -148,20 +145,7 @@ BOOST_AUTO_TEST_CASE(test_trim) { } BOOST_AUTO_TEST_CASE(test_toolong) { - try { - DNSName w("1234567890123456789012345678901234567890123456789012345678901234567890.com."); - BOOST_CHECK(0); - } - catch(...){} - - - try { - DNSName w("com."); - w.prependRawLabel("1234567890123456789012345678901234567890123456789012345678901234567890"); - BOOST_CHECK(0); - } - catch(...){} - + BOOST_CHECK_THROW(DNSName w("1234567890123456789012345678901234567890123456789012345678901234567890.com."), std::range_error); } BOOST_AUTO_TEST_CASE(test_dnsstrings) { -- 2.47.3