From 1593231e0ef0d36fad7779f2f22b40a284706b9b Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 27 Aug 2020 11:49:07 -0700 Subject: [PATCH] s3: libsmb: Use namecache_store_sa() instead of namecache_store(). Removes one more struct ip_service usage. Signed-off-by: Jeremy Allison Reviewed-by: Noel Power --- source3/libsmb/dsgetdcname.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c index b7720fd50ff..ffe07e089a4 100644 --- a/source3/libsmb/dsgetdcname.c +++ b/source3/libsmb/dsgetdcname.c @@ -1064,7 +1064,6 @@ static NTSTATUS process_dc_netbios(TALLOC_CTX *mem_ctx, int num_dcs, struct netr_DsRGetDCNameInfo **info) { - struct ip_service ip_list; enum nbt_name_type name_type = NBT_NAME_LOGON; NTSTATUS status; int i; @@ -1100,15 +1099,15 @@ static NTSTATUS process_dc_netbios(TALLOC_CTX *mem_ctx, generate_random_buffer((uint8_t *)&val, 2); - ip_list.ss = dclist[i].sa.u.ss; - ip_list.port = 0; - status = nbt_getdc(msg_ctx, 10, &dclist[i].sa.u.ss, domain_name, NULL, my_acct_name, ACB_WSTRUST, nt_version, mem_ctx, &nt_version, &dc_name, &r); if (NT_STATUS_IS_OK(status)) { store_cache = true; - namecache_store(dc_name, NBT_NAME_SERVER, 1, &ip_list); + namecache_store_sa(dc_name, + NBT_NAME_SERVER, + 1, + &dclist[i].sa); goto make_reply; } @@ -1137,7 +1136,10 @@ static NTSTATUS process_dc_netbios(TALLOC_CTX *mem_ctx, map_netlogon_samlogon_response(r); - namecache_store(tmp_dc_name, NBT_NAME_SERVER, 1, &ip_list); + namecache_store_sa(tmp_dc_name, + NBT_NAME_SERVER, + 1, + &dclist[i].sa); goto make_reply; } -- 2.47.3