From 1652491cc6ef44c803e58c0d842818ab7310f498 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sun, 9 Jun 2013 20:36:37 -0400 Subject: [PATCH] this comment is ancient --- lib/sqlalchemy/dialects/mysql/base.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py index 2642b5fdce..d5e33c8027 100644 --- a/lib/sqlalchemy/dialects/mysql/base.py +++ b/lib/sqlalchemy/dialects/mysql/base.py @@ -1351,11 +1351,6 @@ class MySQLCompiler(compiler.SQLCompiler): return "" def visit_join(self, join, asfrom=False, **kwargs): - # 'JOIN ... ON ...' for inner joins isn't available until 4.0. - # Apparently < 3.23.17 requires theta joins for inner joins - # (but not outer). Not generating these currently, but - # support can be added, preferably after dialects are - # refactored to be version-sensitive. return ''.join( (self.process(join.left, asfrom=True, **kwargs), (join.isouter and " LEFT OUTER JOIN " or " INNER JOIN "), -- 2.47.3