From 197883838f8ecb027e9d0375ff5238aec1567a42 Mon Sep 17 00:00:00 2001
From: Tim Beale <timbeale@catalyst.net.nz>
Date: Fri, 6 Oct 2017 16:30:40 +1300
Subject: [PATCH] selftest: Add basic test for schema upgrade

This tests that we can provision using both the 2008 and 2012 schema,
that we can upgrade a 2008 Samba instance to use the 2012 schema, and
that when we do that the result (more or less) matches a straight
2012 provision.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---
 selftest/tests.py                   |  5 ++
 testprogs/blackbox/schemaupgrade.sh | 80 +++++++++++++++++++++++++++++
 2 files changed, 85 insertions(+)
 create mode 100755 testprogs/blackbox/schemaupgrade.sh

diff --git a/selftest/tests.py b/selftest/tests.py
index e65d63d8c6a..713e9d3fbcd 100644
--- a/selftest/tests.py
+++ b/selftest/tests.py
@@ -131,6 +131,11 @@ plantestsuite(
     ["PYTHON=%s" % python,
      os.path.join(bbdir, "runtime-links.sh"),
      '$PREFIX_ABS/provision', 'release-4-5-0-pre1', configuration])
+plantestsuite(
+    "samba4.blackbox.schemaupgrade", "none",
+    ["PYTHON=%s" % python,
+     os.path.join(bbdir, "schemaupgrade.sh"),
+     '$PREFIX_ABS/provision', configuration])
 planpythontestsuite("none", "samba.tests.upgradeprovision")
 planpythontestsuite("none", "samba.tests.xattr", py3_compatible=True)
 planpythontestsuite("none", "samba.tests.ntacls")
diff --git a/testprogs/blackbox/schemaupgrade.sh b/testprogs/blackbox/schemaupgrade.sh
new file mode 100755
index 00000000000..d79915a78fe
--- /dev/null
+++ b/testprogs/blackbox/schemaupgrade.sh
@@ -0,0 +1,80 @@
+#!/bin/sh
+
+if [ $# -lt 1 ]; then
+cat <<EOF
+Usage: $0 PREFIX
+EOF
+exit 1;
+fi
+
+PREFIX_ABS="$1"
+shift 1
+
+. `dirname $0`/subunit.sh
+
+cleanup_output_directories()
+{
+    if [ -d $PREFIX_ABS/2012R2_schema ]; then
+        rm -fr $PREFIX_ABS/2012R2_schema
+    fi
+
+    if [ -d $PREFIX_ABS/2008R2_schema ]; then
+        rm -fr $PREFIX_ABS/2008R2_schema
+    fi
+}
+
+PROVISION_OPTS="--use-ntvfs --host-ip6=::1 --host-ip=127.0.0.1"
+
+provision_2012r2() {
+    $PYTHON $BINDIR/samba-tool domain provision $PROVISION_OPTS --domain=SAMBA --realm=w2012r2.samba.corp --targetdir=$PREFIX_ABS/2012R2_schema --base-schema=2012_R2
+}
+
+provision_2008r2() {
+    $PYTHON $BINDIR/samba-tool domain provision $PROVISION_OPTS --domain=SAMBA --realm=w2008r2.samba.corp --targetdir=$PREFIX_ABS/2008R2_schema --base-schema=2008_R2
+}
+
+ldapcmp() {
+
+    # the original 2008 schema we received from Microsoft was missing
+    # descriptions and display names. This has been fixed up in the current
+    # Microsoft schemas
+    IGNORE_ATTRS="adminDescription,description,adminDisplayName,displayName"
+
+    # we didn't get showInAdvancedViewOnly right on Samba
+    IGNORE_ATTRS="$IGNORE_ATTRS,showInAdvancedViewOnly"
+
+    # there's discrepancies between the SDDL strings in the adprep LDIF files
+    # vs the 2012 schema, where one source will have ACE rights repeated, e.g.
+    # "LOLO" in adprep vs "LO" in the schema
+    IGNORE_ATTRS="$IGNORE_ATTRS,defaultSecurityDescriptor"
+
+    # the adprep LDIF files updates these attributes for the DisplaySpecifiers
+    # objects, but we don't have the 2012 DisplaySpecifiers documentation...
+    IGNORE_ATTRS="$IGNORE_ATTRS,adminContextMenu,adminPropertyPages"
+
+    $PYTHON $BINDIR/samba-tool ldapcmp tdb://$PREFIX_ABS/2008R2_schema/private/sam.ldb tdb://$PREFIX_ABS/2012R2_schema/private/sam.ldb --two --filter=$IGNORE_ATTRS
+}
+
+schema_upgrade() {
+	$BINDIR/samba-tool domain schemaupgrade -H tdb://$PREFIX_ABS/2008R2_schema/private/sam.ldb --schema=2012_R2
+}
+
+# double-check we cleaned up from the last test run
+cleanup_output_directories
+
+# Provision 2 DCs, one based on the 2008R2 schema and one using 2012R2
+testit "provision_2008R2_schema" provision_2008r2
+testit "provision_2012R2_schema" provision_2012r2
+
+# we expect the 2 schemas to be different
+testit_expect_failure "expect_schema_differences" ldapcmp
+
+# upgrade the 2008 schema to 2012
+testit "schema_upgrade" schema_upgrade
+
+# check that the 2 schemas are now the same
+testit "check_schemas_same" ldapcmp
+
+cleanup_output_directories
+
+exit $failed
-- 
2.47.3