From 19b062a492c29cba493b6865cfec652a8e2df063 Mon Sep 17 00:00:00 2001
From: Dan Fandrich <dan@coneharvesters.com>
Date: Sat, 8 Apr 2023 15:27:39 -0700
Subject: [PATCH] runtests: abort early if runpingpongserver is given a bad
 server type

---
 tests/servers.pm | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/tests/servers.pm b/tests/servers.pm
index b16a66f31c..0f63c585df 100644
--- a/tests/servers.pm
+++ b/tests/servers.pm
@@ -1468,6 +1468,13 @@ sub runhttptlsserver {
 #
 sub runpingpongserver {
     my ($proto, $id, $verb, $ipv6) = @_;
+
+    # Check the requested server
+    if($proto !~ /^(?:ftp|imap|pop3|smtp)$/) {
+        print STDERR "Unsupported protocol $proto!!\n";
+        return (0,0);
+    }
+
     my $ip = ($ipv6 && ($ipv6 =~ /6$/)) ? "$HOST6IP" : "$HOSTIP";
     my $ipvnum = ($ipv6 && ($ipv6 =~ /6$/)) ? 6 : 4;
     my $idnum = ($id && ($id =~ /^(\d+)$/) && ($id > 1)) ? $id : 1;
@@ -1532,13 +1539,7 @@ sub runpingpongserver {
     logmsg "RUN: $srvrname server is PID $ftppid port $port\n" if($verb);
 
     # Assign the correct port variable!
-    if($proto =~ /^(?:ftp|imap|pop3|smtp)$/) {
-        $PORT{$proto . ($ipvnum == 6? '6': '')} = $port;
-    }
-    else {
-        print STDERR "Unsupported protocol $proto!!\n";
-        return (0,0);
-    }
+    $PORT{$proto . ($ipvnum == 6? '6': '')} = $port;
 
     return ($pid2, $ftppid);
 }
-- 
2.47.3